Scripts from the following list were installed with group write
bit set: virt-xml-validate, virt-pki-validate,
virt-sanlock-cleanup, libvirt-guests.sh. This is very unusual and
in contrast with the way other scripts/binaries are installed.

Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=2151202
Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
---
 tools/meson.build | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/tools/meson.build b/tools/meson.build
index c41c619af4..fad7f202ad 100644
--- a/tools/meson.build
+++ b/tools/meson.build
@@ -249,7 +249,7 @@ configure_file(
   configuration: tools_conf,
   install: true,
   install_dir: bindir,
-  install_mode: 'rwxrwxr-x',
+  install_mode: 'rwxr-xr-x',
 )
 
 configure_file(
@@ -258,7 +258,7 @@ configure_file(
   configuration: tools_conf,
   install: true,
   install_dir: bindir,
-  install_mode: 'rwxrwxr-x',
+  install_mode: 'rwxr-xr-x',
 )
 
 executable(
@@ -295,7 +295,7 @@ if conf.has('WITH_SANLOCK')
     configuration: tools_conf,
     install: true,
     install_dir: sbindir,
-    install_mode: 'rwxrwxr-x',
+    install_mode: 'rwxr-xr-x',
   )
 endif
 
@@ -311,7 +311,7 @@ if conf.has('WITH_LIBVIRTD')
     configuration: tools_conf,
     install: true,
     install_dir: libexecdir,
-    install_mode: 'rwxrwxr-x',
+    install_mode: 'rwxr-xr-x',
   )
 
   if init_script == 'systemd'
-- 
2.37.4

On Thu, Dec 08, 2022 at 08:52:52 +0100, Michal Privoznik wrote:
> Scripts from the following list were installed with group write
> bit set: virt-xml-validate, virt-pki-validate,
> virt-sanlock-cleanup, libvirt-guests.sh. This is very unusual and
> in contrast with the way other scripts/binaries are installed.
> 
> Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=2151202
> Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
> ---
>  tools/meson.build | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)

Reviewed-by: Jiri Denemark <jdenemar@redhat.com>

On Thu, Dec 08, 2022 at 08:52:52 +0100, Michal Privoznik wrote:
> Scripts from the following list were installed with group write
> bit set: virt-xml-validate, virt-pki-validate,
> virt-sanlock-cleanup, libvirt-guests.sh. This is very unusual and
> in contrast with the way other scripts/binaries are installed.
> 
> Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=2151202
> Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
> ---
>  tools/meson.build | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)

Reviewed-by: Peter Krempa <pkrempa@redhat.com>