[PATCH] domain_event: Drop virDomainEventMemoryDeviceSizeChangePtr

Michal Privoznik posted 1 patch 10 months, 3 weeks ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/53035b75bdb7011f79454547a6d7b2a0bb5b90e6.1687948076.git.mprivozn@redhat.com
src/conf/domain_event.c | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)
[PATCH] domain_event: Drop virDomainEventMemoryDeviceSizeChangePtr
Posted by Michal Privoznik 10 months, 3 weeks ago
We dropped our private virXXXPtr typedefs in v7.3.0-rc1~229 but
somehow v7.9.0-rc1~292 introduced one back:
virDomainEventMemoryDeviceSizeChangePtr. There's no need for it
and it's internal only. Drop it.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
---
 src/conf/domain_event.c | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/src/conf/domain_event.c b/src/conf/domain_event.c
index 94b7335e56..75603a933a 100644
--- a/src/conf/domain_event.c
+++ b/src/conf/domain_event.c
@@ -284,7 +284,6 @@ struct _virDomainEventMemoryDeviceSizeChange {
     unsigned long long size;
 };
 typedef struct _virDomainEventMemoryDeviceSizeChange virDomainEventMemoryDeviceSizeChange;
-typedef virDomainEventMemoryDeviceSizeChange *virDomainEventMemoryDeviceSizeChangePtr;
 
 static int
 virDomainEventsOnceInit(void)
@@ -554,7 +553,7 @@ virDomainEventMemoryFailureDispose(void *obj)
 static void
 virDomainEventMemoryDeviceSizeChangeDispose(void *obj)
 {
-    virDomainEventMemoryDeviceSizeChangePtr event = obj;
+    virDomainEventMemoryDeviceSizeChange *event = obj;
     VIR_DEBUG("obj=%p", event);
 
     g_free(event->alias);
@@ -1692,7 +1691,7 @@ virDomainEventMemoryDeviceSizeChangeNew(int id,
                                         const char *alias,
                                         unsigned long long size)
 {
-    virDomainEventMemoryDeviceSizeChangePtr ev;
+    virDomainEventMemoryDeviceSizeChange *ev;
 
     if (virDomainEventsInitialize() < 0)
         return NULL;
@@ -2033,9 +2032,9 @@ virDomainEventDispatchDefaultFunc(virConnectPtr conn,
 
     case VIR_DOMAIN_EVENT_ID_MEMORY_DEVICE_SIZE_CHANGE:
         {
-            virDomainEventMemoryDeviceSizeChangePtr memoryDeviceSizeChangeEvent;
+            virDomainEventMemoryDeviceSizeChange *memoryDeviceSizeChangeEvent;
 
-            memoryDeviceSizeChangeEvent = (virDomainEventMemoryDeviceSizeChangePtr)event;
+            memoryDeviceSizeChangeEvent = (virDomainEventMemoryDeviceSizeChange *)event;
             ((virConnectDomainEventMemoryDeviceSizeChangeCallback)cb)(conn, dom,
                                                                       memoryDeviceSizeChangeEvent->alias,
                                                                       memoryDeviceSizeChangeEvent->size,
-- 
2.39.3
Re: [PATCH] domain_event: Drop virDomainEventMemoryDeviceSizeChangePtr
Posted by Peter Krempa 10 months, 3 weeks ago
On Wed, Jun 28, 2023 at 12:27:56 +0200, Michal Privoznik wrote:
> We dropped our private virXXXPtr typedefs in v7.3.0-rc1~229 but
> somehow v7.9.0-rc1~292 introduced one back:
> virDomainEventMemoryDeviceSizeChangePtr. There's no need for it
> and it's internal only. Drop it.
> 
> Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
> ---
>  src/conf/domain_event.c | 9 ++++-----
>  1 file changed, 4 insertions(+), 5 deletions(-)

Reviewed-by: Peter Krempa <pkrempa@redhat.com>