From nobody Sun May 19 16:58:47 2024 Delivered-To: importer@patchew.org Received-SPF: none (zohomail.com: 8.43.85.245 is neither permitted nor denied by domain of lists.libvirt.org) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; spf=none (zohomail.com: 8.43.85.245 is neither permitted nor denied by domain of lists.libvirt.org) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1714156188454533.8177279478002; Fri, 26 Apr 2024 11:29:48 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 347A5178B; Fri, 26 Apr 2024 14:29:47 -0400 (EDT) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id D8FD719C7; Fri, 26 Apr 2024 14:29:08 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 996) id 8B4A716ED; Fri, 26 Apr 2024 14:29:05 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 153F61670 for ; Fri, 26 Apr 2024 14:29:05 -0400 (EDT) Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-495-JVVhhhwPP6iP4d-SLz3t7A-1; Fri, 26 Apr 2024 14:29:02 -0400 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 8B6091C0515D for ; Fri, 26 Apr 2024 18:29:02 +0000 (UTC) Received: from ajulis-thinkpadt14gen4.remote.csb (unknown [10.39.192.11]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1EF9940F566 for ; Fri, 26 Apr 2024 18:29:02 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.4 X-MC-Unique: JVVhhhwPP6iP4d-SLz3t7A-1 From: Adam Julis To: devel@lists.libvirt.org Subject: [PATCH] qemu_saveimage: add zstd to supported compression formats Date: Fri, 26 Apr 2024 20:28:47 +0200 Message-ID: <52b8be2bfa46ab1bf67c34d362ac6efccd275802.1714156085.git.ajulis@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.9 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Message-ID-Hash: G6AEH5PCHAAE5QDUYUZD4FLVQMVPFUO6 X-Message-ID-Hash: G6AEH5PCHAAE5QDUYUZD4FLVQMVPFUO6 X-MailFrom: ajulis@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="utf-8"; x-default="true" Content-Transfer-Encoding: quoted-printable X-ZM-MESSAGEID: 1714156189567100001 Extend the list of supported formats, update and clarify comment in qemu.conf.in (removed misleading sentence about the order of compression format types). Signed-off-by: Adam Julis Reviewed-by: Michal Privoznik --- libvirt.spec.in | 1 + src/qemu/qemu.conf.in | 7 +++---- src/qemu/qemu_saveimage.c | 2 ++ 3 files changed, 6 insertions(+), 4 deletions(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index 64018192b6..88c62f6d92 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -815,6 +815,7 @@ Requires: gzip Requires: bzip2 Requires: lzop Requires: xz +Requires: zstd Requires: systemd-container Requires: swtpm-tools %if %{with_numad} diff --git a/src/qemu/qemu.conf.in b/src/qemu/qemu.conf.in index f406df8749..6bc2140dcb 100644 --- a/src/qemu/qemu.conf.in +++ b/src/qemu/qemu.conf.in @@ -582,10 +582,9 @@ # memory from the domain is dumped out directly to a file. If you have # guests with a large amount of memory, however, this can take up quite # a bit of space. If you would like to compress the images while they -# are being saved to disk, you can also set "lzop", "gzip", "bzip2", or "x= z" -# for save_image_format. Note that this means you slow down the process of -# saving a domain in order to save disk space; the list above is in descen= ding -# order by performance and ascending order by compression ratio. +# are being saved to disk, you can also set "zstd", "lzop", "gzip", "bzip2= ", +# or "xz" for save_image_format. Note that this means you slow down the pr= ocess +# of saving a domain in order to save disk space. # # save_image_format is used when you use 'virsh save' or 'virsh managedsav= e' # at scheduled saving, and it is an error if the specified save_image_form= at diff --git a/src/qemu/qemu_saveimage.c b/src/qemu/qemu_saveimage.c index 89112e3e44..018ab5a222 100644 --- a/src/qemu/qemu_saveimage.c +++ b/src/qemu/qemu_saveimage.c @@ -47,6 +47,7 @@ typedef enum { */ QEMU_SAVE_FORMAT_XZ =3D 3, QEMU_SAVE_FORMAT_LZOP =3D 4, + QEMU_SAVE_FORMAT_ZSTD =3D 5, /* Note: add new members only at the end. These values are used in the on-disk format. Do not change or re-use numbers. */ @@ -62,6 +63,7 @@ VIR_ENUM_IMPL(qemuSaveCompression, "bzip2", "xz", "lzop", + "zstd", ); =20 static inline void --=20 2.44.0 _______________________________________________ Devel mailing list -- devel@lists.libvirt.org To unsubscribe send an email to devel-leave@lists.libvirt.org