[libvirt] [RFC PATCH] travis: require libgnutls28-dev

Ján Tomko posted 1 patch 5 years, 10 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/4d0e9e411a62025c838768666044cb1ba166ba7a.1528184053.git.jtomko@redhat.com
Test syntax-check passed
.travis.yml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[libvirt] [RFC PATCH] travis: require libgnutls28-dev
Posted by Ján Tomko 5 years, 10 months ago
Since commit <eee8c85> we require GnuTLS >= 3.2.0.
Install the aptly-named libgnutls28-dev package
instead of plain libgnutls-dev.

Signed-off-by: Ján Tomko <jtomko@redhat.com>
---
RFC, since I haven't even started to figure out how to test it.

Exposed by commit 3bf1959 which led to
virCryptoHaveCipher(VIR_CRYPTO_CIPHER_AES256CBC)
being called from the test suite, in qemuDomainSupportsEncryptedSecret.

The proper fix for non-GnuTLS user is probably disabling the build
of QEMU driver without GnuTLS, since capabilities caching won't work
properly anyway without the hash functions.

 .travis.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.travis.yml b/.travis.yml
index f4dd0427a9..3f7c67398a 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -60,7 +60,7 @@ addons:
       - libdbus-1-dev
       - libdevmapper-dev
       - libfuse-dev
-      - libgnutls-dev
+      - libgnutls28-dev
       - libnetcf-dev
       - libnl-3-dev
       - libnl-route-3-dev
-- 
2.13.6

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [RFC PATCH] travis: require libgnutls28-dev
Posted by Andrea Bolognani 5 years, 10 months ago
On Tue, 2018-06-05 at 09:37 +0200, Ján Tomko wrote:
> Since commit <eee8c85> we require GnuTLS >= 3.2.0.
> Install the aptly-named libgnutls28-dev package
> instead of plain libgnutls-dev.
> 
> Signed-off-by: Ján Tomko <jtomko@redhat.com>
> ---
> RFC, since I haven't even started to figure out how to test it.
> 
> Exposed by commit 3bf1959 which led to
> virCryptoHaveCipher(VIR_CRYPTO_CIPHER_AES256CBC)
> being called from the test suite, in qemuDomainSupportsEncryptedSecret.
> 
> The proper fix for non-GnuTLS user is probably disabling the build
> of QEMU driver without GnuTLS, since capabilities caching won't work
> properly anyway without the hash functions.

Michal just posted patches[1] that make GnuTLS mandatory. I'll
add more thoughts about the topic there.


[1] https://www.redhat.com/archives/libvir-list/2018-June/msg00316.html
-- 
Andrea Bolognani / Red Hat / Virtualization

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [RFC PATCH] travis: require libgnutls28-dev
Posted by Daniel P. Berrangé 5 years, 10 months ago
On Tue, Jun 05, 2018 at 09:37:55AM +0200, Ján Tomko wrote:
> Since commit <eee8c85> we require GnuTLS >= 3.2.0.
> Install the aptly-named libgnutls28-dev package
> instead of plain libgnutls-dev.
> 
> Signed-off-by: Ján Tomko <jtomko@redhat.com>
> ---
> RFC, since I haven't even started to figure out how to test it.

I doesn't work I'm afraid, because something else in the build env
still pulls in libgnutls-dev, and that conflicts with libgnutls28-dev

> 
> Exposed by commit 3bf1959 which led to
> virCryptoHaveCipher(VIR_CRYPTO_CIPHER_AES256CBC)
> being called from the test suite, in qemuDomainSupportsEncryptedSecret.
> 
> The proper fix for non-GnuTLS user is probably disabling the build
> of QEMU driver without GnuTLS, since capabilities caching won't work
> properly anyway without the hash functions.
> 
>  .travis.yml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/.travis.yml b/.travis.yml
> index f4dd0427a9..3f7c67398a 100644
> --- a/.travis.yml
> +++ b/.travis.yml
> @@ -60,7 +60,7 @@ addons:
>        - libdbus-1-dev
>        - libdevmapper-dev
>        - libfuse-dev
> -      - libgnutls-dev
> +      - libgnutls28-dev
>        - libnetcf-dev
>        - libnl-3-dev
>        - libnl-route-3-dev
> -- 
> 2.13.6
> 
> --
> libvir-list mailing list
> libvir-list@redhat.com
> https://www.redhat.com/mailman/listinfo/libvir-list

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [RFC PATCH] travis: require libgnutls28-dev
Posted by Pavel Hrdina 5 years, 10 months ago
On Tue, Jun 05, 2018 at 09:37:55AM +0200, Ján Tomko wrote:
> Since commit <eee8c85> we require GnuTLS >= 3.2.0.
> Install the aptly-named libgnutls28-dev package
> instead of plain libgnutls-dev.
> 
> Signed-off-by: Ján Tomko <jtomko@redhat.com>
> ---
> RFC, since I haven't even started to figure out how to test it.
> 
> Exposed by commit 3bf1959 which led to
> virCryptoHaveCipher(VIR_CRYPTO_CIPHER_AES256CBC)
> being called from the test suite, in qemuDomainSupportsEncryptedSecret.
> 
> The proper fix for non-GnuTLS user is probably disabling the build
> of QEMU driver without GnuTLS, since capabilities caching won't work
> properly anyway without the hash functions.

I've just requested another node for our centos CI in order to install
current not outdated Ubuntu guests so we can ignore this travis error
and once we have our new guests we can use travis only for macOS builds.

Pavel
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list