From nobody Sun May 12 14:45:39 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1694777505; cv=none; d=zohomail.com; s=zohoarc; b=WTkTyEIgiRLi6wUrMPRHF6+6cSeKibVuvKMA+VwdP/6RWqEGEHd1o1DMPHiosgd++sVNzvww9bYUsSBdHduw2oeLDEMujfklW5+565G+NEbihMCFkOOWAc7hKPt9ZxByEfZtea+/VL/AQM7KyHZ032in/hnJXvNXBJdAsKmz/X4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1694777505; h=Content-Type:Content-Transfer-Encoding:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=PDeW27jpYsaOJFCoJ0HxGq7SzZRuaTs9izULxS/4Bq0=; b=laX8i1t7lckhL/5kpR6e4gLdYkfjUMKykJwVRggU/WBxUAb2akxd0cf4yy2A+VUPCFRFSbxyRNUGHHRJqYqBGNdVkXlFfUVAyYdU8HykzLD+FbHROlf3k5vyuH3fNEt7mfRZv/5k4TlXNVsIR5V6Tc6ol1rBK7kzGl3o1H31NeQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1694777505626765.3524666562666; Fri, 15 Sep 2023 04:31:45 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-498-XkOPyLSqNDWMaTUKvp3utA-1; Fri, 15 Sep 2023 07:31:42 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 1091D185A79B; Fri, 15 Sep 2023 11:31:40 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id CD415404C3C1; Fri, 15 Sep 2023 11:31:36 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 49C0E194658C; Fri, 15 Sep 2023 11:31:31 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 18ED21946588 for ; Fri, 15 Sep 2023 11:31:30 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id F22EC40C6EA8; Fri, 15 Sep 2023 11:31:24 +0000 (UTC) Received: from maggie.brq.redhat.com (unknown [10.43.2.46]) by smtp.corp.redhat.com (Postfix) with ESMTP id 99EBD40C6EBF for ; Fri, 15 Sep 2023 11:31:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1694777504; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=PDeW27jpYsaOJFCoJ0HxGq7SzZRuaTs9izULxS/4Bq0=; b=WV8/ohrGVTXlm1HPI0tdM2/qFNcASsKjCy0XdN7jv9HjZkwZOweAgBiJqrJZSbSIMEPVGS sXEMw7+hg/6Tj8hwRxS/KeDUYsAYGdxkUVqDnJ0DS5KRsBE4IpDli+VVCuRZ+/5h73nHBE 9GCGltOlyYhiKCviY+YgXvlwBl0U888= X-MC-Unique: XkOPyLSqNDWMaTUKvp3utA-1 X-Original-To: libvir-list@listman.corp.redhat.com From: Michal Privoznik To: libvir-list@redhat.com Subject: [PATCH merged] bhyveBuildControllerArgStr: Fill in missing cases to switch() statement Date: Fri, 15 Sep 2023 13:31:17 +0200 Message-ID: <47230842aa6bca1da75cc92c50144f223d1ad1d3.1694777461.git.mprivozn@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.2 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1694777507059100001 Content-Type: text/plain; charset="utf-8"; x-default="true" When making 'type' member of virDomainControllerDef to be of virDomainControllerType rather than an int I forgot to update bhyve_command.c. Fixes: 27a653b8931051991d44b8776a8cdc08c666b729 Signed-off-by: Michal Privoznik --- Pushed as build breaker fix. src/bhyve/bhyve_command.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/src/bhyve/bhyve_command.c b/src/bhyve/bhyve_command.c index 82e7e96816..bcef836eca 100644 --- a/src/bhyve/bhyve_command.c +++ b/src/bhyve/bhyve_command.c @@ -367,6 +367,18 @@ bhyveBuildControllerArgStr(const virDomainDef *def, virCommandAddArgFormat(cmd, "%d:0,lpc", controller->info.addr.pci.slot); break; + case VIR_DOMAIN_CONTROLLER_TYPE_IDE: + case VIR_DOMAIN_CONTROLLER_TYPE_FDC: + case VIR_DOMAIN_CONTROLLER_TYPE_SCSI: + case VIR_DOMAIN_CONTROLLER_TYPE_VIRTIO_SERIAL: + case VIR_DOMAIN_CONTROLLER_TYPE_CCID: + case VIR_DOMAIN_CONTROLLER_TYPE_XENBUS: + case VIR_DOMAIN_CONTROLLER_TYPE_LAST: + default: + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", + _("unsupported controller device")); + return -1; + } return 0; } --=20 2.41.0