From nobody Tue Apr 23 10:16:03 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; envelope-from=libvir-list-bounces@redhat.com; helo=mx1.redhat.com; Authentication-Results: mx.zohomail.com; spf=pass (zoho.com: domain of redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by mx.zohomail.com with SMTPS id 1526385123213981.6854311234296; Tue, 15 May 2018 04:52:03 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.26]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id A918C30C2E8E; Tue, 15 May 2018 11:52:01 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1B18530BE009; Tue, 15 May 2018 11:52:01 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 0462B4BB78; Tue, 15 May 2018 11:52:00 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id w4FBpwUG021630 for ; Tue, 15 May 2018 07:51:58 -0400 Received: by smtp.corp.redhat.com (Postfix) id 5DE4063F20; Tue, 15 May 2018 11:51:58 +0000 (UTC) Received: from moe.brq.redhat.com (unknown [10.43.2.192]) by smtp.corp.redhat.com (Postfix) with ESMTP id 039CD1C5B5 for ; Tue, 15 May 2018 11:51:55 +0000 (UTC) From: Michal Privoznik To: libvir-list@redhat.com Date: Tue, 15 May 2018 13:51:45 +0200 Message-Id: <45737a45080ea55783604331d464e69001908084.1526385105.git.mprivozn@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH] virDomainMemoryDefParseXML: Don't leak discard X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.26 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.47]); Tue, 15 May 2018 11:52:02 +0000 (UTC) X-ZohoMail: RSF_0 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" =3D=3D1589=3D=3D 7 bytes in 2 blocks are definitely lost in loss record 34 = of 261 =3D=3D1589=3D=3D at 0x4C2AF0F: malloc (vg_replace_malloc.c:299) =3D=3D1589=3D=3D by 0x8A82794: xmlStrndup (in /usr/lib64/libxml2.so.2.9.= 8) =3D=3D1589=3D=3D by 0x5DD8392: virXMLPropString (virxml.c:510) =3D=3D1589=3D=3D by 0x5E12427: virDomainMemoryDefParseXML (domain_conf.c= :15704) =3D=3D1589=3D=3D by 0x5E207DE: virDomainDefParseXML (domain_conf.c:20351) =3D=3D1589=3D=3D by 0x5E2184F: virDomainDefParseNode (domain_conf.c:2063= 6) =3D=3D1589=3D=3D by 0x5E216A1: virDomainDefParse (domain_conf.c:20580) =3D=3D1589=3D=3D by 0x5E21747: virDomainDefParseFile (domain_conf.c:2060= 6) =3D=3D1589=3D=3D by 0x112F5F: testCompareXMLToArgv (qemuxml2argvtest.c:4= 93) =3D=3D1589=3D=3D by 0x138780: virTestRun (testutils.c:180) =3D=3D1589=3D=3D by 0x117129: mymain (qemuxml2argvtest.c:937) =3D=3D1589=3D=3D by 0x13A83C: virTestMain (testutils.c:1120) Signed-off-by: Michal Privoznik Reviewed-by: Marc Hartmayer --- src/conf/domain_conf.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index d38a775f21..338fbc0e61 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -15710,6 +15710,7 @@ virDomainMemoryDefParseXML(virDomainXMLOptionPtr xm= lopt, =20 def->discard =3D val; } + VIR_FREE(tmp); =20 /* source */ if ((node =3D virXPathNode("./source", ctxt)) && --=20 2.16.1 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list