From nobody Fri May 10 21:19:13 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1646141458; cv=none; d=zohomail.com; s=zohoarc; b=cERsLPkAP/6Z/WNy+6cZJy4QYFxFCCccE+yjMsHBD/EFa2TDmNdKxgZD48ivUEOII9Uwmrd/DpxQpSwGjQ0ywTDamhWcmK4sFIKE3Aue3JZAr2pSCVzlFXL+zL4U0ESz6P/OgX6IM+RQ6V1CXBE4g0my8bUXJahreRFLlfxhvgM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1646141458; h=Content-Type:Content-Transfer-Encoding:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=TEb726ogLWrf+EetrvsKmT21qpe0RXcEgy7yMxtCsEo=; b=GxCj2l7T2zw16cYSFZ1E+M5FgWEkOwn0BhBrJqkF73okDI3ak+6siUIKaFbKh6TfVZhnDFasTJ4k2tIYcrcqFZWPqeIp6QyfwWvX43zOnL7/gUqhPvgwam9OE+7uPNLxlMy+nR7q79g1uNnAFY1ptP8Ce/MzFFJDgNzGJV0HpFY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.zohomail.com with SMTPS id 1646141458196555.5336849044565; Tue, 1 Mar 2022 05:30:58 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-317-Nl4ZiGVlNpuCNfzBbQ6BEQ-1; Tue, 01 Mar 2022 08:30:55 -0500 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id F339C180FD72; Tue, 1 Mar 2022 13:30:48 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B05147B8D7; Tue, 1 Mar 2022 13:30:47 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 877001809CB2; Tue, 1 Mar 2022 13:30:43 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 221DUfm1020881 for ; Tue, 1 Mar 2022 08:30:41 -0500 Received: by smtp.corp.redhat.com (Postfix) id E57167B8D6; Tue, 1 Mar 2022 13:30:41 +0000 (UTC) Received: from speedmetal.redhat.com (unknown [10.40.208.41]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4B44A7B8D5 for ; Tue, 1 Mar 2022 13:30:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1646141457; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=TEb726ogLWrf+EetrvsKmT21qpe0RXcEgy7yMxtCsEo=; b=dCFC4vZpEUqN4++hcyEtDC+iK8nuJ9jhIwzwzcY2H8+YS4y/pPdkKAMGjpTHFJwvn5qg4l ObIIMebkmEaI8BlFlhxvqlYnaUDmL8573IQNbxjHGTP4N3xRLpvhxDgQeOMtf024Qp7blQ HjrA5OjqYimjdF9+QxUHp7w1ldLorIM= X-MC-Unique: Nl4ZiGVlNpuCNfzBbQ6BEQ-1 From: Peter Krempa To: libvir-list@redhat.com Subject: [test-fix PATCH] virsh: Require option name for '--pass-fd' argument of 'qemu-monitor-command' Date: Tue, 1 Mar 2022 14:30:40 +0100 Message-Id: <44ea7749f82c093a3387b94d1e40a5fe48609244.1646141403.git.pkrempa@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1646141458794100002 Content-Type: text/plain; charset="utf-8" Require the option name for this argument as otherwise a part of the 'cmd' argument will be claimed. Fixes: 43edde82afb8eb8b808fd985e01898a543a2ffbc Signed-off-by: Peter Krempa --- Pushed as a build fix. tools/virsh-domain.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index 2e21219d63..9b1b14cdc2 100644 --- a/tools/virsh-domain.c +++ b/tools/virsh-domain.c @@ -9723,6 +9723,7 @@ static const vshCmdOptDef opts_qemu_monitor_command[]= =3D { }, {.name =3D "pass-fds", .type =3D VSH_OT_STRING, + .flags =3D VSH_OFLAG_REQ_OPT, .completer =3D virshCompleteEmpty, .help =3D N_("pass file descriptors N,M,... along with the command") }, --=20 2.35.1