The %meson* macros pass --auto-features=enabled to enable all "auto"
features, which means we have to explicitly disable them.

Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
---

Notes:
    Pushed as a build breaker.

 libvirt.spec.in | 1 +
 1 file changed, 1 insertion(+)

diff --git a/libvirt.spec.in b/libvirt.spec.in
index c5ba4b632f..49ce717e1b 100644
--- a/libvirt.spec.in
+++ b/libvirt.spec.in
@@ -1452,6 +1452,7 @@ export SOURCE_DATE_EPOCH=$(stat --printf='%Y' %{_specdir}/libvirt.spec)
   -Dstorage_vstorage=disabled \
   -Dstorage_zfs=disabled \
   -Dsysctl_config=disabled \
+  -Duserfaultfd_sysctl=disabled \
   -Dtests=disabled \
   -Dudev=disabled \
   -Dwireshark_dissector=disabled \
-- 
2.43.0
_______________________________________________
Devel mailing list -- devel@lists.libvirt.org
To unsubscribe send an email to devel-leave@lists.libvirt.org

On Tue, Feb 13, 2024 at 19:16:00 +0100, Jiri Denemark wrote:
> The %meson* macros pass --auto-features=enabled to enable all "auto"
> features, which means we have to explicitly disable them.

This is not the first time we've hit this. I really think the only sane
option for --auto-features= for distributions is to use 'disabled' and
explicitly enable what they need.
_______________________________________________
Devel mailing list -- devel@lists.libvirt.org
To unsubscribe send an email to devel-leave@lists.libvirt.org

On Wed, Feb 14, 2024 at 01:31:29PM +0100, Peter Krempa wrote:
> On Tue, Feb 13, 2024 at 19:16:00 +0100, Jiri Denemark wrote:
> > The %meson* macros pass --auto-features=enabled to enable all "auto"
> > features, which means we have to explicitly disable them.
> 
> This is not the first time we've hit this. I really think the only sane
> option for --auto-features= for distributions is to use 'disabled' and
> explicitly enable what they need.

This is our own fault as Jano already pointed out here [1] we have the
option '--auto-features=enabled' in our own spec file for mingw [2].

Pavel

[1] <https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/message/RXOBFDH6IZ4JGIBBHTIPK45TWZF75BUI/>
[2] <https://gitlab.com/libvirt/libvirt/-/blob/master/libvirt.spec.in?ref_type=heads#L1385>
_______________________________________________
Devel mailing list -- devel@lists.libvirt.org
To unsubscribe send an email to devel-leave@lists.libvirt.org

On a Wednesday in 2024, Pavel Hrdina wrote:
>On Wed, Feb 14, 2024 at 01:31:29PM +0100, Peter Krempa wrote:
>> On Tue, Feb 13, 2024 at 19:16:00 +0100, Jiri Denemark wrote:
>> > The %meson* macros pass --auto-features=enabled to enable all "auto"
>> > features, which means we have to explicitly disable them.
>>
>> This is not the first time we've hit this. I really think the only sane
>> option for --auto-features= for distributions is to use 'disabled' and
>> explicitly enable what they need.
>
>This is our own fault as Jano already pointed out here [1] we have the
>option '--auto-features=enabled' in our own spec file for mingw [2].
>

It is also set to enabled by the '%mingw' RPM macro on Fedora.

Personally, I think it's frendlier for maintainers to be bothered by these
"errors" rather than having the users miss new features.

Jano

>Pavel
>
>[1] <https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/message/RXOBFDH6IZ4JGIBBHTIPK45TWZF75BUI/>
>[2] <https://gitlab.com/libvirt/libvirt/-/blob/master/libvirt.spec.in?ref_type=heads#L1385>



>_______________________________________________
>Devel mailing list -- devel@lists.libvirt.org
>To unsubscribe send an email to devel-leave@lists.libvirt.org

_______________________________________________
Devel mailing list -- devel@lists.libvirt.org
To unsubscribe send an email to devel-leave@lists.libvirt.org