virt-host-validate: Improve failure message when no HW virt is found

[libvirt PATCH] virt-host-validate: Improve failure message when no HW virt is found

Martin Kletzander posted 1 patch 1 year, 11 months ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/3b4ccd68ace6329db9a4d4ce8be04aec6248a0fa.1653911461.git.mkletzan@redhat.com

tools/virt-host-validate-qemu.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

Expand all Fold all

[libvirt PATCH] virt-host-validate: Improve failure message when no HW virt is found

Posted by Martin Kletzander 1 year, 11 months ago

Make sure that more users understand that without HW virtualization you cannot
have KVM working.

Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=2086677
Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
---
 tools/virt-host-validate-qemu.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/tools/virt-host-validate-qemu.c b/tools/virt-host-validate-qemu.c
index 46ff1d249488..fcf9876ac916 100644
--- a/tools/virt-host-validate-qemu.c
+++ b/tools/virt-host-validate-qemu.c
@@ -71,7 +71,8 @@ int virHostValidateQEMU(void)
             virHostMsgPass();
         } else {
             virHostMsgFail(VIR_HOST_VALIDATE_FAIL,
-                           _("Only emulated CPUs are available, performance will be significantly limited"));
+                           _("Host not compatible with KVM, HW virtualization CPU features not found. "
+                             "Only emulated CPUs are available, performance will be significantly limited"));
             ret = -1;
         }
     }
-- 
2.35.1

Re: [libvirt PATCH] virt-host-validate: Improve failure message when no HW virt is found

Posted by Ján Tomko 1 year, 11 months ago

On a Monday in 2022, Martin Kletzander wrote:
>Make sure that more users understand that without HW virtualization you cannot
>have KVM working.
>
>Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=2086677
>Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
>---
> tools/virt-host-validate-qemu.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
>diff --git a/tools/virt-host-validate-qemu.c b/tools/virt-host-validate-qemu.c
>index 46ff1d249488..fcf9876ac916 100644
>--- a/tools/virt-host-validate-qemu.c
>+++ b/tools/virt-host-validate-qemu.c
>@@ -71,7 +71,8 @@ int virHostValidateQEMU(void)
>             virHostMsgPass();
>         } else {
>             virHostMsgFail(VIR_HOST_VALIDATE_FAIL,
>-                           _("Only emulated CPUs are available, performance will be significantly limited"));
>+                           _("Host not compatible with KVM, HW virtualization CPU features not found. "
>+                             "Only emulated CPUs are available, performance will be significantly limited"));

In both sentences, I think a semicolon would look better than a comma.

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano