[PATCH] qemu_capspriv: Drop needless declarations

Michal Privoznik posted 1 patch 1 year, 11 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/38f29ba5bfe3f78e22cc1830664c1af98096f1c6.1653916062.git.mprivozn@redhat.com
src/qemu/qemu_capabilities.c | 2 +-
src/qemu/qemu_capspriv.h     | 9 ---------
2 files changed, 1 insertion(+), 10 deletions(-)
[PATCH] qemu_capspriv: Drop needless declarations
Posted by Michal Privoznik 1 year, 11 months ago
There are two functions declared in qemu_capspriv.h:
1) virQEMUCapsInitHostCPUModel() which is not used anywhere but
   qemu_capabilities.c,

2) virQEMUCapsSetSEVCapabilities() which is my personal favorite
   but despite that it's never implemented nor called.

Drop them.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
---
 src/qemu/qemu_capabilities.c | 2 +-
 src/qemu/qemu_capspriv.h     | 9 ---------
 2 files changed, 1 insertion(+), 10 deletions(-)

diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c
index ce3e7d275a..d0c8217825 100644
--- a/src/qemu/qemu_capabilities.c
+++ b/src/qemu/qemu_capabilities.c
@@ -3725,7 +3725,7 @@ virQEMUCapsNewHostCPUModel(void)
 }
 
 
-void
+static void
 virQEMUCapsInitHostCPUModel(virQEMUCaps *qemuCaps,
                             virArch hostArch,
                             virDomainVirtType type)
diff --git a/src/qemu/qemu_capspriv.h b/src/qemu/qemu_capspriv.h
index 26bf2d3571..fe24d01342 100644
--- a/src/qemu/qemu_capspriv.h
+++ b/src/qemu/qemu_capspriv.h
@@ -56,11 +56,6 @@ void
 virQEMUCapsSetArch(virQEMUCaps *qemuCaps,
                    virArch arch);
 
-void
-virQEMUCapsInitHostCPUModel(virQEMUCaps *qemuCaps,
-                            virArch hostArch,
-                            virDomainVirtType type);
-
 void
 virQEMUCapsUpdateHostCPUModel(virQEMUCaps *qemuCaps,
                               virArch hostArch,
@@ -97,10 +92,6 @@ virQEMUCapsSetGICCapabilities(virQEMUCaps *qemuCaps,
                               virGICCapability *capabilities,
                               size_t ncapabilities);
 
-void
-virQEMUCapsSetSEVCapabilities(virQEMUCaps *qemuCaps,
-                              virSEVCapability *capabilities);
-
 int
 virQEMUCapsProbeCPUDefinitionsTest(virQEMUCaps *qemuCaps,
                                    qemuMonitor *mon);
-- 
2.35.1
Re: [PATCH] qemu_capspriv: Drop needless declarations
Posted by Boris Fiuczynski 1 year, 11 months ago
On 5/30/22 3:07 PM, Michal Privoznik wrote:
> here are two functions declared in qemu_capspriv.h:
> 1) virQEMUCapsInitHostCPUModel() which is not used anywhere but
>     qemu_capabilities.c,
> 
> 2) virQEMUCapsSetSEVCapabilities() which is my personal favorite
>     but despite that it's never implemented nor called.
> 
> Drop them.
> 
> Signed-off-by: Michal Privoznik<mprivozn@redhat.com>
> ---
>   src/qemu/qemu_capabilities.c | 2 +-
>   src/qemu/qemu_capspriv.h     | 9 ---------
>   2 files changed, 1 insertion(+), 10 deletions(-)

Reviewed-by: Boris Fiuczynski <fiuczy@linux.ibm.com>

-- 
Mit freundlichen Grüßen/Kind regards
    Boris Fiuczynski

IBM Deutschland Research & Development GmbH
Vorsitzender des Aufsichtsrats: Gregor Pillen
Geschäftsführung: David Faller
Sitz der Gesellschaft: Böblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294