[libvirt] [PATCH] tests: remove double space

Ján Tomko posted 1 patch 6 years ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/374777ee74e43c60dfccc13b8555a033311a3646.1523966561.git.jtomko@redhat.com
Test syntax-check passed
tests/qemuxml2argvtest.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[libvirt] [PATCH] tests: remove double space
Posted by Ján Tomko 6 years ago
Commit 70255fa5 introduced a double space before the newline-escaping
backslash and broke syntax check.

Signed-off-by: Ján Tomko <jtomko@redhat.com>
---
Pushed as a trivial build-breaker fix.

 tests/qemuxml2argvtest.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/qemuxml2argvtest.c b/tests/qemuxml2argvtest.c
index 43f07efc1..509fe776e 100644
--- a/tests/qemuxml2argvtest.c
+++ b/tests/qemuxml2argvtest.c
@@ -668,7 +668,7 @@ mymain(void)
                        testCompareXMLToArgv, &info) < 0) \
             ret = -1; \
         if (virTestRun("QEMU XML-2-startup-XML " name, \
-                       testCompareXMLToStartupXML, &info) < 0)  \
+                       testCompareXMLToStartupXML, &info) < 0) \
             ret = -1; \
         virObjectUnref(info.qemuCaps); \
         virObjectUnref(info.vm); \
-- 
2.16.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH] tests: remove double space
Posted by Martin Kletzander 6 years ago
On Tue, Apr 17, 2018 at 02:02:54PM +0200, Ján Tomko wrote:
>Commit 70255fa5 introduced a double space before the newline-escaping
>backslash and broke syntax check.
>
>Signed-off-by: Ján Tomko <jtomko@redhat.com>
>---
>Pushed as a trivial build-breaker fix.
>
> tests/qemuxml2argvtest.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>

Thanks for the fix, I confirmed *again* that I have `c-auto-align-backslashes`
set to `nil`, so this should not happen more than like last three or four times.

>diff --git a/tests/qemuxml2argvtest.c b/tests/qemuxml2argvtest.c
>index 43f07efc1..509fe776e 100644
>--- a/tests/qemuxml2argvtest.c
>+++ b/tests/qemuxml2argvtest.c
>@@ -668,7 +668,7 @@ mymain(void)
>                        testCompareXMLToArgv, &info) < 0) \
>             ret = -1; \
>         if (virTestRun("QEMU XML-2-startup-XML " name, \
>-                       testCompareXMLToStartupXML, &info) < 0)  \
>+                       testCompareXMLToStartupXML, &info) < 0) \
>             ret = -1; \
>         virObjectUnref(info.qemuCaps); \
>         virObjectUnref(info.vm); \
>-- 
>2.16.1
>
>--
>libvir-list mailing list
>libvir-list@redhat.com
>https://www.redhat.com/mailman/listinfo/libvir-list
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH] tests: remove double space
Posted by Peter Krempa 6 years ago
On Tue, Apr 17, 2018 at 14:38:31 +0200, Martin Kletzander wrote:
> On Tue, Apr 17, 2018 at 02:02:54PM +0200, Ján Tomko wrote:
> > Commit 70255fa5 introduced a double space before the newline-escaping
> > backslash and broke syntax check.
> > 
> > Signed-off-by: Ján Tomko <jtomko@redhat.com>
> > ---
> > Pushed as a trivial build-breaker fix.
> > 
> > tests/qemuxml2argvtest.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> 
> Thanks for the fix, I confirmed *again* that I have `c-auto-align-backslashes`
> set to `nil`, so this should not happen more than like last three or four times.

I'd suggest actually running syntax-check prior to pushing ...
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list