qemuDomainRemoveDevice: add qemuDomainRemoveWatchdog

[libvirt] [PATCH] qemuDomainRemoveDevice: add qemuDomainRemoveWatchdog

Ján Tomko posted 1 patch 6 years ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/36920f01f5e60fb093d4f795540460127b8e4926.1522488023.git.jtomko@redhat.com

Test syntax-check passed

src/qemu/qemu_hotplug.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)

Expand all Fold all

[libvirt] [PATCH] qemuDomainRemoveDevice: add qemuDomainRemoveWatchdog

Posted by Ján Tomko 6 years ago

qemuDomainDetachWatchdog uses the infrastructure for waiting
for the DEVICE_DELETED event, but the asynchronous delete
was not implemented.

Signed-off-by: Ján Tomko <jtomko@redhat.com>
---
 src/qemu/qemu_hotplug.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c
index 49af4d4ff..e840c8010 100644
--- a/src/qemu/qemu_hotplug.c
+++ b/src/qemu/qemu_hotplug.c
@@ -4493,12 +4493,15 @@ qemuDomainRemoveDevice(virQEMUDriverPtr driver,
         ret = qemuDomainRemoveRedirdevDevice(driver, vm, dev->data.redirdev);
         break;
 
+    case VIR_DOMAIN_DEVICE_WATCHDOG:
+        ret = qemuDomainRemoveWatchdog(driver, vm, dev->data.watchdog);
+        break;
+
     case VIR_DOMAIN_DEVICE_NONE:
     case VIR_DOMAIN_DEVICE_LEASE:
     case VIR_DOMAIN_DEVICE_FS:
     case VIR_DOMAIN_DEVICE_SOUND:
     case VIR_DOMAIN_DEVICE_VIDEO:
-    case VIR_DOMAIN_DEVICE_WATCHDOG:
     case VIR_DOMAIN_DEVICE_GRAPHICS:
     case VIR_DOMAIN_DEVICE_HUB:
     case VIR_DOMAIN_DEVICE_SMARTCARD:
-- 
2.13.6

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] qemuDomainRemoveDevice: add qemuDomainRemoveWatchdog

Posted by Michal Privoznik 6 years ago

On 03/31/2018 11:20 AM, Ján Tomko wrote:
> qemuDomainDetachWatchdog uses the infrastructure for waiting
> for the DEVICE_DELETED event, but the asynchronous delete
> was not implemented.
> 
> Signed-off-by: Ján Tomko <jtomko@redhat.com>
> ---
>  src/qemu/qemu_hotplug.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 

ACK

Michal

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list