qemu_capabilities: Honour caps values formatting

[libvirt] [PATCH] qemu_capabilities: Honour caps values formatting

Michal Privoznik posted 1 patch 6 years, 8 months ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/313274a7568a1d6c5975acb1683a349fbba6df28.1500712774.git.mprivozn@redhat.com

src/qemu/qemu_capabilities.c | 2 ++
src/qemu/qemu_capabilities.h | 2 ++
2 files changed, 4 insertions(+)

Expand all Fold all

[libvirt] [PATCH] qemu_capabilities: Honour caps values formatting

Posted by Michal Privoznik 6 years, 8 months ago

So the way we format this huge virQEMUCaps enum is we group the
values in groups of five. And then at the beginning of each group
we have a small comment that says what's the number of the first
item in the group. Well, the last commit of 11b2ebf3e152 does not
follow this formatting.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
---
 src/qemu/qemu_capabilities.c | 2 ++
 src/qemu/qemu_capabilities.h | 2 ++
 2 files changed, 4 insertions(+)

diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c
index c3f49a975..5fb6fd4ba 100644
--- a/src/qemu/qemu_capabilities.c
+++ b/src/qemu/qemu_capabilities.c
@@ -431,6 +431,8 @@ VIR_ENUM_IMPL(virQEMUCaps, QEMU_CAPS_LAST,
               "virtio.ats",
               "loadparm",
               "spapr-pci-host-bridge",
+
+              /* 265 */
               "spapr-pci-host-bridge.numa_node",
     );
 
diff --git a/src/qemu/qemu_capabilities.h b/src/qemu/qemu_capabilities.h
index 19f59a6d4..746745e39 100644
--- a/src/qemu/qemu_capabilities.h
+++ b/src/qemu/qemu_capabilities.h
@@ -417,6 +417,8 @@ typedef enum {
     QEMU_CAPS_VIRTIO_PCI_ATS, /* virtio-*-pci.ats */
     QEMU_CAPS_LOADPARM, /* -machine loadparm */
     QEMU_CAPS_DEVICE_SPAPR_PCI_HOST_BRIDGE, /* -device spapr-pci-host-bridge */
+
+    /* 265 */
     QEMU_CAPS_SPAPR_PCI_HOST_BRIDGE_NUMA_NODE, /* spapr-pci-host-bridge.numa_node= */
 
     QEMU_CAPS_LAST /* this must always be the last item */
-- 
2.13.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] qemu_capabilities: Honour caps values formatting

Posted by Andrea Bolognani 6 years, 8 months ago

On Sat, 2017-07-22 at 10:39 +0200, Michal Privoznik wrote:
> So the way we format this huge virQEMUCaps enum is we group the
> values in groups of five. And then at the beginning of each group
> we have a small comment that says what's the number of the first
> item in the group. Well, the last commit of 11b2ebf3e152 does not
> follow this formatting.

Yup, I overlooked that during review. Thanks for cleaning
up after us :)

-- 
Andrea Bolognani / Red Hat / Virtualization

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list