From nobody Sun May 19 01:15:15 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1643622154; cv=none; d=zohomail.com; s=zohoarc; b=jZFzDc24Gx8AiWSDykuexLSBOOGDwKFpV5KpTAyekyQGx0b/hLQKyyyItH84W2uJ98bybaglfTvrJmMWdkI07ppwBBihmi3xv2baXWkFBZIXGGTi0Cy9bUCz5VIztg9CZY7Thgao20y0zaIIviSzlmGzYdNpP9I34IOMg1oq/kk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1643622154; h=Content-Type:Content-Transfer-Encoding:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=oU1TC9PC49bXSh/7+9RfpUmCcBxAOZ1TzXuYSbGao2Y=; b=MxDqWqUsK+QfXILy+kXwUJjZQWcJv8V1B4cE7ma3pfmAj4oGfdX8dkUIIWqswtESpYdHNGjjypjG6SwG+oZ/E64BT98X9PRtaEn7VoNBKq1jqrfvp3VlYXv7vhNdSyG07Gx3MAmzANKDIT1gDkJJw1bSWXJYGXSL2msj//4q2z0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 164362215440116.08111945923133; Mon, 31 Jan 2022 01:42:34 -0800 (PST) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-218-ik7rbBdgP12GQxBy-TCGIA-1; Mon, 31 Jan 2022 04:42:32 -0500 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 0686846873; Mon, 31 Jan 2022 09:42:27 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 98C3662D71; Mon, 31 Jan 2022 09:42:25 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 71F9C1809CB8; Mon, 31 Jan 2022 09:42:24 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 20V9gM14014006 for ; Mon, 31 Jan 2022 04:42:22 -0500 Received: by smtp.corp.redhat.com (Postfix) id E7139108649F; Mon, 31 Jan 2022 09:42:22 +0000 (UTC) Received: from localhost.localdomain (unknown [10.40.193.157]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6952B108BD2D for ; Mon, 31 Jan 2022 09:42:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1643622153; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=oU1TC9PC49bXSh/7+9RfpUmCcBxAOZ1TzXuYSbGao2Y=; b=N3idmf7EfH7WnR9I1ZnmpXYRplOwY+9ModN9GK3IO3p+mCSevrFzQreCs//bBYHDdDfBGS EVXweB7EqU7xhDHyi1UIoRqJuqa7xvCTADkEQIii65IUh/lI8rUvTZ9PNIhSm/whkIbmM1 Pou91amMfTfjhlGJMxHbxEH19iAH+9k= X-MC-Unique: ik7rbBdgP12GQxBy-TCGIA-1 From: Michal Privoznik To: libvir-list@redhat.com Subject: [PATCH] lib: Drop '&*' from '&*variable' Date: Mon, 31 Jan 2022 10:42:09 +0100 Message-Id: <2b6489976e08669869b55970725f955811a9e9c7.1643622129.git.mprivozn@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1643622155345100001 Content-Type: text/plain; charset="utf-8" Apparently, some of '&*variable' slipped in. Drop '&*' and access the variable directly. Signed-off-by: Michal Privoznik Reviewed-by: Ani Sinha --- src/qemu/qemu_domain.c | 2 +- src/qemu/qemu_driver.c | 2 +- src/qemu/qemu_migration_cookie.c | 2 +- src/rpc/virnetclientstream.c | 8 ++++---- 4 files changed, 7 insertions(+), 7 deletions(-) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index aa8f6b8d05..6b915d7535 100644 --- a/src/qemu/qemu_domain.c +++ b/src/qemu/qemu_domain.c @@ -1765,7 +1765,7 @@ qemuStorageSourcePrivateDataAssignSecinfo(qemuDomainS= ecretInfo **secinfo, *secinfo =3D g_new0(qemuDomainSecretInfo, 1); } =20 - (*secinfo)->alias =3D g_steal_pointer(&*alias); + (*secinfo)->alias =3D g_steal_pointer(alias); =20 return 0; } diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 1141efef4b..370d223198 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -12221,7 +12221,7 @@ qemuConnectStealCPUModelFromInfo(virCPUDef *dst, =20 virCPUDefFreeModel(dst); =20 - info =3D g_steal_pointer(&*src); + info =3D g_steal_pointer(src); dst->model =3D g_steal_pointer(&info->name); =20 for (i =3D 0; i < info->nprops; i++) { diff --git a/src/qemu/qemu_migration_cookie.c b/src/qemu/qemu_migration_coo= kie.c index bffab7c13d..ba05a5a07f 100644 --- a/src/qemu/qemu_migration_cookie.c +++ b/src/qemu/qemu_migration_cookie.c @@ -423,7 +423,7 @@ qemuMigrationCookieAddPersistent(qemuMigrationCookie *m= ig, if (!def || !*def) return 0; =20 - mig->persistent =3D g_steal_pointer(&*def); + mig->persistent =3D g_steal_pointer(def); mig->flags |=3D QEMU_MIGRATION_COOKIE_PERSISTENT; mig->flagsMandatory |=3D QEMU_MIGRATION_COOKIE_PERSISTENT; return 0; diff --git a/src/rpc/virnetclientstream.c b/src/rpc/virnetclientstream.c index eb4dc6854d..e8e8ca2af2 100644 --- a/src/rpc/virnetclientstream.c +++ b/src/rpc/virnetclientstream.c @@ -286,18 +286,18 @@ int virNetClientStreamSetError(virNetClientStream *st, st->err.code =3D err.code; } if (err.message) { - st->err.message =3D g_steal_pointer(&*err.message); + st->err.message =3D g_steal_pointer(err.message); } st->err.domain =3D err.domain; st->err.level =3D err.level; if (err.str1) { - st->err.str1 =3D g_steal_pointer(&*err.str1); + st->err.str1 =3D g_steal_pointer(err.str1); } if (err.str2) { - st->err.str2 =3D g_steal_pointer(&*err.str2); + st->err.str2 =3D g_steal_pointer(err.str2); } if (err.str3) { - st->err.str3 =3D g_steal_pointer(&*err.str3); + st->err.str3 =3D g_steal_pointer(err.str3); } st->err.int1 =3D err.int1; st->err.int2 =3D err.int2; --=20 2.34.1