From nobody Fri May 17 09:01:54 2024 Delivered-To: importer@patchew.org Received-SPF: none (zohomail.com: 8.43.85.245 is neither permitted nor denied by domain of lists.libvirt.org) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; spf=none (zohomail.com: 8.43.85.245 is neither permitted nor denied by domain of lists.libvirt.org) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1704286778775926.8571385701654; Wed, 3 Jan 2024 04:59:38 -0800 (PST) Received: by lists.libvirt.org (Postfix, from userid 996) id 74EE8173A; Wed, 3 Jan 2024 07:59:37 -0500 (EST) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id EE7E6171C; Wed, 3 Jan 2024 07:58:29 -0500 (EST) Received: by lists.libvirt.org (Postfix, from userid 996) id 8EA5E1711; Wed, 3 Jan 2024 07:58:26 -0500 (EST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 09A531708 for ; Wed, 3 Jan 2024 07:58:25 -0500 (EST) Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-350-fb29yNZSNmixHu8_CS-e-Q-1; Wed, 03 Jan 2024 07:58:19 -0500 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id C398B3830089 for ; Wed, 3 Jan 2024 12:58:18 +0000 (UTC) Received: from localhost.localdomain (unknown [10.45.224.188]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6DDFF51D5 for ; Wed, 3 Jan 2024 12:58:18 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.4 X-MC-Unique: fb29yNZSNmixHu8_CS-e-Q-1 From: Michal Privoznik To: devel@lists.libvirt.org Subject: [PATCH] conf: Restore setting default bus for input devices Date: Wed, 3 Jan 2024 13:58:13 +0100 Message-ID: <2698f2cd2b9a2e7966b0ad9ae27501a7f5d13d58.1704286693.git.mprivozn@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.5 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Message-ID-Hash: LNNK3ZTC6E3SUTFWOEZ6HK7RJDIVQ3GI X-Message-ID-Hash: LNNK3ZTC6E3SUTFWOEZ6HK7RJDIVQ3GI X-MailFrom: mprivozn@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="utf-8"; x-default="true" Content-Transfer-Encoding: quoted-printable X-ZM-MESSAGEID: 1704286780614100001 Prior to v9.3.0-rc1~30 we used to set default bus for devices, during XML parsing. In the commit this code was moved to a post parse callback. But somehow the line that sets the bus in one specific case disappeared. Bring it back. Resolves: https://gitlab.com/libvirt/libvirt/-/issues/577 Fixes: c4bc4d3b82fbe22e03c986ca896090f481df5c10 Signed-off-by: Michal Privoznik --- src/conf/domain_postparse.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/conf/domain_postparse.c b/src/conf/domain_postparse.c index e79913b73f..ed9411f5e6 100644 --- a/src/conf/domain_postparse.c +++ b/src/conf/domain_postparse.c @@ -657,6 +657,7 @@ virDomainInputDefPostParse(virDomainInputDef *input, if ((input->type =3D=3D VIR_DOMAIN_INPUT_TYPE_MOUSE || input->type =3D=3D VIR_DOMAIN_INPUT_TYPE_KBD) && (ARCH_IS_X86(def->os.arch) || def->os.arch =3D=3D VIR_ARCH= _NONE)) { + input->bus =3D VIR_DOMAIN_INPUT_BUS_PS2; } else if (ARCH_IS_S390(def->os.arch) || input->type =3D=3D VIR_DOMAIN_INPUT_TYPE_PASSTHROUG= H) { input->bus =3D VIR_DOMAIN_INPUT_BUS_VIRTIO; --=20 2.41.0 _______________________________________________ Devel mailing list -- devel@lists.libvirt.org To unsubscribe send an email to devel-leave@lists.libvirt.org