From nobody Sat May 11 22:00:46 2024 Delivered-To: importer@patchew.org Received-SPF: none (zohomail.com: 8.43.85.245 is neither permitted nor denied by domain of lists.libvirt.org) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; spf=none (zohomail.com: 8.43.85.245 is neither permitted nor denied by domain of lists.libvirt.org) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1708109200181350.2123169206228; Fri, 16 Feb 2024 10:46:40 -0800 (PST) Received: by lists.libvirt.org (Postfix, from userid 996) id E12811BE3; Fri, 16 Feb 2024 13:46:38 -0500 (EST) Received: from lists.libvirt.org.85.43.8.in-addr.arpa (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 3963B1C57; Fri, 16 Feb 2024 13:45:23 -0500 (EST) Received: by lists.libvirt.org (Postfix, from userid 996) id B074F1C5E; Fri, 16 Feb 2024 13:45:16 -0500 (EST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 8F87A1C57 for ; Fri, 16 Feb 2024 13:45:15 -0500 (EST) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-18-dNHf10AOMBWmGJ2ralMalg-1; Fri, 16 Feb 2024 13:45:12 -0500 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id DCCCA84C65F for ; Fri, 16 Feb 2024 18:45:11 +0000 (UTC) Received: from vhost3.router.laine.org (unknown [10.22.10.106]) by smtp.corp.redhat.com (Postfix) with ESMTP id C67D52166AE5 for ; Fri, 16 Feb 2024 18:45:11 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.4 X-MC-Unique: dNHf10AOMBWmGJ2ralMalg-1 From: Laine Stump To: devel@lists.libvirt.org Subject: [PATCH] Set stubDriverName from hostdev driver model attribute during pci device setup Date: Fri, 16 Feb 2024 13:45:11 -0500 Message-ID: <20240216184511.374412-1-laine@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.6 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Message-ID-Hash: CTGL7VL4TPIKK7QPTJYRGOAQGKOTPIBC X-Message-ID-Hash: CTGL7VL4TPIKK7QPTJYRGOAQGKOTPIBC X-MailFrom: laine@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="utf-8"; x-default="true" Content-Transfer-Encoding: quoted-printable X-ZM-MESSAGEID: 1708109202315100001 commit v9.10.0-129-g8b93d78c83 (first appearing in libvirt-10.0.0) was supposed to allow forcing a PCI hostdev to be bound to a particular driver by adding to the XML for the device. Unfortunately, a single line was missed during the final changes to the patch prior to pushing, and the result was that the driver model could be set to *anything* and it would be accepted but just ignored. This patch adds the missing line, which will set the stubDriverName field of the virPCIDevice object from the hostdev object as the virPCIDevice is being created. This ends up being used by virPCIDeviceBindToStub() as the driver that it binds the device to. Fixes: 8b93d78c8325f1fba5db98848350f3db43f5e7d5 Signed-off-by: Laine Stump Reviewed-by: Michal Privoznik --- src/hypervisor/virhostdev.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/hypervisor/virhostdev.c b/src/hypervisor/virhostdev.c index 40f8a4bc2c..53327f4f4d 100644 --- a/src/hypervisor/virhostdev.c +++ b/src/hypervisor/virhostdev.c @@ -242,6 +242,8 @@ virHostdevGetPCIHostDevice(const virDomainHostdevDef *h= ostdev, return -1; =20 virPCIDeviceSetManaged(actual, hostdev->managed); + virPCIDeviceSetStubDriverName(actual, pcisrc->driver.model); + =20 if (pcisrc->driver.name =3D=3D VIR_DEVICE_HOSTDEV_PCI_DRIVER_NAME_VFIO= ) { virPCIDeviceSetStubDriverType(actual, VIR_PCI_STUB_DRIVER_VFIO); --=20 2.43.0 _______________________________________________ Devel mailing list -- devel@lists.libvirt.org To unsubscribe send an email to devel-leave@lists.libvirt.org