On Fri, Feb 16, 2024 at 03:47:59PM +0100, Andrea Bolognani wrote:
>One might see patch 3/3 and think hey, it would actually be nice if
>developers were getting warned that some checks haven't been executed
>because a tool is missing! And I completely agree.
>
>However, since meson needs to see an exit code of 77 to mark a test
>as skipped, and make return codes are in the range 0-2, making that
>happen would require taking the cppi/flake8/black checks out of the
>current scaffolding and wrap them in some other way. I have no
>intention to shave that specific yak today O:-)
>
I have an idea how to do that somewhat elegantly, I'll post it soon.
This is fine the way it is.
Reviewed-by: Martin Kletzander <mkletzan@redhat.com>
>Andrea Bolognani (3):
> all: Don't use 'grep -q'
> syntax-check: Sync with gnulib
> syntax-check: Drop 'syntax-check' target
>
> build-aux/syntax-check.mk | 33 ++++++++-------------------------
> libvirt.spec.in | 2 +-
> tests/virsh-uriprecedence | 2 +-
> tests/virt-aa-helper-test | 2 +-
> 4 files changed, 11 insertions(+), 28 deletions(-)
>
>--
>2.43.0
>_______________________________________________
>Devel mailing list -- devel@lists.libvirt.org
>To unsubscribe send an email to devel-leave@lists.libvirt.org
_______________________________________________
Devel mailing list -- devel@lists.libvirt.org
To unsubscribe send an email to devel-leave@lists.libvirt.org