[PATCH v2 00/17] qemu: Improve handling of architecture-specific defaults

Andrea Bolognani posted 17 patches 2 months, 1 week ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20240214171124.508000-1-abologna@redhat.com
src/qemu/qemu_command.c                       | 145 +--------
src/qemu/qemu_domain.c                        | 300 +++++++++++++-----
src/qemu/qemu_domain.h                        |   6 +-
src/qemu/qemu_hotplug.c                       |  21 +-
src/qemu/qemu_validate.c                      |  69 +++-
.../qemuhotplug-base-ccw-live+ccw-virtio.xml  |   5 +-
...with-2-ccw-virtio+ccw-virtio-1-reverse.xml |   5 +-
...otplug-base-ccw-live-with-2-ccw-virtio.xml |   5 +-
...-with-ccw-virtio+ccw-virtio-2-explicit.xml |   5 +-
...-ccw-live-with-ccw-virtio+ccw-virtio-2.xml |   5 +-
...uhotplug-base-ccw-live-with-ccw-virtio.xml |   5 +-
.../qemuhotplug-base-ccw-live.xml             |   5 +-
.../arm-vexpressa9-basic.aarch64-latest.args  |   1 -
.../arm-vexpressa9-nodevs.aarch64-latest.args |   1 -
.../arm-vexpressa9-virtio.aarch64-latest.args |   1 -
...scsi-default-unavailable.x86_64-latest.err |   1 +
.../controller-scsi-default-unavailable.xml   |  15 +
.../disk-arm-virtio-sd.aarch64-latest.args    |   1 -
...ault-models.riscv64-latest.abi-update.args |  12 +-
...fault-models.riscv64-latest.abi-update.xml |  25 +-
...64-virt-default-models.riscv64-latest.args |  12 +-
...v64-virt-default-models.riscv64-latest.xml |  25 +-
.../s390-usb-address.s390x-latest.xml         |   6 +-
.../sparc-minimal.sparc-latest.args           |   1 -
...ault-unavailable-i440fx.x86_64-latest.args |  33 --
...fault-unavailable-i440fx.x86_64-latest.err |   1 +
...fault-unavailable-i440fx.x86_64-latest.xml |  31 --
...-default-unavailable-q35.x86_64-latest.err |   2 +-
...-default-unavailable-q35.x86_64-latest.xml |  33 --
...ntroller-implicit-isapc.x86_64-latest.args |   1 -
...ler-nec-xhci-unavailable.x86_64-latest.xml |  33 --
.../usb-legacy-device.x86_64-latest.err       |   1 +
tests/qemuxmlconfdata/usb-legacy-device.xml   |  15 +
.../usb-legacy-multiple.x86_64-latest.err     |   1 +
tests/qemuxmlconfdata/usb-legacy-multiple.xml |  15 +
tests/qemuxmlconftest.c                       |  28 +-
36 files changed, 418 insertions(+), 453 deletions(-)
create mode 100644 tests/qemuxmlconfdata/controller-scsi-default-unavailable.x86_64-latest.err
create mode 100644 tests/qemuxmlconfdata/controller-scsi-default-unavailable.xml
delete mode 100644 tests/qemuxmlconfdata/usb-controller-default-unavailable-i440fx.x86_64-latest.args
create mode 100644 tests/qemuxmlconfdata/usb-controller-default-unavailable-i440fx.x86_64-latest.err
delete mode 100644 tests/qemuxmlconfdata/usb-controller-default-unavailable-i440fx.x86_64-latest.xml
delete mode 100644 tests/qemuxmlconfdata/usb-controller-default-unavailable-q35.x86_64-latest.xml
delete mode 100644 tests/qemuxmlconfdata/usb-controller-nec-xhci-unavailable.x86_64-latest.xml
create mode 100644 tests/qemuxmlconfdata/usb-legacy-device.x86_64-latest.err
create mode 100644 tests/qemuxmlconfdata/usb-legacy-device.xml
create mode 100644 tests/qemuxmlconfdata/usb-legacy-multiple.x86_64-latest.err
create mode 100644 tests/qemuxmlconfdata/usb-legacy-multiple.xml
[PATCH v2 00/17] qemu: Improve handling of architecture-specific defaults
Posted by Andrea Bolognani 2 months, 1 week ago
Changes from [v1]:

  * several patches have been pushed;

  * of the remaining changes, only the ones related to SCSI and USB
    controllers have been retained. I still intend to pursue the
    rest, but those two are where the real nasty stuff happens, so
    I'm focusing on them only for now;

  * improve the handling of USB controllers on s390x;

  * make all the code dealing with the legacy USB controller obsolete
    and get rid of it;

  * use out arguments to return models, making the new helpers fall
    in line with the usual libvirt API conventions.

[v1] https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/thread/G53MRO2IEJOS3M53OKON2S5RM2MPH55K/

Andrea Bolognani (17):
  tests: Add controller-scsi-default-unavailable
  qemu: Rename qemuDomainDefaultSCSIControllerModel()
  qemu: Move error reporting out of
    qemuDomainDefaultSCSIControllerModel()
  qemu: Improve qemuDomainDefaultSCSIControllerModel()
  qemu: Clean up qemuDomainDefaultSCSIControllerModel()
  qemu: Use virtio-scsi by default on RISC-V
  tests: Add usb-legacy-multiple
  tests: Add usb-legacy-device
  qemu: Always default to no USB controller on s390x
  qemu: Only use legacy USB controller if actually needed
  qemu: Validate USB controllers earlier
  qemu: Improve error message for USB controller validation
  qemu: Drop all code dealing with the legacy USB controller
  qemu: Add qemuDomainDefaultUSBControllerModel()
  qemu: Extend qemuDomainDefaultUSBControllerModel()
  qemu: Clean up qemuDomainDefaultUSBControllerModel()
  qemu: Use qemu-xhci by default on RISC-V

 src/qemu/qemu_command.c                       | 145 +--------
 src/qemu/qemu_domain.c                        | 300 +++++++++++++-----
 src/qemu/qemu_domain.h                        |   6 +-
 src/qemu/qemu_hotplug.c                       |  21 +-
 src/qemu/qemu_validate.c                      |  69 +++-
 .../qemuhotplug-base-ccw-live+ccw-virtio.xml  |   5 +-
 ...with-2-ccw-virtio+ccw-virtio-1-reverse.xml |   5 +-
 ...otplug-base-ccw-live-with-2-ccw-virtio.xml |   5 +-
 ...-with-ccw-virtio+ccw-virtio-2-explicit.xml |   5 +-
 ...-ccw-live-with-ccw-virtio+ccw-virtio-2.xml |   5 +-
 ...uhotplug-base-ccw-live-with-ccw-virtio.xml |   5 +-
 .../qemuhotplug-base-ccw-live.xml             |   5 +-
 .../arm-vexpressa9-basic.aarch64-latest.args  |   1 -
 .../arm-vexpressa9-nodevs.aarch64-latest.args |   1 -
 .../arm-vexpressa9-virtio.aarch64-latest.args |   1 -
 ...scsi-default-unavailable.x86_64-latest.err |   1 +
 .../controller-scsi-default-unavailable.xml   |  15 +
 .../disk-arm-virtio-sd.aarch64-latest.args    |   1 -
 ...ault-models.riscv64-latest.abi-update.args |  12 +-
 ...fault-models.riscv64-latest.abi-update.xml |  25 +-
 ...64-virt-default-models.riscv64-latest.args |  12 +-
 ...v64-virt-default-models.riscv64-latest.xml |  25 +-
 .../s390-usb-address.s390x-latest.xml         |   6 +-
 .../sparc-minimal.sparc-latest.args           |   1 -
 ...ault-unavailable-i440fx.x86_64-latest.args |  33 --
 ...fault-unavailable-i440fx.x86_64-latest.err |   1 +
 ...fault-unavailable-i440fx.x86_64-latest.xml |  31 --
 ...-default-unavailable-q35.x86_64-latest.err |   2 +-
 ...-default-unavailable-q35.x86_64-latest.xml |  33 --
 ...ntroller-implicit-isapc.x86_64-latest.args |   1 -
 ...ler-nec-xhci-unavailable.x86_64-latest.xml |  33 --
 .../usb-legacy-device.x86_64-latest.err       |   1 +
 tests/qemuxmlconfdata/usb-legacy-device.xml   |  15 +
 .../usb-legacy-multiple.x86_64-latest.err     |   1 +
 tests/qemuxmlconfdata/usb-legacy-multiple.xml |  15 +
 tests/qemuxmlconftest.c                       |  28 +-
 36 files changed, 418 insertions(+), 453 deletions(-)
 create mode 100644 tests/qemuxmlconfdata/controller-scsi-default-unavailable.x86_64-latest.err
 create mode 100644 tests/qemuxmlconfdata/controller-scsi-default-unavailable.xml
 delete mode 100644 tests/qemuxmlconfdata/usb-controller-default-unavailable-i440fx.x86_64-latest.args
 create mode 100644 tests/qemuxmlconfdata/usb-controller-default-unavailable-i440fx.x86_64-latest.err
 delete mode 100644 tests/qemuxmlconfdata/usb-controller-default-unavailable-i440fx.x86_64-latest.xml
 delete mode 100644 tests/qemuxmlconfdata/usb-controller-default-unavailable-q35.x86_64-latest.xml
 delete mode 100644 tests/qemuxmlconfdata/usb-controller-nec-xhci-unavailable.x86_64-latest.xml
 create mode 100644 tests/qemuxmlconfdata/usb-legacy-device.x86_64-latest.err
 create mode 100644 tests/qemuxmlconfdata/usb-legacy-device.xml
 create mode 100644 tests/qemuxmlconfdata/usb-legacy-multiple.x86_64-latest.err
 create mode 100644 tests/qemuxmlconfdata/usb-legacy-multiple.xml

-- 
2.43.0
_______________________________________________
Devel mailing list -- devel@lists.libvirt.org
To unsubscribe send an email to devel-leave@lists.libvirt.org