[PATCH v4 00/19] Unreacheble code cleanup

Dmitry Frolov posted 19 patches 3 months, 2 weeks ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20240110142134.915450-1-frolov@swemel.ru
src/admin/admin_remote.c        |  3 +--
src/conf/capabilities.c         |  8 ++----
src/conf/capabilities.h         |  4 +--
src/conf/domain_conf.c          | 28 +++++++--------------
src/conf/domain_conf.h          |  8 +++---
src/libxl/libxl_capabilities.c  | 44 ++++++++++++---------------------
src/libxl/libxl_capabilities.h  |  2 +-
src/libxl/libxl_conf.c          |  7 ++----
src/libxl/libxl_domain.c        |  6 ++---
src/libxl/libxl_driver.c        | 11 +++------
src/libxl/xen_common.c          | 26 ++++++++-----------
src/libxl/xen_common.h          |  2 +-
src/libxl/xen_xl.c              | 14 ++++-------
src/locking/lock_driver_lockd.c |  3 +--
src/logging/log_manager.c       |  3 +--
src/lxc/lxc_driver.c            |  6 ++---
src/lxc/lxc_monitor.c           |  5 ++--
src/qemu/qemu_domain.c          | 31 +++++++++--------------
src/qemu/qemu_driver.c          |  6 ++---
src/qemu/qemu_process.c         |  3 +--
src/remote/remote_driver.c      |  7 +++---
src/rpc/virnetclient.c          |  3 +--
src/rpc/virnetclient.h          |  2 +-
src/test/test_driver.c          |  6 ++---
src/vbox/vbox_common.c          | 13 +++-------
src/vmx/vmx.c                   |  3 +--
src/vz/vz_driver.c              | 23 +++++++----------
src/vz/vz_sdk.c                 | 14 +++++------
tests/domaincapstest.c          |  3 +--
29 files changed, 107 insertions(+), 187 deletions(-)
[PATCH v4 00/19] Unreacheble code cleanup
Posted by Dmitry Frolov 3 months, 2 weeks ago
A lot of unreacheble code was caused by int functions, which return nothing
except zero. Unreacheble code was removed. Corresponding functions type was 
changed to void.
---
v2: Changing functions return type to void
v3: fixed errors in v2
v4: rebased, more functions changed to void

Dmitry Frolov (19):
  libxl: change type to void libxlPrepareChannel()
  conf: change type to void virDomainDefMaybeAddInput()
  libxl: change type to void xenDomainDefAddImplicitInputDevice()
  qemu: change type to void qemuDomainDefAddImplicitInputDevice()
  vz: change type to void vzDomainDefAddDefaultInputDevices()
  conf: change type to void virDomainHostdevInsert()
  conf: change type to void virDomainNetInsert()
  conf: change type to void virCapabilitiesAddHostFeature()
  conf: change type to void virCapabilitiesSetNetPrefix()
  libxl: change type to void libxlMakeDomainOSCaps()
  libxl: change type to void libxlMakeDomainDeviceDiskCaps()
  libxl: change type to void libxlMakeDomainDeviceGraphicsCaps()
  libxl: change type to void libxlMakeDomainDeviceVideoCaps()
  libxl: change type to void virDomainGraphicsListenAppendAddress()
  libxl: change type to void xenParseXLNamespaceData()
  rpc: change type to void virNetClientAddProgram()
  vbox: change type to void vboxDumpDisplay()
  libxl: change type to void libxlMakeDomainDeviceHostdevCaps()
  libxl: change type to void libxlMakeDomainCapabilities()

 src/admin/admin_remote.c        |  3 +--
 src/conf/capabilities.c         |  8 ++----
 src/conf/capabilities.h         |  4 +--
 src/conf/domain_conf.c          | 28 +++++++--------------
 src/conf/domain_conf.h          |  8 +++---
 src/libxl/libxl_capabilities.c  | 44 ++++++++++++---------------------
 src/libxl/libxl_capabilities.h  |  2 +-
 src/libxl/libxl_conf.c          |  7 ++----
 src/libxl/libxl_domain.c        |  6 ++---
 src/libxl/libxl_driver.c        | 11 +++------
 src/libxl/xen_common.c          | 26 ++++++++-----------
 src/libxl/xen_common.h          |  2 +-
 src/libxl/xen_xl.c              | 14 ++++-------
 src/locking/lock_driver_lockd.c |  3 +--
 src/logging/log_manager.c       |  3 +--
 src/lxc/lxc_driver.c            |  6 ++---
 src/lxc/lxc_monitor.c           |  5 ++--
 src/qemu/qemu_domain.c          | 31 +++++++++--------------
 src/qemu/qemu_driver.c          |  6 ++---
 src/qemu/qemu_process.c         |  3 +--
 src/remote/remote_driver.c      |  7 +++---
 src/rpc/virnetclient.c          |  3 +--
 src/rpc/virnetclient.h          |  2 +-
 src/test/test_driver.c          |  6 ++---
 src/vbox/vbox_common.c          | 13 +++-------
 src/vmx/vmx.c                   |  3 +--
 src/vz/vz_driver.c              | 23 +++++++----------
 src/vz/vz_sdk.c                 | 14 +++++------
 tests/domaincapstest.c          |  3 +--
 29 files changed, 107 insertions(+), 187 deletions(-)

-- 
2.34.1
_______________________________________________
Devel mailing list -- devel@lists.libvirt.org
To unsubscribe send an email to devel-leave@lists.libvirt.org