From nobody Tue May 21 12:24:31 2024 Delivered-To: importer@patchew.org Received-SPF: none (zohomail.com: 8.43.85.245 is neither permitted nor denied by domain of lists.libvirt.org) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; spf=none (zohomail.com: 8.43.85.245 is neither permitted nor denied by domain of lists.libvirt.org) smtp.mailfrom=devel-bounces@lists.libvirt.org; arc=fail (BodyHash is different from the expected one); dmarc=fail(p=quarantine dis=quarantine) header.from=suse.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 170200066381725.75445715349349; Thu, 7 Dec 2023 17:57:43 -0800 (PST) Received: by lists.libvirt.org (Postfix, from userid 996) id 5DBA41880; Thu, 7 Dec 2023 20:57:42 -0500 (EST) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id D9D42186D; Thu, 7 Dec 2023 20:56:39 -0500 (EST) Received: by lists.libvirt.org (Postfix, from userid 996) id 32F7B186C; Thu, 7 Dec 2023 20:56:29 -0500 (EST) Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2050.outbound.protection.outlook.com [40.107.22.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 488E8185F for ; Thu, 7 Dec 2023 20:56:27 -0500 (EST) Received: from AM9PR04MB8620.eurprd04.prod.outlook.com (2603:10a6:20b:43b::23) by AM9PR04MB8275.eurprd04.prod.outlook.com (2603:10a6:20b:3ec::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7068.27; Fri, 8 Dec 2023 01:56:24 +0000 Received: from AM9PR04MB8620.eurprd04.prod.outlook.com ([fe80::4ef9:728:b125:4736]) by AM9PR04MB8620.eurprd04.prod.outlook.com ([fe80::4ef9:728:b125:4736%4]) with mapi id 15.20.7068.028; Fri, 8 Dec 2023 01:56:24 +0000 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=0.2 required=5.0 tests=FORGED_SPF_HELO, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.4 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=J5OfUehFwK0zV45AM11oEC2g+VKJhGGCEvHM7niHWJKLtrwopwmY+cAZ16b/U2jaf/tIqViLfUEqr3j/oBUsojT0tf4jSQlDf73jTHLTrlYcAW0EgzxlvcyjvhjU/AdSh3E9BMgvhrUo0mpoEWB3KDWomdbdG0PikQ8OeKelE5+FtVdN+gsAl/LrDGmsSfisBE1NP0ju/uc80HuCJx0gckYRk+irrQR/gwiGZ8R2hAHTZEkVx3s5O3KQQYR/I8gpibw0bGe5ixCDhc0+f5/0uUzmLoQrJEA/nNYp8LhFaFj/AKa2siS8FuTBXUKnRicm5hpj0Rfd2t2rCB/7DAj+FQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=aYmlQuAAInPRbJwTdPoLV5ybshzyxrw360WZULi7Wp0=; b=l7mM5HJ+4pv8RogdNYaJ3QPdv60huhTNtog5lMW+eEZ1/gTqoxfymGzmRyoOdgQDxj3GWGtaY8PkLbY3K6U9rXwe0VLgAwyirYds4a4GHMP4F70bEMoW7WkxwWQyZS3nRV8Ndl9jUGGb9bFiTNsrMaGrhLN8wzDPvVhiIFXhO3zxXUaw/Bg+hInL5iHeFATYfgUh6RzXRmv4fkZL3LA7lfWllT+jNsYUukJGQZafbXwdaI7uNxE0c0Ucruv8iTFaKc94sruSPBmRmqUdIeWwojWvPu0FTPZ5OsITQBiHrFT2D/GA2+PHC93KR0nJNnww6pVqwbA4903Ag/LPx8LzeA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none From: Jim Fehlig To: devel@lists.libvirt.org Subject: [PATCH] remote: Fix cached hypervisor type Date: Thu, 7 Dec 2023 18:56:09 -0700 Message-ID: <20231208015619.5831-1-jfehlig@suse.com> X-Mailer: git-send-email 2.43.0 X-ClientProxiedBy: CY5P221CA0143.NAMP221.PROD.OUTLOOK.COM (2603:10b6:930:6a::13) To AM9PR04MB8620.eurprd04.prod.outlook.com (2603:10a6:20b:43b::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM9PR04MB8620:EE_|AM9PR04MB8275:EE_ X-MS-Office365-Filtering-Correlation-Id: d0944f4b-2c5d-4700-57f0-08dbf790e1f1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: J11Qdk3JcpnVaF7o1r+jHSf7MEOnxUU9ZuSDRgi74X3FkZYN9V/8wyLYW52h9bGji8+8ubIwn0P+y0G9Ai9w4WuiJ/+TE/VYS7s3nObdbgGZ2M4Yfgjp5s7GSIglnSDIdqumk3tzG6m16pocWBVLS82YXWO8ANOaSjmSSg8MmBAAGlM/fx1gYUcH+uH0yEIPdEF3b6+/F4aF2jO9mz6h0hTjFOKdkcI0GUYrAu/r/COsvK/4NBy7S9Gun2/WcAG10V61NWt8J00TIQ1oH4XTeSIcPBL7RgKOdW0nileq9TnSTLa7G97gkMNE0tdVzD/AtU73Tjlh+HRKSKLrtNbtwAnEQWatGv7Yr28FMXtluYkPiDy6C9r81zcVRuw1qfWEIbRvY7GWSgSYgvt23jAY4Rt5prwHpX8naO9jVzY/0yk9PMfb6AsIp0Cv8Fvp+yKbwx/Lm1Eh5SFKWhMfBj+DaZxWwkCIluMfYqA7K2rZFSMD4FCZWs/pelONmcynNtt5oPGHRMTHw/v5eBs+P079oyKti7vZ3MfALLfBgKSkChbnwsBQRdePZESKcB1tSEKt X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM9PR04MB8620.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(366004)(376002)(136003)(39860400002)(396003)(346002)(230922051799003)(1800799012)(186009)(451199024)(64100799003)(4744005)(2906002)(8936002)(8676002)(5660300002)(316002)(66556008)(66476007)(66946007)(6916009)(2616005)(1076003)(6486002)(6512007)(6506007)(36756003)(26005)(6666004)(41300700001)(478600001)(83380400001)(38100700002)(86362001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?R3NTb0hlNEFzbDkvV2lJYlFTU3BjSTBwdkp1YXpad1paRlhyS0I2eForRXpW?= =?utf-8?B?TUE2K2d3Y0x2azR6Y1EvS1BtTTllbWIzbzhod2F0U3pzZWcwUjVlemdmWnVW?= =?utf-8?B?M1NjeTVTY09BNEVnakZVTjkvUFRaYW93U3FuTzVoWlRHNkJwaEorNVVpclRX?= =?utf-8?B?T2pZd0FNQ3ZYN3dhTjZHNE14cDlVMDFLU0dORUpXYVI0aHNUWlU5VEliV01a?= =?utf-8?B?QW9ZOGxHT2xNd0dPbWJyTkNDcHdydlhuSStCSzhHREpHMEFHbm5qbldWaDMv?= =?utf-8?B?Qnd5SGhVd1F0aE8xOGRYVGExaWtqbWE4c0J5K1E5NDR4TEJzdVEzUUFWVnN1?= =?utf-8?B?RFhkbHYwa3N1c2RMTGlhN3hjclh5My9pM1orWVRxT2QvS3hyZFV1MDJ4Ym13?= =?utf-8?B?dzA2SVBGcUZRZ2VTYm10VDRtTnJpMXdheHFPU2lLU25YUFFKNGVmMHRRSVlQ?= =?utf-8?B?bXozZ094M0wzOVo4UXRiMmswSURWVHVzQnduYzRtSTRCNzRqb2ZFbGUwcmRP?= =?utf-8?B?WmZKWG1RVFB2RG1yTUdpOXpOajlDdStkOVZOMXc2ZXF2WWpWV0lMQWE4Q0Fv?= =?utf-8?B?V3J3S2RxNmRjT0p4NTFMd1N1WGFKeDNSVHVhT2hydG9nUkxaMExHcWduRHVa?= =?utf-8?B?a29lNmxXS2w2N05EbGE0N2FvdEJIUWdGekczbWx4RDlHV3FxTkRZTktqV0k4?= =?utf-8?B?Ym1jQk5lWitsa0xKU1FLSUdRQUZtWklRbUZCM2RES1NBVFZZamY1TGIxYitH?= =?utf-8?B?UDRlSXpmQVNOcXJjaFg0K3NWM0ZDaitlRDdLQlN4YVBDR01HV1Flak80LzNC?= =?utf-8?B?MEpNS0NDdUhsbnN1MFJVdUtBM2hwWmJOM3AwMjNPbWNuUExMRFlvSURUcXRE?= =?utf-8?B?c0Z1Zi9sUlUxSnJkNmRSb1BXVThLbWIybCtKbFNkNVhGK3UwNUhzY29IZGlC?= =?utf-8?B?YWcxbUVPb3Naa1crYTVZSXlTSS9tYWlKZnZrSW1FK2FnTHE1UGpiSVdrUjdv?= =?utf-8?B?UjVXUFFIcW91MlpScmJ0dFBvTTN6c1JjL2cvWk52Q1M0bE9iMEJjdTdRd3pW?= =?utf-8?B?VHdRcDZKbndPUzRXWkVndlZoeEd2cTRJSXNacXJIa3pJYXVGb3FreVpMZ3JU?= =?utf-8?B?M0p4M0xPc3NrWWNER0VlMjNsN0lybnVWVU5hT2JpeVpQQUtrUU5PUWJ6Ym9W?= =?utf-8?B?YkM0SFR6SzFoN3VFQ0lhSm1mSmhCZ0xzM1g1UzlyZlhKSTNjci9iblBLMk0x?= =?utf-8?B?Zmh6bFd6SEsvUGNGVHFIWCtPazQ5SWY0S2ZIVCtvWVBHNGdxL2FkVHA4VHo2?= =?utf-8?B?OEZQN3Zzdk5LRjBMcUlRVEJtUVJ1bUNyK2dzUmp1QTVQeFRweFN0TEFJZ1lI?= =?utf-8?B?MWxQRFluUWp3Rmc5UEZJNytwTENRNjI3RHEyVHF6TXY2QlFSMU5OTFM5SEor?= =?utf-8?B?VldzS3lQcFFrRllUWnpONUhPZUZCT1lTUDc4MTZVMTJXbnptUkxNMXg5eC9Q?= =?utf-8?B?S2g5SEsrUjJVWEFkbkswU21zNW9Dc3o2ZmxYNGlvQ2lsbHJNUmx6aE5ZZWNV?= =?utf-8?B?dlkyMlpWNXp1VURCRWgrUzBZSnJyRnRBTWh5aCtGa3U4SUp3aE10OEJQVW40?= =?utf-8?B?KzYrZVVUSTlzbXBZemdJRWF3bnNqRHNSZWZGQTBzVEEzaW5teXROb0t2UXR5?= =?utf-8?B?MEQxNW85eVRtRXlwOFdtMVdHVGVTWU1jZFdhVVh5T29lK3hwbzBYK0svRVM3?= =?utf-8?B?dWV6WkNieGpuam1iQkJBSEw3K0h4YTlWMlZMRmNlYXZmL0xXVnVPVWUwakIy?= =?utf-8?B?WFVrOWpqL1I2L0NCQ3pwU0lZYlAvTFVVTDBhTFpqYmw1dlNJL2hTWjlPOHVL?= =?utf-8?B?SWdkUWo5UnNON3k4NnZsazJqMVNYSnJrcVM0SDdTb0RVWGJqOUl4VXRHZXNF?= =?utf-8?B?Q1lPUkxJRjBBNzYxbFRLWFNVR0tYN3VXZDdFVVRjWXRnN1N0LzZVemphUWhX?= =?utf-8?B?UUU1YXlON2NQc3lBOUlLaVZiNmhXSTZ5b3dXdENMd25OaWhiRWRDSkdXekVB?= =?utf-8?B?UG5TdkdTQ3BiYkw5VUU2QlZ5cW5mcVM3SnA0UGFoOFJsL1hvS1AzOW92VC9V?= =?utf-8?Q?LU/hWV/INw1FiJlk2vxzX2ZIN?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: d0944f4b-2c5d-4700-57f0-08dbf790e1f1 X-MS-Exchange-CrossTenant-AuthSource: AM9PR04MB8620.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Dec 2023 01:56:24.4041 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: os/3plJiTvVAlKnlAxE7LojWtJFS9q1WhyyNlOdCZTbpaa0uHc1zBiGPJQvTExz1iTsliXOAc1lGOlO2X8jB+Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8275 Message-ID-Hash: UZWWJOHKEOGSLLM66RH7RFPJSHKVCGAD X-Message-ID-Hash: UZWWJOHKEOGSLLM66RH7RFPJSHKVCGAD X-MailFrom: jfehlig@suse.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZM-MESSAGEID: 1702000664281100001 Commit 501825011c switched the remote driver to using g_auto, but missed one case of needing to steal a pointer holding the hypervisor type. Without it, memory is freed and the output of 'virsh version' has random output Compiled against library: libvirt 10.0.0 Using library: libvirt 10.0.0 Using API: =EF=BF=BD=EF=BF=BD%=EF=BF=BDU 10.0.0 Running hypervisor: =EF=BF=BD=EF=BF=BDU 8.1.3 Ths change also fixes random SIGABRT from perl processes running libvirt-tck tests. Signed-off-by: Jim Fehlig Reviewed-by: Daniel P. Berrang=C3=A9 --- src/remote/remote_driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/remote/remote_driver.c b/src/remote/remote_driver.c index c4831db6cd..132d0194c6 100644 --- a/src/remote/remote_driver.c +++ b/src/remote/remote_driver.c @@ -1408,7 +1408,7 @@ remoteConnectGetType(virConnectPtr conn) return NULL; =20 /* Stash. */ - return priv->type =3D ret.type; + return priv->type =3D g_steal_pointer(&ret.type); } =20 static int remoteConnectIsSecure(virConnectPtr conn) --=20 2.43.0 _______________________________________________ Devel mailing list -- devel@lists.libvirt.org To unsubscribe send an email to devel-leave@lists.libvirt.org