security_util: fix log in virSecurityMoveRememberedLabel

[PATCH] security_util: fix log in virSecurityMoveRememberedLabel

Posted by Anastasia Belova 4 months, 3 weeks ago

Fix incorrect log message for timestamp value.
Probably this line was copied from the check for attr.

Found by Linux Verification Center (linuxtesting.org).

Fixes: 7cfb7aab57 ("security_util: Remove stale XATTRs")
Signed-off-by: Anastasia Belova <abelova@astralinux.ru>
---
 src/security/security_util.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/security/security_util.c b/src/security/security_util.c
index a4e6687561..b96b4ccb1f 100644
--- a/src/security/security_util.c
+++ b/src/security/security_util.c
@@ -502,7 +502,7 @@ virSecurityMoveRememberedLabel(const char *name,
         } else if (errno != ENODATA) {
             virReportSystemError(errno,
                                  _("Unable to get XATTR %1$s on %2$s"),
-                                 attr_name, src);
+                                 timestamp_name, src);
             return -1;
         }
     }
-- 
2.30.2
_______________________________________________
Devel mailing list -- devel@lists.libvirt.org
To unsubscribe send an email to devel-leave@lists.libvirt.org

Re: [PATCH] security_util: fix log in virSecurityMoveRememberedLabel

Posted by Martin Kletzander 4 months, 3 weeks ago

On Wed, Dec 06, 2023 at 09:45:00PM +0300, Anastasia Belova wrote:
>Fix incorrect log message for timestamp value.
>Probably this line was copied from the check for attr.
>
>Found by Linux Verification Center (linuxtesting.org).
>
>Fixes: 7cfb7aab57 ("security_util: Remove stale XATTRs")
>Signed-off-by: Anastasia Belova <abelova@astralinux.ru>

Reviewed-by: Martin Kletzander <mkletzan@redhat.com>

>---
> src/security/security_util.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/src/security/security_util.c b/src/security/security_util.c
>index a4e6687561..b96b4ccb1f 100644
>--- a/src/security/security_util.c
>+++ b/src/security/security_util.c
>@@ -502,7 +502,7 @@ virSecurityMoveRememberedLabel(const char *name,
>         } else if (errno != ENODATA) {
>             virReportSystemError(errno,
>                                  _("Unable to get XATTR %1$s on %2$s"),
>-                                 attr_name, src);
>+                                 timestamp_name, src);
>             return -1;
>         }
>     }
>-- 
>2.30.2
>_______________________________________________
>Devel mailing list -- devel@lists.libvirt.org
>To unsubscribe send an email to devel-leave@lists.libvirt.org
_______________________________________________
Devel mailing list -- devel@lists.libvirt.org
To unsubscribe send an email to devel-leave@lists.libvirt.org