From nobody Fri May 10 01:07:59 2024 Delivered-To: importer@patchew.org Received-SPF: none (zohomail.com: 8.43.85.245 is neither permitted nor denied by domain of lists.libvirt.org) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; spf=none (zohomail.com: 8.43.85.245 is neither permitted nor denied by domain of lists.libvirt.org) smtp.mailfrom=devel-bounces@lists.libvirt.org Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1701888043455112.02293825345475; Wed, 6 Dec 2023 10:40:43 -0800 (PST) Received: by lists.libvirt.org (Postfix, from userid 996) id 038901730; Wed, 6 Dec 2023 13:40:41 -0500 (EST) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 6433A17DF; Wed, 6 Dec 2023 13:39:34 -0500 (EST) Received: by lists.libvirt.org (Postfix, from userid 996) id 6AFC117D1; Wed, 6 Dec 2023 13:39:31 -0500 (EST) Received: from mail.astralinux.ru (mail.astralinux.ru [217.74.38.119]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 84ACD17C1 for ; Wed, 6 Dec 2023 13:39:27 -0500 (EST) Received: from localhost (localhost.localdomain [127.0.0.1]) by mail.astralinux.ru (Postfix) with ESMTP id B38C1186AC9A; Wed, 6 Dec 2023 21:31:33 +0300 (MSK) Received: from mail.astralinux.ru ([127.0.0.1]) by localhost (rbta-msk-vsrv-mail01.astralinux.ru [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id DmQB_qDtugaW; Wed, 6 Dec 2023 21:31:33 +0300 (MSK) Received: from localhost (localhost.localdomain [127.0.0.1]) by mail.astralinux.ru (Postfix) with ESMTP id 69B1C186A852; Wed, 6 Dec 2023 21:31:33 +0300 (MSK) Received: from mail.astralinux.ru ([127.0.0.1]) by localhost (rbta-msk-vsrv-mail01.astralinux.ru [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 8O5akn7UuDfW; Wed, 6 Dec 2023 21:31:33 +0300 (MSK) Received: from rbta-msk-lt-106062.astralinux.ru (unknown [62.217.185.121]) by mail.astralinux.ru (Postfix) with ESMTPSA id 99AA5186A81F; Wed, 6 Dec 2023 21:31:32 +0300 (MSK) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.4 X-Greylist: delayed 470 seconds by postgrey-1.37 at lists.libvirt.org; Wed, 06 Dec 2023 13:39:27 EST X-Virus-Scanned: amavisd-new at astralinux.ru From: Anastasia Belova To: devel@lists.libvirt.org Subject: [PATCH] network: fix check in virNetworkLoadConfig Date: Wed, 6 Dec 2023 21:30:59 +0300 Message-Id: <20231206183059.16883-1-abelova@astralinux.ru> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Message-ID-Hash: UTZ3JW23YA5GJMNPLJX3CMCO5EDHLKEZ X-Message-ID-Hash: UTZ3JW23YA5GJMNPLJX3CMCO5EDHLKEZ X-MailFrom: abelova@astralinux.ru X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header CC: sdl.qemu@linuxtesting.org, Anastasia Belova X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZM-MESSAGEID: 1701888045257100001 virFileLinkPointsTo return non-zero value on fail. This value may be positive or negative, so check should be !=3D 0. Found by Linux Verification Center (linuxtesting.org) with SVACE. Fixes: bddbda99df ("network: Introduce virnetworkobj") Signed-off-by: Anastasia Belova --- src/conf/virnetworkobj.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/conf/virnetworkobj.c b/src/conf/virnetworkobj.c index 20ee8eb58a..47658986e8 100644 --- a/src/conf/virnetworkobj.c +++ b/src/conf/virnetworkobj.c @@ -945,7 +945,7 @@ virNetworkLoadConfig(virNetworkObjList *nets, if ((autostartLink =3D virNetworkConfigFile(autostartDir, name)) =3D= =3D NULL) return NULL; =20 - if ((autostart =3D virFileLinkPointsTo(autostartLink, configFile)) < 0) + if ((autostart =3D virFileLinkPointsTo(autostartLink, configFile)) != =3D 0) return NULL; =20 if (!(def =3D virNetworkDefParse(NULL, configFile, xmlopt, false))) --=20 2.30.2 _______________________________________________ Devel mailing list -- devel@lists.libvirt.org To unsubscribe send an email to devel-leave@lists.libvirt.org