From nobody Mon May 13 02:03:44 2024 Delivered-To: importer@patchew.org Received-SPF: none (zohomail.com: 8.43.85.245 is neither permitted nor denied by domain of lists.libvirt.org) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; spf=none (zohomail.com: 8.43.85.245 is neither permitted nor denied by domain of lists.libvirt.org) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1701372756137697.9800170152487; Thu, 30 Nov 2023 11:32:36 -0800 (PST) Received: by lists.libvirt.org (Postfix, from userid 996) id 608DB1AFD; Thu, 30 Nov 2023 14:32:35 -0500 (EST) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id 9CB2A1B71; Thu, 30 Nov 2023 14:30:09 -0500 (EST) Received: by lists.libvirt.org (Postfix, from userid 996) id 4D37019AB; Thu, 30 Nov 2023 14:30:01 -0500 (EST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 643DF18B6 for ; Thu, 30 Nov 2023 14:30:00 -0500 (EST) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-60-9eeD8KRDN1C-q0axjfGHxw-1; Thu, 30 Nov 2023 14:29:58 -0500 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 5A66E811E82 for ; Thu, 30 Nov 2023 19:29:58 +0000 (UTC) Received: from harajuku.usersys.redhat.com (unknown [10.45.224.59]) by smtp.corp.redhat.com (Postfix) with ESMTPS id DFC0B1121307 for ; Thu, 30 Nov 2023 19:29:57 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.4 X-MC-Unique: 9eeD8KRDN1C-q0axjfGHxw-1 From: Andrea Bolognani To: devel@lists.libvirt.org Subject: [libvirt PATCH 1/1] rpcgen: Skip generator tests on macOS Date: Thu, 30 Nov 2023 20:29:55 +0100 Message-ID: <20231130192955.1053492-2-abologna@redhat.com> In-Reply-To: <20231130192955.1053492-1-abologna@redhat.com> References: <20231130192955.1053492-1-abologna@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.3 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Message-ID-Hash: JDZ7OGDREWCJ57IDBDWMNWOAERONTXMS X-Message-ID-Hash: JDZ7OGDREWCJ57IDBDWMNWOAERONTXMS X-MailFrom: abologna@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="utf-8"; x-default="true" Content-Transfer-Encoding: quoted-printable X-ZM-MESSAGEID: 1701372756391000001 The generator can produce different code on Linux and macOS: specifically, on the former we want to use xdr_uint64_t while the latter needs xdr_u_int64_t instead. This is clearly a problem for tests that involve comparing the output produced against some expected output that's stored in the git repository. In the long run, we need to find a better way to handle this, but since 9.10.0 is going to be released very soon and we don't want it to have a broken test suite on macOS, simply skip the generator tests on that platform for now. Signed-off-by: Andrea Bolognani Reviewed-by: Daniel P. Berrang=C3=A9 --- scripts/rpcgen/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/rpcgen/meson.build b/scripts/rpcgen/meson.build index 7a8d505c61..7fb32c0f91 100644 --- a/scripts/rpcgen/meson.build +++ b/scripts/rpcgen/meson.build @@ -3,7 +3,7 @@ subdir('rpcgen') if tests_enabled[0] subdir('tests') =20 - if pytest_prog.found() + if pytest_prog.found() and host_machine.system() !=3D 'darwin' test( 'rpcgen-pytest', python3_prog, --=20 2.43.0 _______________________________________________ Devel mailing list -- devel@lists.libvirt.org To unsubscribe send an email to devel-leave@lists.libvirt.org