From nobody Mon May 13 17:02:30 2024 Delivered-To: importer@patchew.org Received-SPF: none (zohomail.com: 8.43.85.245 is neither permitted nor denied by domain of lists.libvirt.org) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; spf=none (zohomail.com: 8.43.85.245 is neither permitted nor denied by domain of lists.libvirt.org) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=fail(p=none dis=none) header.from=redhat.com Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1701338883338917.674983234984; Thu, 30 Nov 2023 02:08:03 -0800 (PST) Received: by lists.libvirt.org (Postfix, from userid 996) id 812DF1AFF; Thu, 30 Nov 2023 05:08:02 -0500 (EST) Received: from lists.libvirt.org (localhost [IPv6:::1]) by lists.libvirt.org (Postfix) with ESMTP id EFE201B04; Thu, 30 Nov 2023 05:06:44 -0500 (EST) Received: by lists.libvirt.org (Postfix, from userid 996) id 64D921B02; Thu, 30 Nov 2023 05:06:41 -0500 (EST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 630EC1AFF for ; Thu, 30 Nov 2023 05:06:39 -0500 (EST) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-367-dOYUOXO4OnqoCfhTIZxzjQ-1; Thu, 30 Nov 2023 05:06:37 -0500 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 45E34823F17 for ; Thu, 30 Nov 2023 10:06:37 +0000 (UTC) Received: from harajuku.usersys.redhat.com (unknown [10.45.225.138]) by smtp.corp.redhat.com (Postfix) with ESMTPS id CF743492BFE for ; Thu, 30 Nov 2023 10:06:36 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.4 X-MC-Unique: dOYUOXO4OnqoCfhTIZxzjQ-1 From: Andrea Bolognani To: devel@lists.libvirt.org Subject: [libvirt PATCH] rpcgen: Pass 3 arguments to xdrproc_t calls Date: Thu, 30 Nov 2023 11:06:35 +0100 Message-ID: <20231130100635.804286-1-abologna@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.10 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Message-ID-Hash: 23XMES2PIVIUTW44P7FHZYAYVOUDSE42 X-Message-ID-Hash: 23XMES2PIVIUTW44P7FHZYAYVOUDSE42 X-MailFrom: abologna@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-config-1; header-match-config-2; header-match-config-3; header-match-devel.lists.libvirt.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.2 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="utf-8"; x-default="true" Content-Transfer-Encoding: quoted-printable X-ZM-MESSAGEID: 1701338884683000001 The test_demo program currently fails to compile on macOS with too few arguments to function call, expected 3, have 2 ret =3D !!proc(&xdr, vorig); ~~~~ ^ Way back in 2013, commit 9fa3a8ab6fd8 handled this situation for the main library code. Apply the same fix here. Signed-off-by: Andrea Bolognani Reviewed-by: Daniel P. Berrang=C3=A9 --- scripts/rpcgen/tests/test_demo.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/scripts/rpcgen/tests/test_demo.c b/scripts/rpcgen/tests/test_d= emo.c index a48ceccd58..931f25f982 100644 --- a/scripts/rpcgen/tests/test_demo.c +++ b/scripts/rpcgen/tests/test_demo.c @@ -22,7 +22,7 @@ static void test_xdr(xdrproc_t proc, void *vorig, void *v= new, const char *testna /* Step 1: serialize the vorig and compare to the data in test .bin f= iles */ xdrmem_create(&xdr, buf, buflen, XDR_ENCODE); =20 - ret =3D !!proc(&xdr, vorig); + ret =3D !!proc(&xdr, vorig, 0); g_assert_cmpint(ret, =3D=3D, !fail); =20 if (fail) @@ -49,7 +49,7 @@ static void test_xdr(xdrproc_t proc, void *vorig, void *v= new, const char *testna /* Step 2: de-serialize the state to create a new object */ xdrmem_create(&xdr, buf, buflen, XDR_DECODE); =20 - ret =3D !!proc(&xdr, vnew); + ret =3D !!proc(&xdr, vnew, 0); g_assert_cmpint(ret, =3D=3D, true); =20 actlen =3D xdr_getpos(&xdr); @@ -63,7 +63,7 @@ static void test_xdr(xdrproc_t proc, void *vorig, void *v= new, const char *testna =20 xdrmem_create(&xdr, buf, buflen, XDR_ENCODE); =20 - ret =3D !!proc(&xdr, vnew); + ret =3D !!proc(&xdr, vnew, 0); g_assert_cmpint(ret, =3D=3D, true); =20 actlen =3D xdr_getpos(&xdr); --=20 2.43.0 _______________________________________________ Devel mailing list -- devel@lists.libvirt.org To unsubscribe send an email to devel-leave@lists.libvirt.org