util: vircommand: fix redundant if

[PATCH v1] util: vircommand: fix redundant if

Dmitry Frolov posted 1 patch 6 months, 3 weeks ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20231010085413.553063-1-frolov@swemel.ru

src/util/vircommand.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)

Expand all Fold all

[PATCH v1] util: vircommand: fix redundant if

Posted by Dmitry Frolov 6 months, 3 weeks ago

Comparisson "if(ret == -1)" is always false.
This statement was forgotten during switching to g_new0()

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Fixes: 0275b06a55fc7b1ec6a9e93f7fb73bea7388f634 ("util: command: use g_new0")
Signed-off-by: Dmitry Frolov <frolov@swemel.ru>
---
 src/util/vircommand.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/src/util/vircommand.c b/src/util/vircommand.c
index 9d4ba1e97c..81e74deee0 100644
--- a/src/util/vircommand.c
+++ b/src/util/vircommand.c
@@ -2227,7 +2227,7 @@ virCommandProcessIO(virCommand *cmd)
     int outfd = -1, errfd = -1;
     size_t inlen = 0, outlen = 0, errlen = 0;
     size_t inoff = 0;
-    int ret = 0;
+    int ret = -1;
     g_autofree struct pollfd *fds = NULL;
 
     if (dryRunBuffer || dryRunCallback) {
@@ -2254,9 +2254,6 @@ virCommandProcessIO(virCommand *cmd)
         VIR_FREE(*cmd->errbuf);
         *cmd->errbuf = g_new0(char, 1);
     }
-    if (ret == -1)
-        goto cleanup;
-    ret = -1;
 
     fds = g_new0(struct pollfd, 3 + virCommandGetNumSendBuffers(cmd));
 
-- 
2.34.1