From nobody Sun May 12 19:51:11 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=quarantine dis=quarantine) header.from=suse.com ARC-Seal: i=1; a=rsa-sha256; t=1695414088; cv=none; d=zohomail.com; s=zohoarc; b=QiVwQRjrhWKxbIq888oRgDrgiX7WvSUNz0Iwuyeu+k1rFWwQ4YNYOIJlK0Msi5LIGBqLWoaygVjATlNnxUxvQG4XNM7Gjhnqt6glgstf0ZlO8nAH9JOyy1c/Oq5FLmf7y9gL0sB4AZQicdZPj4hfwpySJ9QE9wvbAwDjY3wsItQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1695414088; h=Content-Type:Content-Transfer-Encoding:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=aEobkXKqcSQ9N7V3ckZrU7cpcAW4e49KMmzg4xhWN8w=; b=PqT0J76XODk3h2uRmgJQjl1CpbqMNUoe+fodIAyNB25GzJBgOsBCTtRc+pOiIPrpxzYon7LA8K8eXcgQMMXiFVXiXhSvCVwH+MuExkLGmDQvk/vg+iSjeSAt1BNawd4tVP+XZ1eN4ZgPbzqi9EO74kZvDCYSjOOeNLn/ruixryU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail header.from= (p=quarantine dis=quarantine) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1695414088296396.87729374949447; Fri, 22 Sep 2023 13:21:28 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-684-KWPmsXEzMC-3fXOSqBZr7g-1; Fri, 22 Sep 2023 16:21:23 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id C88CD803DBD; Fri, 22 Sep 2023 20:21:20 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id EDBCD10F1BE7; Fri, 22 Sep 2023 20:21:19 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id A93ED19465B8; Fri, 22 Sep 2023 20:21:03 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id F10891946586 for ; Fri, 22 Sep 2023 20:20:31 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id A0076140E953; Fri, 22 Sep 2023 20:20:31 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast01.extmail.prod.ext.rdu2.redhat.com [10.11.55.17]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 985CA140E950 for ; Fri, 22 Sep 2023 20:20:31 +0000 (UTC) Received: from us-smtp-inbound-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 70A4985A5A8 for ; Fri, 22 Sep 2023 20:20:31 +0000 (UTC) Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on2084.outbound.protection.outlook.com [40.107.14.84]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-518-I_thr4ICPiOheMXG5EPyfw-1; Fri, 22 Sep 2023 16:20:29 -0400 Received: from PAXPR04MB8623.eurprd04.prod.outlook.com (2603:10a6:102:21a::11) by AM0PR04MB7122.eurprd04.prod.outlook.com (2603:10a6:208:19c::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6813.20; Fri, 22 Sep 2023 20:20:26 +0000 Received: from PAXPR04MB8623.eurprd04.prod.outlook.com ([fe80::2366:be:c6f3:695f]) by PAXPR04MB8623.eurprd04.prod.outlook.com ([fe80::2366:be:c6f3:695f%5]) with mapi id 15.20.6813.017; Fri, 22 Sep 2023 20:20:26 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1695414086; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=aEobkXKqcSQ9N7V3ckZrU7cpcAW4e49KMmzg4xhWN8w=; b=SDIOYXqgg4ZAdwPFGGpeq1vFgUpzCF005IJNkP3xUntzlhZUWQD36TFDJhaoGWGS8zZ4B4 MQlzjhche4gVa+R2tzCs5Gz+23kAu+cs/wDFEb3ZKACncQVX4Jf5GXlZ7W4iavM7wvxPlF 4EmQy7geej/FhqNqjmXgrLgF0S+5BYk= X-MC-Unique: KWPmsXEzMC-3fXOSqBZr7g-1 X-Original-To: libvir-list@listman.corp.redhat.com X-MC-Unique: I_thr4ICPiOheMXG5EPyfw-1 From: Jim Fehlig To: libvir-list@redhat.com Subject: [PATCH] libxl: Fix connection to modular network daemon Date: Fri, 22 Sep 2023 14:20:10 -0600 Message-ID: <20230922202019.24162-1-jfehlig@suse.com> X-ClientProxiedBy: CY5PR15CA0046.namprd15.prod.outlook.com (2603:10b6:930:1b::7) To PAXPR04MB8623.eurprd04.prod.outlook.com (2603:10a6:102:21a::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB8623:EE_|AM0PR04MB7122:EE_ X-MS-Office365-Filtering-Correlation-Id: 57478b8a-720c-4e7a-9358-08dbbba95bb8 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0 X-Microsoft-Antispam-Message-Info: 93IuZHS8BzUt1hUvCIIoW+hIoW03n7jWFs1ZeR+xO1jx6O0Hgn4u2ulN34cctfE3bDAjfIL2zXSO1Y1ARLNbtwO8/qkqX3fzCE1pNnEtHnno33BqQ1PxfP/RrAhhKSXzYhmoNJAjA7DWVRQRwZ9ge7Y2XSpQoNKqTIfvOf8DNVeSxcSnPHaaVWT6IycjnxjV7sj0bOZ9ZqzQSf7xtCBKvLCb9Sx/1HnkTtEB47NdsEl94Tp/z+DFW2Pl67EBhmxWhpXkTuGj/h1pXUakSWWJcm6GerXLB9bcNwn4G7wfuMQ+WRXZiZiG1jWACm8PuF8deZTtn3i29XxMtwV8faJcE/0el4Xey+6A9lYmjkczItVsqHxNU+VZM67y10k+C62FrEcxLCozs/aeH/aExwox2gcyXEeO3TPS/3ykZPkGbOqIyAPxgmx4KhiZgeRHCh0VVNcrrLiYdpVmmhqRF3spR3/yrsizdPtdUZ5yXgwGKx5L5EoICLz0KxwZdPhSsMVZi2/HR5a6/UKStkFotVzCB/zZAPZEEBLKRfOvJc0wBKd50O0l+yR2TVTEOu9Q5ZYo X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PAXPR04MB8623.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(376002)(346002)(136003)(366004)(39860400002)(396003)(451199024)(1800799009)(186009)(41300700001)(5660300002)(2616005)(1076003)(2906002)(26005)(36756003)(38100700002)(4744005)(86362001)(8676002)(83380400001)(478600001)(6666004)(6512007)(6486002)(8936002)(6916009)(316002)(6506007)(66556008)(66946007)(66476007); DIR:OUT; SFP:1101 X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?tD5Ytz4eDvveX/+x8C11B44wjNvhflSoPQVT3xLFZfGt2c/HREiLmhclefYU?= =?us-ascii?Q?gs9w1iI47IVWTvRT+FRQ849lTst6PHsaedEogRUWhkpdlblDLXTSMdS8RIyX?= =?us-ascii?Q?34osH/8GgU//lUZmegZCqmh3C91Nm1qBArV+FTHiS12EQ2mphXU2PSDle764?= =?us-ascii?Q?22sNLEJiFBMsQMV6AVhL3LdGcKdv20HmWUrxFN/ttwJFuBmuuZ/6rj3slHz0?= =?us-ascii?Q?VtdKs46cjf6L2ZtFxhf3NGDtdwY8jnIciiF3uK4y0BIxsPtSvw3trQ2V7QiB?= =?us-ascii?Q?/LT0+HXG3jeJiOvSCgxJhfbfa2vvQvSUqauGda2WSFEYX639ka2MsFgyepbK?= =?us-ascii?Q?cqx7GcH7jeISh1R1qzEXBFBTufNpT8pTGGTTq0Ar0hjWiNpHv+MK+nrXgJx/?= =?us-ascii?Q?SEnEeOnh/r5Y6OTFFqoPsB5y6qaiULXc72MUfn1owSUvYNXGnFpoefSUk82s?= =?us-ascii?Q?T99gL5CP+orDWgs4r+Pa/dyM+lZBw4uHsbstqMz0byCXs0Ggo6ry2CDZluA6?= =?us-ascii?Q?zCihpoEUolYCrxNLoOh3kPJiGzGnUy8wJvym4YfINyWlIJdykyC15c4RUaCz?= =?us-ascii?Q?MnoFYFt48+g7FCWIGpQR7sTu2Oy7dQOmhvul3nJbWU7CwtItgD4gSYzIRXJ8?= =?us-ascii?Q?9Tu1ozDTcq57y7uNSX/7ELOk131KhWyTmJz5a93/BobMih84UjVDOFCKjtBG?= =?us-ascii?Q?SrEFQLtZUsozFnB2mcVJT6DVgLJn76Uqaxq1ar9gidq7vWqe8wN2Utnt3X+I?= =?us-ascii?Q?nkN9D/aNmA0MFXYB3exqqfACn0TLZaMJ8V9dVYNCqD5VkSearHqt+qVplvnR?= =?us-ascii?Q?QqH83QyNdy09Otr9+gcm85m9iAlz/lkGY0U5+ROsco42cDrntZOg/UEbyRma?= =?us-ascii?Q?DUiIfqaAB7WkhERg62iUga+UnqEfZDhfDa47GAab3ue9gnww/FugXilCFelR?= =?us-ascii?Q?L5OsrdRBc5DhlZxqHSTPCDLZvxJIwnRqsxI46qrgcG1MqUgTc01Pae/tIDV7?= =?us-ascii?Q?TpcA73KGJJj3WDqx4rZ/U6tzUb/pfO+qj5j+CyvXYP4Hkt0PDzeC0TUrkuWl?= =?us-ascii?Q?mSaOvlilN0TX1Uw5eiw9RJtDhBx0Yqng1SdQ1LqVkTTBACWvTjHdBnjXeCIt?= =?us-ascii?Q?9RqULSuO+bWpZ3cDfOF4+ktDHuyroYJ5FHUrQwhXbjgzcIHNSRf1mY/G5tm+?= =?us-ascii?Q?+KVbXpolQaBl1lhhkh6hzSvUUisql0/bQpMTevcYu+nHM7u7hiz+/zQ5YGGL?= =?us-ascii?Q?nVe82rjjhT2FgqaRGsquhs6Lkl5ystBdNplAJ8MltI0igOlgXqyGk4sQdNhc?= =?us-ascii?Q?uNhJvRT+xfGC+EmgWuIsfaByCGxJw8nDDd4bv7XOasBr/9HHqWL2O2NOs+ac?= =?us-ascii?Q?Kr6x8+0Gbk3zzlqEVRSzFeYAMHzP+zPOSeJCxctRGG1xV1+OTWYi2UwjAhKA?= =?us-ascii?Q?gF7MdWLY/9cG87IOWfdsVcoCGlPtnuGGV/h1XL7fISPnLBHF9+lieGGWHjBX?= =?us-ascii?Q?OJmuAJnGSj0kW1KIOkjz4OQdEZrzkm9ACRryHfpF4tp8NCnS5AENNsQq15gO?= =?us-ascii?Q?Q1pDiIOpjZwlNimcaPJyDQ//UP3n0ArJptYTYR2s?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 57478b8a-720c-4e7a-9358-08dbbba95bb8 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8623.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Sep 2023 20:20:26.6667 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: L4AyoFfR9kK+SYxraIT0h4mtN6UzLjDQzy52cg2rvQ5dI9PM5r/f10OR6ygm5pJtxBiPTMnyqytJH98tzYdvWA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB7122 X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 3.1 on 10.11.54.7 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: suse.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1695414090908100001 Content-Type: text/plain; charset="utf-8" In a modular daemon configuration, virtxend does not support the virNetwork* APIs. It should open a connection to virtnetworkd when using those APIs, but currently always opens a connection to "xen:///system". Switch to using virGetConnectNetwork to obtain a valid connection instead of using the hardcoded URI. Signed-off-by: Jim Fehlig Reviewed-by: Daniel P. Berrang=C3=A9 --- src/libxl/libxl_conf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libxl/libxl_conf.c b/src/libxl/libxl_conf.c index 4582126d19..62e1be6672 100644 --- a/src/libxl/libxl_conf.c +++ b/src/libxl/libxl_conf.c @@ -1372,7 +1372,7 @@ libxlMakeNic(virDomainDef *def, break; case VIR_DOMAIN_NET_TYPE_NETWORK: { - if (!(conn =3D virConnectOpen("xen:///system"))) + if (!(conn =3D virGetConnectNetwork())) goto cleanup; =20 if (!(network =3D --=20 2.42.0