On 9/3/23 17:49, K Shiva Kiran wrote:
> This patchset adds support for the following user defined metadata
> fields for network filters.
>
> - title: A short description of the filter.
> - description: Any documentation that the user wants to store.
> - metadata: Other metadata in XML form.
>
> K Shiva Kiran (16):
> xml: Add <title>, <description> and <metadata> to nwfilter xml schema
> conf: Add parser logic for nwfilter metadata fields
> nwfilter: Add enum to operate on user defined metadata
> nwfilter: Add error code and message for missing metadata
> nwfilter: Introduce public API to modify user metadata
> nwfilter: Introduce public API to retrieve user-defined metadata
> nwfilter: Implement RPC
> virsh: Add helper method to retrieve xml from NWFilter def
> virsh: Add new command `nwfilter-desc`
> virsh: Add new command `nwfilter-metadata`
> virsh: Add option --title for nwfilter-list
> docs: Document nwfilter metadata related commands
> virnwfilterobj: Add virNWFilterObjGetMetadata()
> virnwfilterobj: Add virNWFilterObjSetMetadata()
> nwfilter_driver: Add Driver implementation for metadata
> NEWS: Introduce user-defined metadata fields for NWFilter object
>
> NEWS.rst | 18 ++
> docs/formatnwfilter.rst | 31 +++
> docs/manpages/virsh.rst | 98 +++++++-
> include/libvirt/libvirt-nwfilter.h | 27 ++
> include/libvirt/virterror.h | 1 +
> src/conf/nwfilter_conf.c | 30 +++
> src/conf/nwfilter_conf.h | 5 +
> src/conf/schemas/nwfilter.rng | 9 +
> src/conf/virnwfilterobj.c | 148 +++++++++++
> src/conf/virnwfilterobj.h | 13 +
> src/driver-nwfilter.h | 15 ++
> src/libvirt-nwfilter.c | 154 ++++++++++++
> src/libvirt_private.syms | 2 +
> src/libvirt_public.syms | 6 +
> src/nwfilter/nwfilter_driver.c | 61 +++++
> src/remote/remote_driver.c | 2 +
> src/remote/remote_protocol.x | 34 ++-
> src/remote_protocol-structs | 19 ++
> src/util/virerror.c | 3 +
> tools/virsh-nwfilter.c | 387 ++++++++++++++++++++++++++++-
> tools/virsh-util.c | 25 ++
> tools/virsh-util.h | 9 +
> 22 files changed, 1089 insertions(+), 8 deletions(-)
>
The code looks okay. But the split into patches is a bit awkward. Also,
since I've merged your other series, there's a conflict in RPC
definition file.
Looking forward to v2.
Michal