From nobody Sat May 18 16:46:59 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1693412569; cv=none; d=zohomail.com; s=zohoarc; b=HaFUG9bsKLyEqo0AlOPJQyML9uaBLcy4pgiDP/904FwQG+NcTBPGLsQIU7I9bPeo1banXyHA7K/Bb2uaZIXboWWHw6FKMwTtmbRf5FkujwcbJ2eRSs9nOkbrhzjeAd1H0v+cbTqte0Bu4+KXGgQWV1DYLglF+mUBKhQLj4Jtlwo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1693412569; h=Content-Type:Content-Transfer-Encoding:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=G5z/lRFskb+2mwT7GA6rZp2mh8sX+2fRiyGBSh4Apl8=; b=bCDNVlOwDxSh9yOkWvL3sdgrU/OHLE09C/DUDbASKzVG/TLIm2d9UK8cRQ412RqzQocDw+v16s31yvbLnUc+MPTMesrDkc9LT/XVo7XxH9vnWF7ZF2QNG4Hne4tfPTnNWXtH+o1jxXXVaWcfZaR+sJd7FSPMX0tK+aP9VE850Mo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 16934125696401007.1718165235656; Wed, 30 Aug 2023 09:22:49 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-680-X82-qso-Of6JZv7U3lldOw-1; Wed, 30 Aug 2023 12:22:45 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 61750101AA78; Wed, 30 Aug 2023 16:22:41 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5D8EAC15BB8; Wed, 30 Aug 2023 16:22:40 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 23D4219465A3; Wed, 30 Aug 2023 16:22:40 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 3B4EC1946589 for ; Wed, 30 Aug 2023 16:22:39 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 1AE4F140E96E; Wed, 30 Aug 2023 16:22:39 +0000 (UTC) Received: from harajuku.usersys.redhat.com (unknown [10.45.226.160]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 984D5140E96F for ; Wed, 30 Aug 2023 16:22:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1693412568; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=G5z/lRFskb+2mwT7GA6rZp2mh8sX+2fRiyGBSh4Apl8=; b=CjnKp0SXFNv5ySHZ9KW+CyIGTQwbhWhys0mtXgFPqwtb+L3unaUtVVYwSr6aI21Up+1Z66 XZJgaNIJ5hyCPADogFOmQjWDwvczGmbh00I0qCz3R5OGeybH1ZxBolccPzgZrPhRBymXXm cuqwrLv5O7TLJ4Rfga7hM7unaWBHVDA= X-MC-Unique: X82-qso-Of6JZv7U3lldOw-1 X-Original-To: libvir-list@listman.corp.redhat.com From: Andrea Bolognani To: libvir-list@redhat.com Subject: [libvirt PATCH] rpm: Recommend libvirt-daemon for with_modular_daemons distros Date: Wed, 30 Aug 2023 18:22:33 +0200 Message-ID: <20230830162233.185865-1-abologna@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.7 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.8 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1693412571216100001 Content-Type: text/plain; charset="utf-8"; x-default="true" A default deployment on modern distros uses modular daemons but switching back to the monolithic daemon, while not recommended, is still considered a perfectly valid option. For a monolithic daemon deployment, the upgrade to libvirt 9.2.0 or newer works as expected; a subsequent call to dnf autoremove, however, results in the libvirt-daemon package being removed and the deployment no longer working. In order to avoid that situation, mark the libvirt-daemon as recommended. This will unfortunately result in it being included in most installations despite not being necessary, but considering that the alternative is breaking existing setups on upgrade it feels like a reasonable tradeoff. Moreover, since the dependency on libvirt-daemon is just a weak one, it's still possible for people looking to minimize the footprint of their installation to manually remove the package after installation, mitigating the drawbacks of this approach. https://bugzilla.redhat.com/show_bug.cgi?id=3D2232805 Signed-off-by: Andrea Bolognani Reviewed-by: Erik Skultety --- libvirt.spec.in | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/libvirt.spec.in b/libvirt.spec.in index 6bbc7a0e9a..b471afebb1 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -830,6 +830,7 @@ Requires: libvirt-daemon-log =3D %{version}-%{release} Requires: libvirt-daemon-lock =3D %{version}-%{release} Requires: libvirt-daemon-plugin-lockd =3D %{version}-%{release} Requires: libvirt-daemon-proxy =3D %{version}-%{release} +Recommends: libvirt-daemon =3D %{version}-%{release} %else Requires: libvirt-daemon =3D %{version}-%{release} %endif @@ -857,6 +858,7 @@ Requires: libvirt-daemon-log =3D %{version}-%{release} Requires: libvirt-daemon-lock =3D %{version}-%{release} Requires: libvirt-daemon-plugin-lockd =3D %{version}-%{release} Requires: libvirt-daemon-proxy =3D %{version}-%{release} +Recommends: libvirt-daemon =3D %{version}-%{release} %else Requires: libvirt-daemon =3D %{version}-%{release} %endif @@ -881,6 +883,7 @@ Summary: Server side daemon & driver required to run LX= C guests %if %{with_modular_daemons} Requires: libvirt-daemon-common =3D %{version}-%{release} Requires: libvirt-daemon-proxy =3D %{version}-%{release} +Recommends: libvirt-daemon =3D %{version}-%{release} %else Requires: libvirt-daemon =3D %{version}-%{release} %endif @@ -906,6 +909,7 @@ Requires: libvirt-daemon-common =3D %{version}-%{releas= e} Requires: libvirt-daemon-lock =3D %{version}-%{release} Requires: libvirt-daemon-plugin-lockd =3D %{version}-%{release} Requires: libvirt-daemon-proxy =3D %{version}-%{release} +Recommends: libvirt-daemon =3D %{version}-%{release} %else Requires: libvirt-daemon =3D %{version}-%{release} %endif @@ -930,6 +934,7 @@ Summary: Server side daemon & driver required to run Vi= rtualBox guests %if %{with_modular_daemons} Requires: libvirt-daemon-common =3D %{version}-%{release} Requires: libvirt-daemon-proxy =3D %{version}-%{release} +Recommends: libvirt-daemon =3D %{version}-%{release} %else Requires: libvirt-daemon =3D %{version}-%{release} %endif --=20 2.41.0