[libvirt PATCH v2 0/6] Fix compilation on msys2, update keycodemapdb

marcandre.lureau@redhat.com posted 6 patches 1 year, 1 month ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20230417115401.327720-1-marcandre.lureau@redhat.com
.gitmodules                   |  2 +-
docs/manpages/meson.build     |  4 ++--
docs/meson.build              |  6 ++----
meson.build                   | 15 ++++++++++-----
src/admin/meson.build         |  4 ++--
src/esx/meson.build           |  4 ++--
src/hyperv/meson.build        |  2 +-
src/keycodemapdb              |  1 -
src/meson.build               |  8 ++++----
src/rpc/virnetlibsshsession.c | 10 +++++++++-
src/util/meson.build          |  8 ++++----
subprojects/keycodemapdb      |  1 +
12 files changed, 38 insertions(+), 27 deletions(-)
delete mode 160000 src/keycodemapdb
create mode 160000 subprojects/keycodemapdb
[libvirt PATCH v2 0/6] Fix compilation on msys2, update keycodemapdb
Posted by marcandre.lureau@redhat.com 1 year, 1 month ago
From: Marc-André Lureau <marcandre.lureau@redhat.com>

Hi,

libvirt fails to compile on msys2/win32.

Also update keycodemapdb to fix CI build issues, and turn it into a
subproject(), as that makes things simpler for meson.

Fixes:
https://gitlab.com/libvirt/libvirt/-/issues/453

v2:
 - update based on Michal version
 - update keycodemapdb, make it a subproject()

Marc-André Lureau (6):
  meson: don't look for unix paths on win32
  keycodemapdb: update submodule for build fixes
  meson: don't hard code find_program() location
  meson: drop explicit python interpreter
  rpc/ssh: ssh_userauth_agent() is not supported on win32
  Move src/keycodemapdb -> subprojects/keycodemapdb

 .gitmodules                   |  2 +-
 docs/manpages/meson.build     |  4 ++--
 docs/meson.build              |  6 ++----
 meson.build                   | 15 ++++++++++-----
 src/admin/meson.build         |  4 ++--
 src/esx/meson.build           |  4 ++--
 src/hyperv/meson.build        |  2 +-
 src/keycodemapdb              |  1 -
 src/meson.build               |  8 ++++----
 src/rpc/virnetlibsshsession.c | 10 +++++++++-
 src/util/meson.build          |  8 ++++----
 subprojects/keycodemapdb      |  1 +
 12 files changed, 38 insertions(+), 27 deletions(-)
 delete mode 160000 src/keycodemapdb
 create mode 160000 subprojects/keycodemapdb

-- 
2.40.0

Re: [libvirt PATCH v2 0/6] Fix compilation on msys2, update keycodemapdb
Posted by Michal Prívozník 1 year, 1 month ago
On 4/17/23 13:53, marcandre.lureau@redhat.com wrote:
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
> 
> Hi,
> 
> libvirt fails to compile on msys2/win32.
> 
> Also update keycodemapdb to fix CI build issues, and turn it into a
> subproject(), as that makes things simpler for meson.
> 
> Fixes:
> https://gitlab.com/libvirt/libvirt/-/issues/453
> 
> v2:
>  - update based on Michal version
>  - update keycodemapdb, make it a subproject()
> 
> Marc-André Lureau (6):
>   meson: don't look for unix paths on win32
>   keycodemapdb: update submodule for build fixes
>   meson: don't hard code find_program() location
>   meson: drop explicit python interpreter
>   rpc/ssh: ssh_userauth_agent() is not supported on win32
>   Move src/keycodemapdb -> subprojects/keycodemapdb
> 
>  .gitmodules                   |  2 +-
>  docs/manpages/meson.build     |  4 ++--
>  docs/meson.build              |  6 ++----
>  meson.build                   | 15 ++++++++++-----
>  src/admin/meson.build         |  4 ++--
>  src/esx/meson.build           |  4 ++--
>  src/hyperv/meson.build        |  2 +-
>  src/keycodemapdb              |  1 -
>  src/meson.build               |  8 ++++----
>  src/rpc/virnetlibsshsession.c | 10 +++++++++-
>  src/util/meson.build          |  8 ++++----
>  subprojects/keycodemapdb      |  1 +
>  12 files changed, 38 insertions(+), 27 deletions(-)
>  delete mode 160000 src/keycodemapdb
>  create mode 160000 subprojects/keycodemapdb
> 

Reviewed-by: Michal Privoznik <mprivozn@redhat.com>

and merged.

Michal