On 4/6/23 17:58, marcandre.lureau@redhat.com wrote:
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
>
> Hi,
>
> libvirt fails to compile on msys2/win32. Here is a few patches that solve it,
> but the way python scripts are being handled in general is a bit odd, so this is
> RFC. (fwiw, a lot of tests fail though, I can send the log if anyone is
> interested - or attach it to a gitlab issue)
>
> Fixes:
> https://gitlab.com/libvirt/libvirt/-/issues/453
>
> Marc-André Lureau (3):
> meson: don't look for unix paths on win32
> meson: drop explicit python interpreter
> rpc/ssh: ssh_userauth_agent() is not supported on win32
>
> docs/manpages/meson.build | 4 ++--
> docs/meson.build | 6 ++----
> meson.build | 14 +++++++++-----
> src/admin/meson.build | 4 ++--
> src/esx/meson.build | 4 ++--
> src/hyperv/meson.build | 2 +-
> src/meson.build | 8 ++++----
> src/rpc/virnetlibsshsession.c | 14 ++++++++++++--
> src/util/meson.build | 4 ++--
> 9 files changed, 36 insertions(+), 24 deletions(-)
>
Hey, thanks for this. I have couple of questions though. No need to
resend, I can squash in obvious changes if you agree before pushing.
Michal