See patch 3/3 for the rationale.

Test pipeline: https://gitlab.com/abologna/libvirt/-/pipelines/823120265

Andrea Bolognani (3):
  tests: Drop dead code
  tests: Don't build virgdbusmock on Windows
  tests: Don't use GIO_COMPILATION

 tests/meson.build       | 11 ++++++-----
 tests/virfirewalltest.c |  4 ----
 2 files changed, 6 insertions(+), 9 deletions(-)

-- 
2.39.2

On a Thursday in 2023, Andrea Bolognani wrote:
>See patch 3/3 for the rationale.
>
>Test pipeline: https://gitlab.com/abologna/libvirt/-/pipelines/823120265
>
>Andrea Bolognani (3):
>  tests: Drop dead code
>  tests: Don't build virgdbusmock on Windows
>  tests: Don't use GIO_COMPILATION
>
> tests/meson.build       | 11 ++++++-----
> tests/virfirewalltest.c |  4 ----
> 2 files changed, 6 insertions(+), 9 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>

However I'm not convinced this is post-rc2 material.

Jano

On Thu, Mar 30, 2023 at 04:59:38PM +0200, Ján Tomko wrote:
> On a Thursday in 2023, Andrea Bolognani wrote:
> >  tests: Drop dead code
> >  tests: Don't build virgdbusmock on Windows
> >  tests: Don't use GIO_COMPILATION
> >
> > tests/meson.build       | 11 ++++++-----
> > tests/virfirewalltest.c |  4 ----
> > 2 files changed, 6 insertions(+), 9 deletions(-)
>
> Reviewed-by: Ján Tomko <jtomko@redhat.com>
>
> However I'm not convinced this is post-rc2 material.

It's good that I had no intention of pushing it until after the
release of 9.2.0 then :)

-- 
Andrea Bolognani / Red Hat / Virtualization

On 3/30/23 9:39 AM, Andrea Bolognani wrote:
> See patch 3/3 for the rationale.
> 
> Test pipeline: https://gitlab.com/abologna/libvirt/-/pipelines/823120265
> 
> Andrea Bolognani (3):
>    tests: Drop dead code
>    tests: Don't build virgdbusmock on Windows
>    tests: Don't use GIO_COMPILATION
> 
>   tests/meson.build       | 11 ++++++-----
>   tests/virfirewalltest.c |  4 ----
>   2 files changed, 6 insertions(+), 9 deletions(-)
> 


Reviewed-by: Jonathon Jongsma <jjongsma@redhat.com>