[PATCH v1 0/4] Introduce virsh hypervisor-cpu-models

Collin Walling posted 4 patches 1 year, 1 month ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20230322153918.96924-1-walling@linux.ibm.com
docs/manpages/virsh.rst        | 20 ++++++++++
include/libvirt/libvirt-host.h |  6 +++
src/driver-hypervisor.h        |  9 +++++
src/libvirt-host.c             | 54 ++++++++++++++++++++++++++
src/libvirt_public.syms        |  5 +++
src/qemu/qemu_driver.c         | 62 ++++++++++++++++++++++++++++++
src/remote/remote_driver.c     |  1 +
src/remote/remote_protocol.x   | 20 +++++++++-
src/remote_protocol-structs    | 11 ++++++
tools/virsh-host.c             | 70 ++++++++++++++++++++++++++++++++++
10 files changed, 257 insertions(+), 1 deletion(-)
[PATCH v1 0/4] Introduce virsh hypervisor-cpu-models
Posted by Collin Walling 1 year, 1 month ago
Allows for the query of hypervisor-known CPU models via the simple
command: virsh hypervisor-cpu-models. For the QEMU driver, the models
are queried via the capabilities file. Each model is printed to the
terminal on its own line similar to the cpu-models command, and there
is no order to the listing.

The models "qemu", "host", and "max" have been excluded from this list
since they are not architecture specific. The code can be easily modified
to include them if desired.

Collin Walling (4):
  Introduce virConnectGetHypervisorCPUNames public API
  remote: Implement virConnectGetHypervisorCPUNames
  virsh: Introduce new hypervisor-cpu-models command
  qemu_driver: Implement qemuConnectGetHypervisorCPUNames

 docs/manpages/virsh.rst        | 20 ++++++++++
 include/libvirt/libvirt-host.h |  6 +++
 src/driver-hypervisor.h        |  9 +++++
 src/libvirt-host.c             | 54 ++++++++++++++++++++++++++
 src/libvirt_public.syms        |  5 +++
 src/qemu/qemu_driver.c         | 62 ++++++++++++++++++++++++++++++
 src/remote/remote_driver.c     |  1 +
 src/remote/remote_protocol.x   | 20 +++++++++-
 src/remote_protocol-structs    | 11 ++++++
 tools/virsh-host.c             | 70 ++++++++++++++++++++++++++++++++++
 10 files changed, 257 insertions(+), 1 deletion(-)

--
2.39.0
Re: [PATCH v1 0/4] Introduce virsh hypervisor-cpu-models
Posted by Tim Wiederhake 1 year, 1 month ago
On Wed, 2023-03-22 at 11:39 -0400, Collin Walling wrote:
> Allows for the query of hypervisor-known CPU models via the simple
> command: virsh hypervisor-cpu-models. For the QEMU driver, the models
> are queried via the capabilities file. Each model is printed to the
> terminal on its own line similar to the cpu-models command, and there
> is no order to the listing.
> 
> The models "qemu", "host", and "max" have been excluded from this
> list
> since they are not architecture specific. The code can be easily
> modified
> to include them if desired.
> 
> Collin Walling (4):
>   Introduce virConnectGetHypervisorCPUNames public API
>   remote: Implement virConnectGetHypervisorCPUNames
>   virsh: Introduce new hypervisor-cpu-models command
>   qemu_driver: Implement qemuConnectGetHypervisorCPUNames
> 
>  docs/manpages/virsh.rst        | 20 ++++++++++
>  include/libvirt/libvirt-host.h |  6 +++
>  src/driver-hypervisor.h        |  9 +++++
>  src/libvirt-host.c             | 54 ++++++++++++++++++++++++++
>  src/libvirt_public.syms        |  5 +++
>  src/qemu/qemu_driver.c         | 62 ++++++++++++++++++++++++++++++
>  src/remote/remote_driver.c     |  1 +
>  src/remote/remote_protocol.x   | 20 +++++++++-
>  src/remote_protocol-structs    | 11 ++++++
>  tools/virsh-host.c             | 70
> ++++++++++++++++++++++++++++++++++
>  10 files changed, 257 insertions(+), 1 deletion(-)
> 
> --
> 2.39.0
> 

Have a look at
https://listman.redhat.com/archives/libvir-list/2022-June/232626.html

You might be interested in the discussion we had there, about a very
similar patch set.

- Tim
Re: [PATCH v1 0/4] Introduce virsh hypervisor-cpu-models
Posted by Collin Walling 1 year, 1 month ago
On 3/22/23 1:00 PM, Tim Wiederhake wrote:
> On Wed, 2023-03-22 at 11:39 -0400, Collin Walling wrote:
>> Allows for the query of hypervisor-known CPU models via the simple
>> command: virsh hypervisor-cpu-models. For the QEMU driver, the models
>> are queried via the capabilities file. Each model is printed to the
>> terminal on its own line similar to the cpu-models command, and there
>> is no order to the listing.
>>
>> The models "qemu", "host", and "max" have been excluded from this
>> list
>> since they are not architecture specific. The code can be easily
>> modified
>> to include them if desired.
>>
>> Collin Walling (4):
>>    Introduce virConnectGetHypervisorCPUNames public API
>>    remote: Implement virConnectGetHypervisorCPUNames
>>    virsh: Introduce new hypervisor-cpu-models command
>>    qemu_driver: Implement qemuConnectGetHypervisorCPUNames
>>
>>   docs/manpages/virsh.rst        | 20 ++++++++++
>>   include/libvirt/libvirt-host.h |  6 +++
>>   src/driver-hypervisor.h        |  9 +++++
>>   src/libvirt-host.c             | 54 ++++++++++++++++++++++++++
>>   src/libvirt_public.syms        |  5 +++
>>   src/qemu/qemu_driver.c         | 62 ++++++++++++++++++++++++++++++
>>   src/remote/remote_driver.c     |  1 +
>>   src/remote/remote_protocol.x   | 20 +++++++++-
>>   src/remote_protocol-structs    | 11 ++++++
>>   tools/virsh-host.c             | 70
>> ++++++++++++++++++++++++++++++++++
>>   10 files changed, 257 insertions(+), 1 deletion(-)
>>
>> --
>> 2.39.0
>>
> 
> Have a look at
> https://listman.redhat.com/archives/libvir-list/2022-June/232626.html
> 
> You might be interested in the discussion we had there, about a very
> similar patch set.
> 
> - Tim
> 

Forgive my ignorance here -- what was the result of the discussion from 
your patch set? The archives are not showing any responses on my end, 
but from what I see it accomplishes very much what we'd like to see from 
this command.

-- Collin
Re: [PATCH v1 0/4] Introduce virsh hypervisor-cpu-models
Posted by Collin Walling 1 year, 1 month ago
On 3/22/23 2:11 PM, Collin Walling wrote:
> On 3/22/23 1:00 PM, Tim Wiederhake wrote:
>> On Wed, 2023-03-22 at 11:39 -0400, Collin Walling wrote:
>>> Allows for the query of hypervisor-known CPU models via the simple
>>> command: virsh hypervisor-cpu-models. For the QEMU driver, the models
>>> are queried via the capabilities file. Each model is printed to the
>>> terminal on its own line similar to the cpu-models command, and there
>>> is no order to the listing.
>>>
>>> The models "qemu", "host", and "max" have been excluded from this
>>> list
>>> since they are not architecture specific. The code can be easily
>>> modified
>>> to include them if desired.
>>>
>>> Collin Walling (4):
>>>    Introduce virConnectGetHypervisorCPUNames public API
>>>    remote: Implement virConnectGetHypervisorCPUNames
>>>    virsh: Introduce new hypervisor-cpu-models command
>>>    qemu_driver: Implement qemuConnectGetHypervisorCPUNames
>>>
>>>   docs/manpages/virsh.rst        | 20 ++++++++++
>>>   include/libvirt/libvirt-host.h |  6 +++
>>>   src/driver-hypervisor.h        |  9 +++++
>>>   src/libvirt-host.c             | 54 ++++++++++++++++++++++++++
>>>   src/libvirt_public.syms        |  5 +++
>>>   src/qemu/qemu_driver.c         | 62 ++++++++++++++++++++++++++++++
>>>   src/remote/remote_driver.c     |  1 +
>>>   src/remote/remote_protocol.x   | 20 +++++++++-
>>>   src/remote_protocol-structs    | 11 ++++++
>>>   tools/virsh-host.c             | 70
>>> ++++++++++++++++++++++++++++++++++
>>>   10 files changed, 257 insertions(+), 1 deletion(-)
>>>
>>> -- 
>>> 2.39.0
>>>
>>
>> Have a look at
>> https://listman.redhat.com/archives/libvir-list/2022-June/232626.html
>>
>> You might be interested in the discussion we had there, about a very
>> similar patch set.
>>
>> - Tim
>>
> 
> Forgive my ignorance here -- what was the result of the discussion from 
> your patch set? The archives are not showing any responses on my end, 
> but from what I see it accomplishes very much what we'd like to see from 
> this command.
> 
> -- Collin
> 

Polite ping. I know it's only been a few days, but I'd like to get 
involved with the proposed patches from earlier last year and want to 
make sure there isn't anything I may be missing from the discussion.

And if I may ask: what is the proper etiquette for reviving an older 
thread on the mailing list?

Thanks,
-- Collin