[PATCH] docs: fix passt example

Laine Stump posted 1 patch 1 year, 3 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20230118141224.826245-1-laine@redhat.com
docs/formatdomain.rst | 20 ++++++++++----------
1 file changed, 10 insertions(+), 10 deletions(-)
[PATCH] docs: fix passt example
Posted by Laine Stump 1 year, 3 months ago
Somehow I neglected to fully update the example for the interface
passt backend when the design changed during development. This fixes
the example to reflect what is in the code.

Signed-off-by: Laine Stump <laine@redhat.com>
---
 docs/formatdomain.rst | 20 ++++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)

diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst
index f76c7c3d81..9c6843e082 100644
--- a/docs/formatdomain.rst
+++ b/docs/formatdomain.rst
@@ -4858,18 +4858,18 @@ ports **with the exception of some subset**.
        <backend type='passt' logFile='/var/log/passt.log'/>
        <mac address="00:11:22:33:44:55"/>
        <source dev='eth0'/>
-       <ip family='ipv4' address='172.17.2.0' prefix='24'/>
-       <ip family='ipv6' address='2001:db8:ac10:fd01::' prefix='64'/>
-       <portForward proto='tcp' address='2001:db8:ac10:fd01::1:10' start='2022'>
-         <port start='22'/>
+       <ip family='ipv4' address='172.17.2.4' prefix='24'/>
+       <ip family='ipv6' address='2001:db8:ac10:fd01::20'/>
+       <portForward proto='tcp'>
+         <range start='2022' to='22'/>
        </portForward>
-       <portForward proto='udp' address='1.2.3.4' start='5000' end='5020'>
-         <port start='6000' end='6020'/>
+       <portForward proto='udp' address='1.2.3.4'>
+         <range start='5000' end='5020' to='6000'/>
+         <range start='5010' end='5015' exclude='yes'/>
        </portForward>
-       <portForward exclude='yes' proto='tcp' address='1.2.3.4' start='5010' end='5015'/>
-       <portForward proto='tcp' start='80'/>
-       <portForward proto='tcp' start='443'>
-         <port start='344'/>
+       <portForward proto='tcp' address='2001:db8:ac10:fd01::1:10'>>
+         <range start='80'/>
+         <range start='443' to='344'/>
        </portForward>
      </interface>
    </devices>
-- 
2.38.1
Re: [PATCH] docs: fix passt example
Posted by Ján Tomko 1 year, 3 months ago
On a Wednesday in 2023, Laine Stump wrote:
>Somehow I neglected to fully update the example for the interface
>passt backend when the design changed during development. This fixes
>the example to reflect what is in the code.
>
>Signed-off-by: Laine Stump <laine@redhat.com>
>---
> docs/formatdomain.rst | 20 ++++++++++----------
> 1 file changed, 10 insertions(+), 10 deletions(-)
>
>diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst
>index f76c7c3d81..9c6843e082 100644
>--- a/docs/formatdomain.rst
>+++ b/docs/formatdomain.rst
>@@ -4858,18 +4858,18 @@ ports **with the exception of some subset**.
>        <backend type='passt' logFile='/var/log/passt.log'/>
>        <mac address="00:11:22:33:44:55"/>
>        <source dev='eth0'/>
>-       <ip family='ipv4' address='172.17.2.0' prefix='24'/>
>-       <ip family='ipv6' address='2001:db8:ac10:fd01::' prefix='64'/>
>-       <portForward proto='tcp' address='2001:db8:ac10:fd01::1:10' start='2022'>
>-         <port start='22'/>
>+       <ip family='ipv4' address='172.17.2.4' prefix='24'/>
>+       <ip family='ipv6' address='2001:db8:ac10:fd01::20'/>
>+       <portForward proto='tcp'>
>+         <range start='2022' to='22'/>
>        </portForward>
>-       <portForward proto='udp' address='1.2.3.4' start='5000' end='5020'>
>-         <port start='6000' end='6020'/>
>+       <portForward proto='udp' address='1.2.3.4'>
>+         <range start='5000' end='5020' to='6000'/>
>+         <range start='5010' end='5015' exclude='yes'/>
>        </portForward>
>-       <portForward exclude='yes' proto='tcp' address='1.2.3.4' start='5010' end='5015'/>
>-       <portForward proto='tcp' start='80'/>
>-       <portForward proto='tcp' start='443'>
>-         <port start='344'/>
>+       <portForward proto='tcp' address='2001:db8:ac10:fd01::1:10'>>

There's a double '>' at the end of this line ^^

>+         <range start='80'/>
>+         <range start='443' to='344'/>
>        </portForward>

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano