Remove <backend upstream='blah'/> per danpb's request, and a couple small cleanups

[libvirt PATCH 0/3] Remove <backend upstream='blah'/> per danpb's request, and a couple small cleanups

Laine Stump posted 3 patches 1 year, 3 months ago

Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20230113044218.719810-1-laine@redhat.com

docs/formatdomain.rst                      |  9 +++---
src/conf/domain_conf.c                     | 15 ++++++++--
src/conf/domain_conf.h                     |  1 +
src/conf/schemas/domaincommon.rng          | 13 +++++----
src/qemu/qemu_passt.c                      |  5 ++--
tests/qemuxml2argvdata/net-user-passt.args | 34 ----------------------
tests/qemuxml2argvdata/net-user-passt.xml  |  3 +-
7 files changed, 31 insertions(+), 49 deletions(-)
delete mode 100644 tests/qemuxml2argvdata/net-user-passt.args

Expand all Fold all

[libvirt PATCH 0/3] Remove <backend upstream='blah'/> per danpb's request, and a couple small cleanups

Posted by Laine Stump 1 year, 3 months ago

The first patch implements what danpb suggested yesterday - using
<source dev='blah'/> instead of <backend upstream='blah'/> to populate
the passt --interface option. The other two are small cleanups I
noticed while making the changes in patch 1.

jdenemar: feel free to push once they've been reviewed, rather than
waiting for me to get up, so that you can get RC2 tagged.

Laine Stump (3):
  conf: remove <backend upstream='xxx'/> attribute
  qemu: remove commented-out option in passt qemu commandline setup
  tests: remove unused qemu .args file

 docs/formatdomain.rst                      |  9 +++---
 src/conf/domain_conf.c                     | 15 ++++++++--
 src/conf/domain_conf.h                     |  1 +
 src/conf/schemas/domaincommon.rng          | 13 +++++----
 src/qemu/qemu_passt.c                      |  5 ++--
 tests/qemuxml2argvdata/net-user-passt.args | 34 ----------------------
 tests/qemuxml2argvdata/net-user-passt.xml  |  3 +-
 7 files changed, 31 insertions(+), 49 deletions(-)
 delete mode 100644 tests/qemuxml2argvdata/net-user-passt.args

-- 
2.38.1

Re: [libvirt PATCH 0/3] Remove <backend upstream='blah'/> per danpb's request, and a couple small cleanups

Posted by Jiri Denemark 1 year, 3 months ago

On Thu, Jan 12, 2023 at 23:42:15 -0500, Laine Stump wrote:
> The first patch implements what danpb suggested yesterday - using
> <source dev='blah'/> instead of <backend upstream='blah'/> to populate
> the passt --interface option. The other two are small cleanups I
> noticed while making the changes in patch 1.
> 
> jdenemar: feel free to push once they've been reviewed, rather than
> waiting for me to get up, so that you can get RC2 tagged.
> 
> Laine Stump (3):
>   conf: remove <backend upstream='xxx'/> attribute
>   qemu: remove commented-out option in passt qemu commandline setup
>   tests: remove unused qemu .args file
> 
>  docs/formatdomain.rst                      |  9 +++---
>  src/conf/domain_conf.c                     | 15 ++++++++--
>  src/conf/domain_conf.h                     |  1 +
>  src/conf/schemas/domaincommon.rng          | 13 +++++----
>  src/qemu/qemu_passt.c                      |  5 ++--
>  tests/qemuxml2argvdata/net-user-passt.args | 34 ----------------------
>  tests/qemuxml2argvdata/net-user-passt.xml  |  3 +-
>  7 files changed, 31 insertions(+), 49 deletions(-)
>  delete mode 100644 tests/qemuxml2argvdata/net-user-passt.args

I fixed the two small issues in 1/3 and pushed this series. Thanks.

Reviewed-by: Jiri Denemark <jdenemar@redhat.com>