[libvirt PATCH 0/9] src: misc cleanups related to remote protocol/client

Daniel P. Berrangé posted 9 patches 1 year, 3 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20230110135423.2576907-1-berrange@redhat.com
src/admin/admin_remote.c       |   92 +--
src/logging/log_protocol.x     |    2 -
src/lxc/lxc_monitor_protocol.x |    6 +-
src/remote/remote_driver.c     | 1280 +++++++++-----------------------
src/rpc/gendispatch.pl         |   18 +-
5 files changed, 397 insertions(+), 1001 deletions(-)
[libvirt PATCH 0/9] src: misc cleanups related to remote protocol/client
Posted by Daniel P. Berrangé 1 year, 3 months ago
Just before xmas I did some work on an rpcgen replacement so
we can use a non-sucky API instead of xdr_*. This short series
has some general cleanups I found useful. The rpcgen code will
come later.

While this is all non-functional changes, I'm NOT proposing
it for 9.0, it can safely wait as it isn't fixing any real
bugs (that I've realized).

Daniel P. Berrangé (9):
  remote: remove redundant initialization of args variable
  lxc: fix XDR protocol compliance
  logging: remove redundant XDR typedef
  rpc: use VIR_LOCK_GUARD in remote client code
  remote: use VIR_LOCK_GUARD in client code
  admin: use VIR_LOCK_GUARD in client code
  rpc: use struct zero initializer instead of memset
  remote: use struct zero initializer instead of memset
  admin: use struct zero initializer instead of memset

 src/admin/admin_remote.c       |   92 +--
 src/logging/log_protocol.x     |    2 -
 src/lxc/lxc_monitor_protocol.x |    6 +-
 src/remote/remote_driver.c     | 1280 +++++++++-----------------------
 src/rpc/gendispatch.pl         |   18 +-
 5 files changed, 397 insertions(+), 1001 deletions(-)

-- 
2.38.1

Re: [libvirt PATCH 0/9] src: misc cleanups related to remote protocol/client
Posted by Ján Tomko 1 year, 3 months ago
On a Tuesday in 2023, Daniel P. Berrangé wrote:
>Just before xmas I did some work on an rpcgen replacement so
>we can use a non-sucky API instead of xdr_*. This short series
>has some general cleanups I found useful. The rpcgen code will
>come later.
>
>While this is all non-functional changes, I'm NOT proposing
>it for 9.0, it can safely wait as it isn't fixing any real
>bugs (that I've realized).
>
>Daniel P. Berrangé (9):
>  remote: remove redundant initialization of args variable
>  lxc: fix XDR protocol compliance
>  logging: remove redundant XDR typedef
>  rpc: use VIR_LOCK_GUARD in remote client code
>  remote: use VIR_LOCK_GUARD in client code
>  admin: use VIR_LOCK_GUARD in client code
>  rpc: use struct zero initializer instead of memset
>  remote: use struct zero initializer instead of memset
>  admin: use struct zero initializer instead of memset
>
> src/admin/admin_remote.c       |   92 +--
> src/logging/log_protocol.x     |    2 -
> src/lxc/lxc_monitor_protocol.x |    6 +-
> src/remote/remote_driver.c     | 1280 +++++++++-----------------------
> src/rpc/gendispatch.pl         |   18 +-
> 5 files changed, 397 insertions(+), 1001 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano