[v2] define g_autoptr for virNWFilterDef and virNWFilterRuleDef

[PATCH V2 0/2] define g_autoptr for virNWFilterDef and virNWFilterRuleDef

Posted by Jiang Jiacheng 1 year, 3 months ago

Define and use g_autoptr() for virNWFilterDef and virNWFilterRuleDef,
and remove unnecessary label/variable.

Those patches are followup with:
https://gitlab.com/libvirt/libvirt/-/commit/a9027d447be789cd11c0aa18ceb83ed79f677f86

diff to v1:
* drop two changes that may cause memory leaks in
  'nwfilterDefineXMLFlags' and 'virNWFilterObjListLoadConfig'

Jiang Jiacheng (2):
  conf: define g_autoptr for virNWFilterDef and virNWFilterRuleDef
  src/tests: use g_autoptr for virNWFilterDef and virNWFilterRuleDef

 src/conf/nwfilter_conf.c    | 44 +++++++++++++++----------------------
 src/conf/nwfilter_conf.h    |  2 ++
 tests/nwfilterxml2xmltest.c | 22 +++++++------------
 3 files changed, 28 insertions(+), 40 deletions(-)

-- 
2.33.0

Re: [PATCH V2 0/2] define g_autoptr for virNWFilterDef and virNWFilterRuleDef

Posted by Jiang Jiacheng 1 year, 3 months ago

Ping...

在 2023/1/10 19:29, Jiang Jiacheng 写道:
> Define and use g_autoptr() for virNWFilterDef and virNWFilterRuleDef,
> and remove unnecessary label/variable.
> 
> Those patches are followup with:
> https://gitlab.com/libvirt/libvirt/-/commit/a9027d447be789cd11c0aa18ceb83ed79f677f86
> 
> diff to v1:
> * drop two changes that may cause memory leaks in
>   'nwfilterDefineXMLFlags' and 'virNWFilterObjListLoadConfig'
> 
> Jiang Jiacheng (2):
>   conf: define g_autoptr for virNWFilterDef and virNWFilterRuleDef
>   src/tests: use g_autoptr for virNWFilterDef and virNWFilterRuleDef
> 
>  src/conf/nwfilter_conf.c    | 44 +++++++++++++++----------------------
>  src/conf/nwfilter_conf.h    |  2 ++
>  tests/nwfilterxml2xmltest.c | 22 +++++++------------
>  3 files changed, 28 insertions(+), 40 deletions(-)
>

Re: [PATCH V2 0/2] define g_autoptr for virNWFilterDef and virNWFilterRuleDef

Posted by Michal Prívozník 1 year, 3 months ago

On 1/20/23 07:33, Jiang Jiacheng wrote:
> Ping...
> 

These were merged as:

commit e5b065b40e555dd2c39c2af320d95b21547e7070
Author:     Jiang Jiacheng <jiangjiacheng@huawei.com>
AuthorDate: Tue Jan 10 19:29:26 2023 +0800
Commit:     Ján Tomko <jtomko@redhat.com>
CommitDate: Fri Jan 20 22:09:34 2023 +0100

    src/tests: use g_autoptr for virNWFilterDef and virNWFilterRuleDef

    Use g_autoptr() for virNWFilterDef and virNWFilterRuleDef and remove
    unnecessary label.

    Signed-off-by: Jiang Jiacheng <jiangjiacheng@huawei.com>
    Reviewed-by: Ján Tomko <jtomko@redhat.com>

commit 94432a486f089a3c00cb0b1c35757adea0571aa1
Author:     Jiang Jiacheng <jiangjiacheng@huawei.com>
AuthorDate: Tue Jan 10 19:29:25 2023 +0800
Commit:     Ján Tomko <jtomko@redhat.com>
CommitDate: Fri Jan 20 22:09:34 2023 +0100

    conf: define g_autoptr for virNWFilterDef and virNWFilterRuleDef

    Signed-off-by: Jiang Jiacheng <jiangjiacheng@huawei.com>
    Reviewed-by: Ján Tomko <jtomko@redhat.com>

Michal

Re: [PATCH V2 0/2] define g_autoptr for virNWFilterDef and virNWFilterRuleDef

Posted by Ján Tomko 1 year, 3 months ago

On a Tuesday in 2023, Jiang Jiacheng wrote:
>Define and use g_autoptr() for virNWFilterDef and virNWFilterRuleDef,
>and remove unnecessary label/variable.
>
>Those patches are followup with:
>https://gitlab.com/libvirt/libvirt/-/commit/a9027d447be789cd11c0aa18ceb83ed79f677f86
>
>diff to v1:
>* drop two changes that may cause memory leaks in
>  'nwfilterDefineXMLFlags' and 'virNWFilterObjListLoadConfig'
>
>Jiang Jiacheng (2):
>  conf: define g_autoptr for virNWFilterDef and virNWFilterRuleDef
>  src/tests: use g_autoptr for virNWFilterDef and virNWFilterRuleDef
>
> src/conf/nwfilter_conf.c    | 44 +++++++++++++++----------------------
> src/conf/nwfilter_conf.h    |  2 ++
> tests/nwfilterxml2xmltest.c | 22 +++++++------------
> 3 files changed, 28 insertions(+), 40 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano