[PATCH 0/9] use g_autofree

Jiang Jiacheng posted 9 patches 1 year, 3 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20230105122655.3413625-1-jiangjiacheng@huawei.com
There is a newer version of this series
src/conf/domain_audit.c                | 121 ++++++++-----------------
src/conf/node_device_util.c            |  49 ++++------
src/conf/nwfilter_conf.c               |  51 ++++-------
src/conf/virnetworkobj.c               |  85 ++++++-----------
src/conf/virnetworkportdef.c           |  12 +--
src/conf/virnwfilterbindingobj.c       |  22 ++---
src/conf/virnwfilterobj.c              |  14 +--
src/conf/virstorageobj.c               |  23 ++---
src/interface/interface_backend_udev.c |  22 ++---
src/locking/lock_driver_lockd.c        |  36 +++-----
src/locking/lock_driver_sanlock.c      |  46 ++++------
src/remote/remote_driver.c             |  22 ++---
src/rpc/virnetclientprogram.c          |   6 +-
src/rpc/virnettlscontext.c             |  16 +---
src/security/security_apparmor.c       |  91 +++++++------------
src/util/virconf.c                     |  27 ++----
src/vmware/vmware_conf.c               |  28 ++----
src/vz/vz_utils.c                      |  18 ++--
18 files changed, 237 insertions(+), 452 deletions(-)
[PATCH 0/9] use g_autofree
Posted by Jiang Jiacheng 1 year, 3 months ago
Use g_autofree more often and remove unnecessary cleanup/error
labels.

Jiang Jiacheng (9):
  conf: use g_autofree and remove unnecessary label
  interface: use g_autofree and remove unnecessary label
  locking: use g_autofree and remove unnecessary label
  remote: use g_autofree and remove unnecessary label
  rpc: use g_autofree and remove unnecessary label
  security: use g_autofree and remove unnecessary label
  util: use g_autofree and remove unnecessary label
  vmware: use g_autofree and remove unnecessary label
  vz: use g_autofree and remove unnecessary label

 src/conf/domain_audit.c                | 121 ++++++++-----------------
 src/conf/node_device_util.c            |  49 ++++------
 src/conf/nwfilter_conf.c               |  51 ++++-------
 src/conf/virnetworkobj.c               |  85 ++++++-----------
 src/conf/virnetworkportdef.c           |  12 +--
 src/conf/virnwfilterbindingobj.c       |  22 ++---
 src/conf/virnwfilterobj.c              |  14 +--
 src/conf/virstorageobj.c               |  23 ++---
 src/interface/interface_backend_udev.c |  22 ++---
 src/locking/lock_driver_lockd.c        |  36 +++-----
 src/locking/lock_driver_sanlock.c      |  46 ++++------
 src/remote/remote_driver.c             |  22 ++---
 src/rpc/virnetclientprogram.c          |   6 +-
 src/rpc/virnettlscontext.c             |  16 +---
 src/security/security_apparmor.c       |  91 +++++++------------
 src/util/virconf.c                     |  27 ++----
 src/vmware/vmware_conf.c               |  28 ++----
 src/vz/vz_utils.c                      |  18 ++--
 18 files changed, 237 insertions(+), 452 deletions(-)

-- 
2.33.0
Re: [PATCH 0/9] use g_autofree
Posted by Jonathon Jongsma 1 year, 3 months ago
On 1/5/23 6:26 AM, Jiang Jiacheng wrote:
> Use g_autofree more often and remove unnecessary cleanup/error
> labels.
> 
> Jiang Jiacheng (9):
>    conf: use g_autofree and remove unnecessary label
>    interface: use g_autofree and remove unnecessary label
>    locking: use g_autofree and remove unnecessary label
>    remote: use g_autofree and remove unnecessary label
>    rpc: use g_autofree and remove unnecessary label
>    security: use g_autofree and remove unnecessary label
>    util: use g_autofree and remove unnecessary label
>    vmware: use g_autofree and remove unnecessary label
>    vz: use g_autofree and remove unnecessary label
> 
>   src/conf/domain_audit.c                | 121 ++++++++-----------------
>   src/conf/node_device_util.c            |  49 ++++------
>   src/conf/nwfilter_conf.c               |  51 ++++-------
>   src/conf/virnetworkobj.c               |  85 ++++++-----------
>   src/conf/virnetworkportdef.c           |  12 +--
>   src/conf/virnwfilterbindingobj.c       |  22 ++---
>   src/conf/virnwfilterobj.c              |  14 +--
>   src/conf/virstorageobj.c               |  23 ++---
>   src/interface/interface_backend_udev.c |  22 ++---
>   src/locking/lock_driver_lockd.c        |  36 +++-----
>   src/locking/lock_driver_sanlock.c      |  46 ++++------
>   src/remote/remote_driver.c             |  22 ++---
>   src/rpc/virnetclientprogram.c          |   6 +-
>   src/rpc/virnettlscontext.c             |  16 +---
>   src/security/security_apparmor.c       |  91 +++++++------------
>   src/util/virconf.c                     |  27 ++----
>   src/vmware/vmware_conf.c               |  28 ++----
>   src/vz/vz_utils.c                      |  18 ++--
>   18 files changed, 237 insertions(+), 452 deletions(-)
> 


noted a couple minor comments in separate emails

Reviewed-by: Jonathon Jongsma <jjongsma@redhat.com>