From nobody Sat May 18 07:31:13 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=quarantine dis=quarantine) header.from=huawei.com ARC-Seal: i=1; a=rsa-sha256; t=1672919850; cv=none; d=zohomail.com; s=zohoarc; b=WpAKTdWkRbd0tMYSGIhR1hn4eGIXXhjF5/Y9eEOVI5Tk4aUuhCvkwXCgdIU2TS/BUE59eE921GvS6siLXIGwMmeeSUbqVcZtpV7KKsqbW/elSoNd6Mtsi26GgJj3jcMAiJEdc6QlRY8fgyxZ+mLZ+47Ho7OLlhUSqKrOfWFUxv8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1672919850; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=XuyT6e0xLQUyccS6CvRtljgLI+s9QRDOyeW96AsZWLs=; b=bdT3v/qIZvQXhaAZ/wljq7pHLCF+/Sw930GBovU6eLb/BsZi2P8Y5c8M1hCfqbyM/JIduDkbuyogED1v4ukepzWCUP1hMmlBpNnQ19eOeXpHm4FJoTdTFQRJ2y+ZCJyasELHT3yxEM/um0sM4EIfH0V90DgeNYvZ/ft9vlpM4cc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail header.from= (p=quarantine dis=quarantine) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1672919850838730.5958205393468; Thu, 5 Jan 2023 03:57:30 -0800 (PST) Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-28-pPfFNiH8MCq9p-bKhDXS_w-1; Thu, 05 Jan 2023 06:57:27 -0500 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 66F401C06EC0; Thu, 5 Jan 2023 11:57:25 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 36421140EBF6; Thu, 5 Jan 2023 11:57:25 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 092481946589; Thu, 5 Jan 2023 11:57:25 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 840381946586 for ; Thu, 5 Jan 2023 11:57:23 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 75DC31121318; Thu, 5 Jan 2023 11:57:23 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast05.extmail.prod.ext.rdu2.redhat.com [10.11.55.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 6EF6C1121315 for ; Thu, 5 Jan 2023 11:57:23 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-2.mimecast.com [205.139.110.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 54D198828C0 for ; Thu, 5 Jan 2023 11:57:23 +0000 (UTC) Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-484-Qyhe5lQyOnO3lJnRBLF32A-1; Thu, 05 Jan 2023 06:57:21 -0500 Received: from dggpeml500022.china.huawei.com (unknown [172.30.72.55]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4NnlFx4yQszqTfy for ; Thu, 5 Jan 2023 19:52:37 +0800 (CST) Received: from localhost.localdomain (10.175.124.27) by dggpeml500022.china.huawei.com (7.185.36.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Thu, 5 Jan 2023 19:57:17 +0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1672919849; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=XuyT6e0xLQUyccS6CvRtljgLI+s9QRDOyeW96AsZWLs=; b=XKCYTwmdo0gzpZHoV3TUG1pgDndHx5BJReL7wT/zGVSDAQdA3Xf2TSTM8zR5wvYHwDJAHz XdamoqIz6ASgZjkzPsEsW6IefKaSJTeyksH4h+iiK4K+KVj/VX8HWuYlR890mkfRx6kD8t myyyqAsUbIde7N4T7dmdrRinpsDX/o8= X-MC-Unique: pPfFNiH8MCq9p-bKhDXS_w-1 X-Original-To: libvir-list@listman.corp.redhat.com X-MC-Unique: Qyhe5lQyOnO3lJnRBLF32A-1 From: Jiang Jiacheng To: Subject: [PATCH 1/3] qemu: fix a misspelling in log Date: Thu, 5 Jan 2023 19:51:06 +0800 Message-ID: <20230105115108.3231970-2-jiangjiacheng@huawei.com> In-Reply-To: <20230105115108.3231970-1-jiangjiacheng@huawei.com> References: <20230105115108.3231970-1-jiangjiacheng@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.175.124.27] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To dggpeml500022.china.huawei.com (7.185.36.66) X-CFilter-Loop: Reflected X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: yubihong@huawei.com, zhengchuan@huawei.com, linyilu@huawei.com, jiangjiacheng@huawei.com, xiexiangyou@huawei.com Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.7 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1672919851517100001 Content-Type: text/plain; charset="utf-8" Signed-off-by: Jiang Jiacheng Reviewed-by: Michal Privoznik --- src/qemu/qemu_process.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index b6adcf2f2a..04d14e7eb0 100644 --- a/src/qemu/qemu_process.c +++ b/src/qemu/qemu_process.c @@ -7590,7 +7590,7 @@ qemuProcessLaunch(virConnectPtr conn, g_autofree int *nicindexes =3D NULL; unsigned long long maxMemLock =3D 0; =20 - VIR_DEBUG("conn=3D%p driver=3D%p vm=3D%p name=3D%s if=3D%d asyncJob=3D= %d " + VIR_DEBUG("conn=3D%p driver=3D%p vm=3D%p name=3D%s id=3D%d asyncJob=3D= %d " "incoming.uri=3D%s " "incoming.fd=3D%d incoming.path=3D%s " "snapshot=3D%p vmop=3D%d flags=3D0x%x", --=20 2.33.0 From nobody Sat May 18 07:31:13 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=quarantine dis=quarantine) header.from=huawei.com ARC-Seal: i=1; a=rsa-sha256; t=1672919884; cv=none; d=zohomail.com; s=zohoarc; b=JNStBWoThSSlMSp+PQzpBdO1KYedJzLeEJJicultR0y5owL9T81wO1ZWQS3j6E67i6KlAECHnZCDVV4Xf8HfZWAzK8MGyaEjdLfoFrCYFDm6HlPasryOn5bjGRNwkY2hbozyOQeUIUEsE2+UloawDyi8YAiSqXKW/NoA5b8toeM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1672919884; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=z0p2ByjqlS6MO2R4yLlQj/a2I2SMuA0sp2BY1LjziL8=; b=d4ymPfnKEAtgL1AjLxDKkwcQIF4DlQhXVSm63EOzjnAfaP6UAX2e3qSFsmX9wzKwzzyv+bORaHtKlTtB4a6JAWqC5ri0iXrLcohBqc7epYPPmBpwwXRorLZzCrtaSAyIrzU2QNGoEyjq2xhoQvZd1oJ38jkECnMMpcROVCFme3c= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail header.from= (p=quarantine dis=quarantine) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.zohomail.com with SMTPS id 167291988410862.80249868349347; Thu, 5 Jan 2023 03:58:04 -0800 (PST) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-577-CcFVJkH4OOaiLSJiZaBGag-1; Thu, 05 Jan 2023 06:57:28 -0500 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 5B2118030DC; Thu, 5 Jan 2023 11:57:26 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3E2E414171B6; Thu, 5 Jan 2023 11:57:26 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 6E0F81946A76; Thu, 5 Jan 2023 11:57:25 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 421F91946589 for ; Thu, 5 Jan 2023 11:57:24 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 263262166B31; Thu, 5 Jan 2023 11:57:24 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast09.extmail.prod.ext.rdu2.redhat.com [10.11.55.25]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1F8642166B30 for ; Thu, 5 Jan 2023 11:57:23 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id C941B2801E49 for ; Thu, 5 Jan 2023 11:57:23 +0000 (UTC) Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-227-GZfaGARJM02I549XC7pNFg-1; Thu, 05 Jan 2023 06:57:21 -0500 Received: from dggpeml500022.china.huawei.com (unknown [172.30.72.53]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4NnlGj2RltzJpXl for ; Thu, 5 Jan 2023 19:53:17 +0800 (CST) Received: from localhost.localdomain (10.175.124.27) by dggpeml500022.china.huawei.com (7.185.36.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Thu, 5 Jan 2023 19:57:18 +0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1672919883; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=z0p2ByjqlS6MO2R4yLlQj/a2I2SMuA0sp2BY1LjziL8=; b=ApkWAEPkZICX7PCOxGE1sPJ8PDS+siGe1SlfyXKbjrcCJagfmY+cr8YJ4JcWJV9sWsYjpU pcGvW8b51zOIjfrYWaqiR/s7RvS7zbpzCqy0dXEs+jDJwlHEdVZEJEenNd+MS2ePKUKY0Y oI3EJvZF14w9Fnnmet8ShXRhbbwd1qk= X-MC-Unique: CcFVJkH4OOaiLSJiZaBGag-1 X-Original-To: libvir-list@listman.corp.redhat.com X-MC-Unique: GZfaGARJM02I549XC7pNFg-1 From: Jiang Jiacheng To: Subject: [PATCH 2/3] remote: fix misspelling in the documation of 'daemonCreateClientStream' Date: Thu, 5 Jan 2023 19:51:07 +0800 Message-ID: <20230105115108.3231970-3-jiangjiacheng@huawei.com> In-Reply-To: <20230105115108.3231970-1-jiangjiacheng@huawei.com> References: <20230105115108.3231970-1-jiangjiacheng@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.175.124.27] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To dggpeml500022.china.huawei.com (7.185.36.66) X-CFilter-Loop: Reflected X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: yubihong@huawei.com, zhengchuan@huawei.com, linyilu@huawei.com, jiangjiacheng@huawei.com, xiexiangyou@huawei.com Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.7 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1672919885367100001 Content-Type: text/plain; charset="utf-8" Fix a misspelling in the documation of 'daemonCreateClientStream'. Signed-off-by: Jiang Jiacheng Reviewed-by: Michal Privoznik --- src/remote/remote_daemon_stream.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/remote/remote_daemon_stream.c b/src/remote/remote_daemon_s= tream.c index 912f3f9f94..8873af51da 100644 --- a/src/remote/remote_daemon_stream.c +++ b/src/remote/remote_daemon_stream.c @@ -337,10 +337,10 @@ daemonStreamFilter(virNetServerClient *client, =20 =20 /* - * @conn: a connection object to associate the stream with + * @client: a locked client object * @header: the method call to associate with the stream * - * Creates a new stream for this conn + * Creates a new stream for this client * * Returns a new stream object, or NULL upon OOM */ --=20 2.33.0 From nobody Sat May 18 07:31:13 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=quarantine dis=quarantine) header.from=huawei.com ARC-Seal: i=1; a=rsa-sha256; t=1672919888; cv=none; d=zohomail.com; s=zohoarc; b=N6zXu7MmP1pYDl/7TlQSm8mia6U8ANwLpmsB9ZQ9eWTOpfTxnIZKYAkao94+cqWwM9hOhgLbTG1srM1+qW7IjUVrDPYGDYWUA4IFRWxR4JxSSdrgXu/sNaV6SU4ZsA7IZnHvCZ1Yidt4g6tGKWahRC0XlVa7WR4pYHYVd/QYsys= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1672919888; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=2fvalxY8Z2vTur7dyNxOyHprtj3INRkdIpRknUG5Qas=; b=nCyOeDJ+q3hS3Rv8Y6EVsJJmy+G4QZ2gYJm9ZGVeuXIZeDgN0oEVuZqsDT4KCJ7x26iNUQzD+Sj+mQRxjRPTRZDGDFXSaWrQ1MT7YLRsdvTUyGYWKzdoGbijgeSoqh5UG3Fdq/JkLLEmheQmEMZHv2rfQMSIxBUIjERBywWUAJQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail header.from= (p=quarantine dis=quarantine) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1672919888922982.6536348084902; Thu, 5 Jan 2023 03:58:08 -0800 (PST) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-539-cUF3HSD6NSqhgIqM9AnMuA-1; Thu, 05 Jan 2023 06:57:29 -0500 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 0D7058828CE; Thu, 5 Jan 2023 11:57:26 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id EE09A2026D68; Thu, 5 Jan 2023 11:57:25 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 3268B19465B3; Thu, 5 Jan 2023 11:57:25 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 33C061946586 for ; Thu, 5 Jan 2023 11:57:24 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 19BB12026D68; Thu, 5 Jan 2023 11:57:24 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast04.extmail.prod.ext.rdu2.redhat.com [10.11.55.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 12D932026D4B for ; Thu, 5 Jan 2023 11:57:24 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-2.mimecast.com [205.139.110.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id E7C04101A521 for ; Thu, 5 Jan 2023 11:57:23 +0000 (UTC) Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-230-69MqyDZoNViXu8J3szvvrw-1; Thu, 05 Jan 2023 06:57:21 -0500 Received: from dggpeml500022.china.huawei.com (unknown [172.30.72.53]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4NnlKh026Zz16MNJ for ; Thu, 5 Jan 2023 19:55:52 +0800 (CST) Received: from localhost.localdomain (10.175.124.27) by dggpeml500022.china.huawei.com (7.185.36.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Thu, 5 Jan 2023 19:57:18 +0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1672919887; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=2fvalxY8Z2vTur7dyNxOyHprtj3INRkdIpRknUG5Qas=; b=I+ZBT7uPREy7C8aGEduvIrbBR+30wVyaiZSUitJyaifUUBmNngnf9UUnviGADhOhLmhW2h xz8weVCXfhm1v0GhUBGQsi83xl5CCjFGhilzY4lIJzAp3DCOXwARIc2E1MAeP32isc7cKT AaGjfeLT6sEbeHIGmB4E9ANOSQbuqE4= X-MC-Unique: cUF3HSD6NSqhgIqM9AnMuA-1 X-Original-To: libvir-list@listman.corp.redhat.com X-MC-Unique: 69MqyDZoNViXu8J3szvvrw-1 From: Jiang Jiacheng To: Subject: [PATCH 3/3] storage/util: replace unnecessary while loop by if Date: Thu, 5 Jan 2023 19:51:08 +0800 Message-ID: <20230105115108.3231970-4-jiangjiacheng@huawei.com> In-Reply-To: <20230105115108.3231970-1-jiangjiacheng@huawei.com> References: <20230105115108.3231970-1-jiangjiacheng@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.175.124.27] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To dggpeml500022.china.huawei.com (7.185.36.66) X-CFilter-Loop: Reflected X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: yubihong@huawei.com, zhengchuan@huawei.com, linyilu@huawei.com, jiangjiacheng@huawei.com, xiexiangyou@huawei.com Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1672919889388100001 Content-Type: text/plain; charset="utf-8" These while loops exit directly due to break after entering. Use if instead of these while loops. Signed-off-by: Jiang Jiacheng Reviewed-by: Michal Privoznik --- src/storage/storage_util.c | 4 +--- src/util/virutil.c | 6 +----- 2 files changed, 2 insertions(+), 8 deletions(-) diff --git a/src/storage/storage_util.c b/src/storage/storage_util.c index 3871718b09..520fdd03d0 100644 --- a/src/storage/storage_util.c +++ b/src/storage/storage_util.c @@ -3784,12 +3784,10 @@ getNewStyleBlockDevice(const char *lun_path, if (virDirOpen(&block_dir, block_path) < 0) return -1; =20 - while ((direrr =3D virDirRead(block_dir, &block_dirent, block_path)) >= 0) { + if ((direrr =3D virDirRead(block_dir, &block_dirent, block_path)) > 0)= { *block_device =3D g_strdup(block_dirent->d_name); =20 VIR_DEBUG("Block device is '%s'", *block_device); - - break; } =20 if (direrr < 0) diff --git a/src/util/virutil.c b/src/util/virutil.c index 7e246d22d1..ddc66001cb 100644 --- a/src/util/virutil.c +++ b/src/util/virutil.c @@ -1432,15 +1432,11 @@ virHostHasIOMMU(void) { g_autoptr(DIR) iommuDir =3D NULL; struct dirent *iommuGroup =3D NULL; - int direrr; =20 if (virDirOpenQuiet(&iommuDir, "/sys/kernel/iommu_groups/") < 0) return false; =20 - while ((direrr =3D virDirRead(iommuDir, &iommuGroup, NULL)) > 0) - break; - - if (direrr < 0 || !iommuGroup) + if (virDirRead(iommuDir, &iommuGroup, NULL) < 0 || !iommuGroup) return false; =20 return true; --=20 2.33.0