From nobody Fri May 17 21:37:13 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1671190323; cv=none; d=zohomail.com; s=zohoarc; b=M5Ch89fCBLyUb7XUZTCOBcv8uLxvPVOkfA9bxPNU7OXDP5VBYWUCAKdQhUfjYMk99kAd+KhLFkmlAHVUnCTCYTjC3J0hgq2vDyoPpQCWRjsFpqGq3N9e6QSY0DtWu3QXBNQkX5cnDqzf/fyIo1I1IMD0xp2AjYrXHocwdp3Qy5s= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1671190323; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=OZQY1cbGTgb6aJq4nJ31VqYD0d7SkyMcwnHXTi/tH08=; b=gUrgcCzmeOTCuiGTKfCNhZgeu/qgYvcrL3F2FrDsAftfCrjosy/2GNEkPXxB93XcCnnPNZBmmBg28t1saDs82b/WKd+R5ZTA7tdCk2cIrbdtIEZ7xNngKEXgIZNu4WdR3gOZ6iI1KrjN4xGZS1l+2dX+/YoM4E2zJcA5vhCrlVA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1671190323511663.2118413477237; Fri, 16 Dec 2022 03:32:03 -0800 (PST) Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-58-17WXWm9MPkWPAFKJBxKEkw-1; Fri, 16 Dec 2022 06:31:58 -0500 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id C1346381459C; Fri, 16 Dec 2022 11:31:55 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id AD9E82026D35; Fri, 16 Dec 2022 11:31:55 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id AC6FE1947043; Fri, 16 Dec 2022 11:31:54 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 7B7F019466DF for ; Fri, 16 Dec 2022 11:31:53 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 6DB4E49BB6A; Fri, 16 Dec 2022 11:31:53 +0000 (UTC) Received: from virtlab420.virt.lab.eng.bos.redhat.com (virtlab420.virt.lab.eng.bos.redhat.com [10.19.152.148]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1DF97400F5A; Fri, 16 Dec 2022 11:31:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1671190322; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=OZQY1cbGTgb6aJq4nJ31VqYD0d7SkyMcwnHXTi/tH08=; b=OkjM3zqG4kbgfx/zKSSTy7u8s8EJ6yf5T6jVmBqehuLj7hU4kI/J8W47+hlN1bW4/AJMas wdM+oO0cAiJ7vDyP7agJ6qgnncGElKV/tqOpflpjAew3wCpHI03yKC8aeCupQEkujqYH+w 8M5UDLtakQur89v33id0uUYIzPUzMk8= X-MC-Unique: 17WXWm9MPkWPAFKJBxKEkw-1 X-Original-To: libvir-list@listman.corp.redhat.com From: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH v2 1/3] block: mention 'password-secret' option for -iscsi Date: Fri, 16 Dec 2022 06:31:50 -0500 Message-Id: <20221216113152.584460-2-berrange@redhat.com> In-Reply-To: <20221216113152.584460-1-berrange@redhat.com> References: <20221216113152.584460-1-berrange@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , qemu-block@nongnu.org, libvir-list@redhat.com, Peter Lieven , Markus Armbruster , Hanna Reitz , Gerd Hoffmann , Ronnie Sahlberg , Paolo Bonzini Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1671190324944100001 The 'password-secret' option was added commit b189346eb1784df95ed6fed610411dbf23d19e1f Author: Daniel P. Berrang=C3=A9 Date: Thu Jan 21 14:19:21 2016 +0000 iscsi: add support for getting CHAP password via QCryptoSecret API but was not mentioned in the command line docs Reviewed-by: Markus Armbruster Signed-off-by: Daniel P. Berrang=C3=A9 Reviewed-by: Fabiano Rosas --- qemu-options.hx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/qemu-options.hx b/qemu-options.hx index 7f99d15b23..58efb58072 100644 --- a/qemu-options.hx +++ b/qemu-options.hx @@ -1889,8 +1889,8 @@ SRST ERST =20 DEF("iscsi", HAS_ARG, QEMU_OPTION_iscsi, - "-iscsi [user=3Duser][,password=3Dpassword]\n" - " [,header-digest=3DCRC32C|CR32C-NONE|NONE-CRC32C|NONE\n" + "-iscsi [user=3Duser][,password=3Dpassword][,password-secret=3Dsecret-= id]\n" + " [,header-digest=3DCRC32C|CR32C-NONE|NONE-CRC32C|NONE]\n" " [,initiator-name=3Dinitiator-iqn][,id=3Dtarget-iqn]\n" " [,timeout=3Dtimeout]\n" " iSCSI session parameters\n", QEMU_ARCH_ALL) --=20 2.38.1 From nobody Fri May 17 21:37:13 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1671190323; cv=none; d=zohomail.com; s=zohoarc; b=SzReje1sHVtlZicYcBCCf6gSHVX5gx6ut0IY2Zftd7AXAejs9iNNg35wXPf+Kg7dHGAns4VZaQ1Jr98Pk3dd5PLeb6rL9I6/Z0Jxtxu2YIH4FF7bvc/cX70rIArsNEbIzxZeLfWpJ+zSjkp6/60o7Hoz4fsfRSDlvHUCfI8DSqw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1671190323; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=JNqgq8+y/S71KQ37T12RXSGvqKJhX6bEwe3vCtlFpPI=; b=JNvUnFSZXNXMVga0BiJwJeTQF3fZ+VS7xwYN4NcGvkTEDSZrGleC/Tn1ZDf25qy6XZU9MpsFnhCF+X0ygd6cIAX1XYxroCTIop1TMQJgSJSR/vSAx284QyMHBmyHFcWyBoK6RZpyHaST6LR4liFPn4Gwe7U/jZ08Axu2YGCVFfo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 167119032363448.22375233672642; Fri, 16 Dec 2022 03:32:03 -0800 (PST) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-643-c0gUi5QiOxeboUJJR-SjkA-1; Fri, 16 Dec 2022 06:31:57 -0500 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id CFA7E18A64E2; Fri, 16 Dec 2022 11:31:54 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 59A8051EF; Fri, 16 Dec 2022 11:31:54 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 404E51946A6B; Fri, 16 Dec 2022 11:31:54 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id CD80419465B2 for ; Fri, 16 Dec 2022 11:31:53 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id BEF2B483EC1; Fri, 16 Dec 2022 11:31:53 +0000 (UTC) Received: from virtlab420.virt.lab.eng.bos.redhat.com (virtlab420.virt.lab.eng.bos.redhat.com [10.19.152.148]) by smtp.corp.redhat.com (Postfix) with ESMTP id 73E0F400F58; Fri, 16 Dec 2022 11:31:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1671190322; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=JNqgq8+y/S71KQ37T12RXSGvqKJhX6bEwe3vCtlFpPI=; b=cU+GZ8+sxK30Z7XnQvthsCD2EOZX9utjTAI85tTm/fy156hNRJDVn+73FmEzqcguKP8PwI 0/K/cLhHX6SB5QlvzTZDHtQ4TYx7NuyC8OrHdWwuoQwJNPxGQojBzfXsvi3ccQJfbRSn6L /OwIXPz/b784RZKhavDcCR4HgB1r8qI= X-MC-Unique: c0gUi5QiOxeboUJJR-SjkA-1 X-Original-To: libvir-list@listman.corp.redhat.com From: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH v2 2/3] block: deprecate iSCSI 'password' in favour of 'password-secret' Date: Fri, 16 Dec 2022 06:31:51 -0500 Message-Id: <20221216113152.584460-3-berrange@redhat.com> In-Reply-To: <20221216113152.584460-1-berrange@redhat.com> References: <20221216113152.584460-1-berrange@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , qemu-block@nongnu.org, libvir-list@redhat.com, Peter Lieven , Hanna Reitz , Gerd Hoffmann , Ronnie Sahlberg , Paolo Bonzini Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.5 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1671190324949100002 Support for referencing secret objects was added in commit b189346eb1784df95ed6fed610411dbf23d19e1f Author: Daniel P. Berrang=C3=A9 Date: Thu Jan 21 14:19:21 2016 +0000 iscsi: add support for getting CHAP password via QCryptoSecret API The existing 'password' option is overdue for deprecation and subsequent removal. Signed-off-by: Daniel P. Berrang=C3=A9 Reviewed-by: Fabiano Rosas --- block/iscsi.c | 3 +++ docs/about/deprecated.rst | 8 ++++++++ 2 files changed, 11 insertions(+) diff --git a/block/iscsi.c b/block/iscsi.c index a316d46d96..58c0623052 100644 --- a/block/iscsi.c +++ b/block/iscsi.c @@ -1352,6 +1352,9 @@ static void apply_chap(struct iscsi_context *iscsi, Q= emuOpts *opts, } else if (!password) { error_setg(errp, "CHAP username specified but no password was give= n"); return; + } else { + warn_report("iSCSI block driver 'password' option is deprecated, " + "use 'password-secret' instead"); } =20 if (iscsi_set_initiator_username_pwd(iscsi, user, password)) { diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst index 93affe3669..daf2334040 100644 --- a/docs/about/deprecated.rst +++ b/docs/about/deprecated.rst @@ -333,6 +333,14 @@ The above, converted to the current supported format:: =20 json:{"file.driver":"rbd", "file.pool":"rbd", "file.image":"name"} =20 +``iscsi,password=3Dxxx`` (since 8.0) +^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ + +Specifying the iSCSI password in plain text on the command line using the +``password`` option is insecure. The ``password-secret`` option should be +used instead, to refer to a ``--object secret...`` instance that provides +a password via a file, or encrypted. + Backwards compatibility ----------------------- =20 --=20 2.38.1 From nobody Fri May 17 21:37:13 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1671190324; cv=none; d=zohomail.com; s=zohoarc; b=buh6ngjYv3mQFMxvrCdn0Iq+nvxuFUSBJQS3khr8LOgiBHzaL7786YPSp0CIcxuj0+1yWafacC2sp5aIqoB2FSAOWcQMMBHgYzKjeTwX115UHQlibgS3NmgFfBR24mi7gUee/woKUdkoz/OI0Jcje2lk81iI9kwrk0pUiw9hTek= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1671190324; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=wBJl02NBvUQHJXEwwSK0gbpIbbztTDm6lrEs/8sMdT0=; b=DuxMgmKu3KzOuEYCamZQv4rSsxLCc8pS2VQ4dTWVbk3ZVxPNcLM/fDyuwqcXR0pbaIhWbu6pYH5qPKEoPYY4bFMuPdBtxopj3lK66JSCu5D3rULEQHtvhqoCBzpP6zCJBYQaSBsgOYSEjr0u7iA/POC+W5DUdIDJKkLa1cXI1Ro= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1671190324091649.3534380256027; Fri, 16 Dec 2022 03:32:04 -0800 (PST) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-650-HIOKxmL2NI6Vawr6zCOF2Q-1; Fri, 16 Dec 2022 06:31:58 -0500 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 2E90087B2AF; Fri, 16 Dec 2022 11:31:56 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1A2532166B29; Fri, 16 Dec 2022 11:31:56 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id EAE7C19466DF; Fri, 16 Dec 2022 11:31:55 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 3A9CB19465B2 for ; Fri, 16 Dec 2022 11:31:54 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 22415400F58; Fri, 16 Dec 2022 11:31:54 +0000 (UTC) Received: from virtlab420.virt.lab.eng.bos.redhat.com (virtlab420.virt.lab.eng.bos.redhat.com [10.19.152.148]) by smtp.corp.redhat.com (Postfix) with ESMTP id C5774400F5B; Fri, 16 Dec 2022 11:31:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1671190323; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=wBJl02NBvUQHJXEwwSK0gbpIbbztTDm6lrEs/8sMdT0=; b=AdhkRetCfKX86ELvrqeyFbBU5czD2zeNP6ijP7y5MC6f6z3cbQJCWJZMum1YJQTHu+FFom bgswIzjIYjHUXJ4WPNqfn6d4GjLtU8dajjb81zCx0tWj1lGucg7SKRtwmtK2zeaNsxoaU8 Lood8BxmVIu6WlkeQkL2c2rF8vsExmo= X-MC-Unique: HIOKxmL2NI6Vawr6zCOF2Q-1 X-Original-To: libvir-list@listman.corp.redhat.com From: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH v2 3/3] ui: remove deprecated 'password' option for SPICE Date: Fri, 16 Dec 2022 06:31:52 -0500 Message-Id: <20221216113152.584460-4-berrange@redhat.com> In-Reply-To: <20221216113152.584460-1-berrange@redhat.com> References: <20221216113152.584460-1-berrange@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , qemu-block@nongnu.org, libvir-list@redhat.com, Peter Lieven , Markus Armbruster , Hanna Reitz , Gerd Hoffmann , Ronnie Sahlberg , Paolo Bonzini Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1671190324957100003 This has been replaced by the 'password-secret' option, which references a 'secret' object instance. Reviewed-by: Markus Armbruster Signed-off-by: Daniel P. Berrang=C3=A9 Reviewed-by: Fabiano Rosas --- docs/about/deprecated.rst | 8 -------- docs/about/removed-features.rst | 7 +++++++ qemu-options.hx | 9 +-------- ui/spice-core.c | 15 --------------- 4 files changed, 8 insertions(+), 31 deletions(-) diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst index daf2334040..8fbe7cb5fe 100644 --- a/docs/about/deprecated.rst +++ b/docs/about/deprecated.rst @@ -73,14 +73,6 @@ Input parameters that take a size value should only use = a size suffix the value is hexadecimal. That is, '0x20M' is deprecated, and should be written either as '32M' or as '0x2000000'. =20 -``-spice password=3Dstring`` (since 6.0) -'''''''''''''''''''''''''''''''''''''' - -This option is insecure because the SPICE password remains visible in -the process listing. This is replaced by the new ``password-secret`` -option which lets the password be securely provided on the command -line using a ``secret`` object instance. - ``-smp`` ("parameter=3D0" SMP configurations) (since 6.2) ''''''''''''''''''''''''''''''''''''''''''''''''''''''' =20 diff --git a/docs/about/removed-features.rst b/docs/about/removed-features.= rst index 63df9848fd..2cbb1b7afe 100644 --- a/docs/about/removed-features.rst +++ b/docs/about/removed-features.rst @@ -408,6 +408,13 @@ pcspk-audiodev=3D``. =20 Use ``-device`` instead. =20 +``-spice password=3Dstring`` (removed in 8.0) +''''''''''''''''''''''''''''''''''''''''''' + +This optionwas insecure because the SPICE password remained visible in +the process listing. This was replaced by the new ``password-secret`` +option which lets the password be securely provided on the command +line using a ``secret`` object instance. =20 QEMU Machine Protocol (QMP) commands ------------------------------------ diff --git a/qemu-options.hx b/qemu-options.hx index 58efb58072..847d71e567 100644 --- a/qemu-options.hx +++ b/qemu-options.hx @@ -2132,7 +2132,7 @@ DEF("spice", HAS_ARG, QEMU_OPTION_spice, " [,tls-channel=3D[main|display|cursor|inputs|record|playback]]\= n" " [,plaintext-channel=3D[main|display|cursor|inputs|record|playb= ack]]\n" " [,sasl=3Don|off][,disable-ticketing=3Don|off]\n" - " [,password=3D][,password-secret=3D]\n" + " [,password-secret=3D]\n" " [,image-compression=3D[auto_glz|auto_lz|quic|glz|lz|off]]\n" " [,jpeg-wan-compression=3D[auto|never|always]]\n" " [,zlib-glz-wan-compression=3D[auto|never|always]]\n" @@ -2158,13 +2158,6 @@ SRST ``ipv4=3Don|off``; \ ``ipv6=3Don|off``; \ ``unix=3Don|off`` Force using the specified IP version. =20 - ``password=3D`` - Set the password you need to authenticate. - - This option is deprecated and insecure because it leaves the - password visible in the process listing. Use ``password-secret`` - instead. - ``password-secret=3D`` Set the ID of the ``secret`` object containing the password you need to authenticate. diff --git a/ui/spice-core.c b/ui/spice-core.c index 72f8f1681c..76f7c2bc3d 100644 --- a/ui/spice-core.c +++ b/ui/spice-core.c @@ -412,9 +412,6 @@ static QemuOptsList qemu_spice_opts =3D { .name =3D "unix", .type =3D QEMU_OPT_BOOL, #endif - },{ - .name =3D "password", - .type =3D QEMU_OPT_STRING, },{ .name =3D "password-secret", .type =3D QEMU_OPT_STRING, @@ -666,20 +663,8 @@ static void qemu_spice_init(void) } passwordSecret =3D qemu_opt_get(opts, "password-secret"); if (passwordSecret) { - if (qemu_opt_get(opts, "password")) { - error_report("'password' option is mutually exclusive with " - "'password-secret'"); - exit(1); - } password =3D qcrypto_secret_lookup_as_utf8(passwordSecret, &error_fatal); - } else { - str =3D qemu_opt_get(opts, "password"); - if (str) { - warn_report("'password' option is deprecated and insecure, " - "use 'password-secret' instead"); - password =3D g_strdup(str); - } } =20 if (tls_port) { --=20 2.38.1