On a Thursday in 2022, Daniel P. Berrangé wrote:
>We have alot of checks for Linux kernel features that are obsolete since
>our supported platform matrix lets us assume new enough kernel versions.
>Removing the checks will speed up the meson phase and reduce the tangle
>of #ifdefs in the code.
>
>I thought I could remove the check for linux/kvm.h but for some reason
>our code in virhostpcu.c / cpu_x86.c is enabling the codebases even
>on FreeBSD, which I find kind of odd. Does FreeBSD really ship a
>linux/kvm.h ?
¯\_ (ツ)_/¯
>
>Daniel P. Berrangé (21):
> meson: remove obsolete check for LOOP_CTL_GET_FREE
> meson: remove obsolete check for EPOLL_CLOEXEC
> meson: remove obsolete check for LO_FLAGS_AUTOCLEAR
> meson: drop check for unshare()
> netdev: simplify check for ethtool functionality
> meson: remove obsolete check for ETHTOOL_GGSO
> meson: remove obsolete check for ETHTOOL_GGRO
> meson: remove obsolete check for ETHTOOL_GFLAGS
> meson: remove obsolete check for ETH_FLAG_LRO
> meson: remove obsolete check for ETH_FLAG_TXVLAN/RXVLAN
> meson: remove obsolete check for ETH_FLAG_NTUPLE
> meson: remove obsolete check for ETH_FLAG_RXHASH
> meson: remove obsolete check for ETHTOOL_GFEATURES
> meson: remove obsolete check for ETHTOOL_GCOALESCE
> meson: remove obsolete check for GET_VLAN_VID_CMD
> meson: simplify check for virnetdevbridge.c headers
> meson: remove obsolete check for DEVLINK_CMD_ESWITCH_GET
> meson: remove obsolete check for linux/magic.h
> meson: remove obsolete check for VHOST_VSOCK_SET_GUEST_CID
> meson: remove obsolete check for BPF_PROG_QUERY
> meson: remove obsolete check for BPF_CGROUP_DEVICE
>
> meson.build | 82 +++--------------------------------
> src/util/virbpf.c | 6 +--
> src/util/virbpf.h | 6 +--
> src/util/vircgroupv2devices.c | 10 ++---
> src/util/virfile.c | 15 ++-----
> src/util/virnetdev.c | 65 ++++-----------------------
> src/util/virvsock.c | 4 +-
> tests/securityselinuxhelper.c | 4 +-
> tests/virfilemock.c | 2 +-
> 9 files changed, 32 insertions(+), 162 deletions(-)
>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
Jano