From nobody Wed May 15 11:35:08 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1667474041; cv=none; d=zohomail.com; s=zohoarc; b=hWn6DXwvmLD8jiE79T74HR1UCKZlxzYO+40Zk2Y7dqJHGwkxuSbvskHkYj+H2cWZYwbZCa/XTMv4rwD/6CgXfYEmcpB/PGqEm68C99gmUhV3idvk81gw+935EGr0dH03BFPpTItCF/kS7qz5t6yMsjUKvx9kxiulT3zib6IBeuk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1667474041; h=Content-Type:Content-Transfer-Encoding:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=mfPVpFOI7CKB4MD1VljC7eHFlncn7srCiGDefL9ZIiE=; b=he5wKm2wb8lt8Ot42iZ5nDBQkm/ico+xnMJzcSX2sJMW19PwGZGtF3kp1oDwy+d+o1bVkBJycKnv7+M2LzasHdJZ2q62ssoXqRpWKaWTyQbD3hMsa0e+eKcZtnxw6/jMUVI73blEWp+UGfmqWGRRnqN+h12qfmrwfOHXFYkFC1A= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1667474041299165.43275541949367; Thu, 3 Nov 2022 04:14:01 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-574-0G8beL2AOBOr2lwiuLm5dw-1; Thu, 03 Nov 2022 07:13:58 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id BABC8833A1A; Thu, 3 Nov 2022 11:13:56 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id E5DEC39D7C; Thu, 3 Nov 2022 11:13:55 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id C745B19465A4; Thu, 3 Nov 2022 11:13:55 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 58A111946594 for ; Thu, 3 Nov 2022 11:13:55 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 3ADCE492B1E; Thu, 3 Nov 2022 11:13:55 +0000 (UTC) Received: from harajuku.usersys.redhat.com.homenet.telecomitalia.it (ovpn-193-212.brq.redhat.com [10.40.193.212]) by smtp.corp.redhat.com (Postfix) with ESMTPS id BCC6F492B06 for ; Thu, 3 Nov 2022 11:13:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1667474040; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=mfPVpFOI7CKB4MD1VljC7eHFlncn7srCiGDefL9ZIiE=; b=awBFLzDmfH1ilRQ3ntDaHDi6aBMWfCDMKmtbasWZqFtyRxVm99EqdWVznHTCS0Rs5s+pvO aKoEsQhvp840q5wdiQ12YkpAUNixepAq51+BMNvXD2FbU5xN5n7Fzw4tEC8+tN91Dbhlzw ytLQW7EEhcD5PDK+6kb7iCdE+caa5F8= X-MC-Unique: 0G8beL2AOBOr2lwiuLm5dw-1 X-Original-To: libvir-list@listman.corp.redhat.com From: Andrea Bolognani To: libvir-list@redhat.com Subject: [libvirt PATCH] apparmor: Allow running /usr/libexec/qemu-kvm Date: Thu, 3 Nov 2022 12:13:53 +0100 Message-Id: <20221103111353.361014-1-abologna@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.5 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1667474041788100001 Content-Type: text/plain; charset="utf-8"; x-default="true" Distros that use AppArmor, such as Debian and Ubuntu, install QEMU under /usr/bin/qemu-system-*, and our AppArmor profile is written with that assumption in mind. If you try to run the RHEL or CentOS version of libvirt and QEMU inside a privileged container on such distros, however, that will result in an error, because the path /usr/libexec/qemu-kvm is used instead. In particular, this prevents upstream KubeVirt releases (which are based on CentOS) from running on Debian/Ubuntu nodes. See https://github.com/kubevirt/kubevirt/pull/8692 and the issues referenced therein for additional details. Signed-off-by: Andrea Bolognani --- src/security/apparmor/usr.sbin.libvirtd.in | 4 ++++ src/security/apparmor/usr.sbin.virtqemud.in | 4 ++++ 2 files changed, 8 insertions(+) diff --git a/src/security/apparmor/usr.sbin.libvirtd.in b/src/security/appa= rmor/usr.sbin.libvirtd.in index 886f1ad518..2994de5ec9 100644 --- a/src/security/apparmor/usr.sbin.libvirtd.in +++ b/src/security/apparmor/usr.sbin.libvirtd.in @@ -99,6 +99,10 @@ profile libvirtd @sbindir@/libvirtd flags=3D(attach_disc= onnected) { # read and run an ebtables script. /var/lib/libvirt/virtd* ixr, =20 + # Needed when running the RHEL/CentOS version of libvirt and QEMU + # inside a privileged container on a Debian/Ubuntu host + /usr/libexec/qemu-kvm PUx, + # force the use of virt-aa-helper audit deny /{usr/,}sbin/apparmor_parser rwxl, audit deny /etc/apparmor.d/libvirt/** wxl, diff --git a/src/security/apparmor/usr.sbin.virtqemud.in b/src/security/app= armor/usr.sbin.virtqemud.in index 3de03d49fc..b3f33b9471 100644 --- a/src/security/apparmor/usr.sbin.virtqemud.in +++ b/src/security/apparmor/usr.sbin.virtqemud.in @@ -94,6 +94,10 @@ profile virtqemud @sbindir@/virtqemud flags=3D(attach_di= sconnected) { # read and run an ebtables script. /var/lib/libvirt/virtd* ixr, =20 + # Needed when running the RHEL/CentOS version of libvirt and QEMU + # inside a privileged container on a Debian/Ubuntu host + /usr/libexec/qemu-kvm PUx, + # force the use of virt-aa-helper audit deny /{usr/,}sbin/apparmor_parser rwxl, audit deny /etc/apparmor.d/libvirt/** wxl, --=20 2.38.1