From nobody Sat May 18 20:37:00 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1663294840; cv=none; d=zohomail.com; s=zohoarc; b=SkZMSo/LUEenohno2O454QeXReWqbrv/S9fhOWE0815IQKXABf2CwMl4YGk/lYH2T/24tkkFceOHTDCWHvpWoDBrF9+yymxZnFupnebem/2neTeN+WobQ6WoDF0ooWejLhfmsBNb3Im7XNX/EadYI2pKjVVDcMUGA9Cz6CJWpIA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1663294840; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=SlGDea+5TMXVN28WyOz/EWuAvUUB4luef2ypz7nYw2Q=; b=mAlsb7EuUQzW4/EXQUc4fWX3udlHKipM7e5OcdIQ22J7Xp6kc44rkRbTG5DlSj0vwWnch+mWxi+arUAh0HdNMTgLe+rb5xLt7YlTxfFJMPpWe47oMpYccQJ1VQK5Ph7YPqZdqiHZ+Ki8uOOzRCm/kfY4bdVTaC4pa4OFW8Vtsh8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1663294840712760.9192899617137; Thu, 15 Sep 2022 19:20:40 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-170-RTJi99YyMHihSLNnpbyH8A-1; Thu, 15 Sep 2022 22:20:38 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 102DF3C01E19; Fri, 16 Sep 2022 02:20:36 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id ECF09140EBF5; Fri, 16 Sep 2022 02:20:35 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id B90901946587; Fri, 16 Sep 2022 02:20:35 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 9C0901946586 for ; Fri, 16 Sep 2022 02:20:34 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 7978D1121319; Fri, 16 Sep 2022 02:20:34 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast02.extmail.prod.ext.rdu2.redhat.com [10.11.55.18]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 754A11121315 for ; Fri, 16 Sep 2022 02:20:34 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-2.mimecast.com [205.139.110.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 5C4198027F5 for ; Fri, 16 Sep 2022 02:20:34 +0000 (UTC) Received: from cmccmta2.chinamobile.com (cmccmta2.chinamobile.com [221.176.66.80]) by relay.mimecast.com with ESMTP id us-mta-496--kBUQ6QhPOCCe7KEtPajyQ-1; Thu, 15 Sep 2022 22:20:30 -0400 Received: from spf.mail.chinamobile.com (unknown[172.16.121.85]) by rmmx-syy-dmz-app07-12007 (RichMail) with SMTP id 2ee76323dd69224-6033b; Fri, 16 Sep 2022 10:20:27 +0800 (CST) Received: from localhost.localdomain (unknown[223.108.79.103]) by rmsmtp-syy-appsvrnew03-12028 (RichMail) with SMTP id 2efc6323dd67ab5-aeadc; Fri, 16 Sep 2022 10:20:26 +0800 (CST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1663294839; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=SlGDea+5TMXVN28WyOz/EWuAvUUB4luef2ypz7nYw2Q=; b=IvjRXUWH7LBim57oEidR35lXUezs4EMOUHjIOk1QRy9m/J6zEIkzj7GKUH4rXFBcutL54B omqjCYxO5fq1I71vWm1Knv+7WlJC8KRD5sP//vgTym/ZC9URN8qW2DriqClc4fmhFDPuz/ Qm0hgpcT6LDvfb/tI9tKrzQZG+bhZ1g= X-MC-Unique: RTJi99YyMHihSLNnpbyH8A-1 X-Original-To: libvir-list@listman.corp.redhat.com X-MC-Unique: -kBUQ6QhPOCCe7KEtPajyQ-1 X-RM-TagInfo: emlType=0 X-RM-SPAM-FLAG: 00000000 X-RM-TRANSID: 2ee76323dd69224-6033b X-RM-TagInfo: emlType=0 X-RM-SPAM-FLAG: 00000000 X-RM-TRANSID: 2efc6323dd67ab5-aeadc From: dinglimin To: libvir-list@redhat.com Subject: [PATCH] Log alarms should be generated even if the QEMU process is not stopped Date: Fri, 16 Sep 2022 10:20:14 +0800 Message-Id: <20220916022014.1424-1-dinglimin@cmss.chinamobile.com> MIME-Version: 1.0 X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dinglimin Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.7 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1663294841293100001 Content-Type: text/plain; charset="utf-8"; x-default="true" Signed-off-by: dinglimin --- src/qemu/qemu_process.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index cbfdd3bda5..e025e10873 100644 --- a/src/qemu/qemu_process.c +++ b/src/qemu/qemu_process.c @@ -8006,9 +8006,11 @@ qemuProcessKill(virDomainObj *vm, unsigned int flags) } =20 if (flags & VIR_QEMU_PROCESS_KILL_NOWAIT) { - virProcessKill(vm->pid, + if (virProcessKill(vm->pid, (flags & VIR_QEMU_PROCESS_KILL_FORCE) ? - SIGKILL : SIGTERM); + SIGKILL : SIGTERM) !=3D 0) { + VIR_DEBUG("Failed to terminate qemu process"); + } return 0; } =20 --=20 2.30.0.windows.2