[v1] qemu: tpm: Improve TPM state files management

[PATCH 0/2] qemu: tpm: Improve TPM state files management

Stefan Berger posted 2 patches 1 year, 8 months ago

Diff against v2
Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20220823162858.3704995-1-stefanb@linux.ibm.com

There is a newer version of this series

include/libvirt/libvirt-domain.h |  6 ++++++
src/qemu/qemu_domain.c           | 12 +++++++-----
src/qemu/qemu_domain.h           |  3 ++-
src/qemu/qemu_driver.c           | 31 ++++++++++++++++++++-----------
src/qemu/qemu_extdevice.c        |  5 +++--
src/qemu/qemu_extdevice.h        |  3 ++-
src/qemu/qemu_migration.c        | 22 +++++++++++++++-------
src/qemu/qemu_process.c          |  4 ++--
src/qemu/qemu_snapshot.c         |  4 ++--
src/qemu/qemu_tpm.c              | 14 ++++++++++----
src/qemu/qemu_tpm.h              | 15 ++++++++++++++-
tools/virsh-domain.c             | 15 +++++++++++++++
12 files changed, 98 insertions(+), 36 deletions(-)

Expand all Fold all

[PATCH 0/2] qemu: tpm: Improve TPM state files management

Posted by Stefan Berger 1 year, 8 months ago

This series of patches adds the --keep-tpm and --tpm flags to virsh for
keeping and removing the TPM state directory structure when a VM is
undefined. It also fixes the removal of state when a VM is migrated so
that the state files are removed on the source upon successful
migration and deleted on the destination after migration failure.

Regards,
  Stefan

Stefan Berger (2):
  qemu: Add UNDEFINE_TPM and UNDEFINE_KEEP_TPM flags
  qemu: tpm: Remove TPM state after successful migration

 include/libvirt/libvirt-domain.h |  6 ++++++
 src/qemu/qemu_domain.c           | 12 +++++++-----
 src/qemu/qemu_domain.h           |  3 ++-
 src/qemu/qemu_driver.c           | 31 ++++++++++++++++++++-----------
 src/qemu/qemu_extdevice.c        |  5 +++--
 src/qemu/qemu_extdevice.h        |  3 ++-
 src/qemu/qemu_migration.c        | 22 +++++++++++++++-------
 src/qemu/qemu_process.c          |  4 ++--
 src/qemu/qemu_snapshot.c         |  4 ++--
 src/qemu/qemu_tpm.c              | 14 ++++++++++----
 src/qemu/qemu_tpm.h              | 15 ++++++++++++++-
 tools/virsh-domain.c             | 15 +++++++++++++++
 12 files changed, 98 insertions(+), 36 deletions(-)

-- 
2.37.1

Re: [PATCH 0/2] qemu: tpm: Improve TPM state files management

Posted by Michal Prívozník 1 year, 7 months ago

On 8/23/22 18:28, Stefan Berger wrote:
> This series of patches adds the --keep-tpm and --tpm flags to virsh for
> keeping and removing the TPM state directory structure when a VM is
> undefined. It also fixes the removal of state when a VM is migrated so
> that the state files are removed on the source upon successful
> migration and deleted on the destination after migration failure.
> 
> Regards,
>   Stefan
> 
> Stefan Berger (2):
>   qemu: Add UNDEFINE_TPM and UNDEFINE_KEEP_TPM flags
>   qemu: tpm: Remove TPM state after successful migration
> 
>  include/libvirt/libvirt-domain.h |  6 ++++++
>  src/qemu/qemu_domain.c           | 12 +++++++-----
>  src/qemu/qemu_domain.h           |  3 ++-
>  src/qemu/qemu_driver.c           | 31 ++++++++++++++++++++-----------
>  src/qemu/qemu_extdevice.c        |  5 +++--
>  src/qemu/qemu_extdevice.h        |  3 ++-
>  src/qemu/qemu_migration.c        | 22 +++++++++++++++-------
>  src/qemu/qemu_process.c          |  4 ++--
>  src/qemu/qemu_snapshot.c         |  4 ++--
>  src/qemu/qemu_tpm.c              | 14 ++++++++++----
>  src/qemu/qemu_tpm.h              | 15 ++++++++++++++-
>  tools/virsh-domain.c             | 15 +++++++++++++++
>  12 files changed, 98 insertions(+), 36 deletions(-)
> 

Huge sorry for letting this slip through review. I had it marked for
review but then was AFK for some time.

Michal