src/qemu/qemu_capabilities.c | 4 ++-- src/qemu/qemu_capabilities.h | 2 ++ tests/domaincapsmock.c | 6 ++++++ tests/qemucapabilitiestest.c | 3 ++- 4 files changed, 12 insertions(+), 3 deletions(-)
We need to mock the function that probes for HVF support. Andrea Bolognani (3): tests: Use domaincapsmock in qemucapabilitiestest qemu: Make virQEMUCapsProbeHVF() non-static tests: Mock virQEMUCapsProbeHVF() src/qemu/qemu_capabilities.c | 4 ++-- src/qemu/qemu_capabilities.h | 2 ++ tests/domaincapsmock.c | 6 ++++++ tests/qemucapabilitiestest.c | 3 ++- 4 files changed, 12 insertions(+), 3 deletions(-) -- 2.37.1
On 2022-08-10 at 16:29 +02, Andrea Bolognani <abologna@redhat.com> wrote... > We need to mock the function that probes for HVF support. > > Andrea Bolognani (3): > tests: Use domaincapsmock in qemucapabilitiestest > qemu: Make virQEMUCapsProbeHVF() non-static > tests: Mock virQEMUCapsProbeHVF() > > src/qemu/qemu_capabilities.c | 4 ++-- > src/qemu/qemu_capabilities.h | 2 ++ > tests/domaincapsmock.c | 6 ++++++ > tests/qemucapabilitiestest.c | 3 ++- > 4 files changed, 12 insertions(+), 3 deletions(-) This works. We now have a clean test suite on macOS 12: Ok: 252 Expected Fail: 0 Fail: 0 Unexpected Pass: 0 Skipped: 19 Timeout: 0 For the series: Reviewed-by: Christophe de Dinechin <dinechin@redhat.com> Tested-by: Christophe de Dinechin <dinechin@redhat.com> -- Cheers, Christophe de Dinechin (https://c3d.github.io)
On Wed, Aug 10, 2022 at 05:16:57PM +0200, Christophe de Dinechin wrote: > On 2022-08-10 at 16:29 +02, Andrea Bolognani <abologna@redhat.com> wrote... > > We need to mock the function that probes for HVF support. > > > > Andrea Bolognani (3): > > tests: Use domaincapsmock in qemucapabilitiestest > > qemu: Make virQEMUCapsProbeHVF() non-static > > tests: Mock virQEMUCapsProbeHVF() > > > > src/qemu/qemu_capabilities.c | 4 ++-- > > src/qemu/qemu_capabilities.h | 2 ++ > > tests/domaincapsmock.c | 6 ++++++ > > tests/qemucapabilitiestest.c | 3 ++- > > 4 files changed, 12 insertions(+), 3 deletions(-) > > This works. We now have a clean test suite on macOS 12: > > Ok: 252 > Expected Fail: 0 > Fail: 0 > Unexpected Pass: 0 > Skipped: 19 > Timeout: 0 > > For the series: > > Reviewed-by: Christophe de Dinechin <dinechin@redhat.com> > Tested-by: Christophe de Dinechin <dinechin@redhat.com> Thanks to both you and Jano! Pushed now. I'll try switching the Cirrus CI configuration to macOS 12 again, but I'm afraid it's still going to hit the qemuxml2argvtest issue that doesn't show up on your machine. We'll see :) -- Andrea Bolognani / Red Hat / Virtualization
On Wed, Aug 10, 2022 at 10:54:16AM -0500, Andrea Bolognani wrote: > On Wed, Aug 10, 2022 at 05:16:57PM +0200, Christophe de Dinechin wrote: > > This works. We now have a clean test suite on macOS 12: > > > > Ok: 252 > > Expected Fail: 0 > > Fail: 0 > > Unexpected Pass: 0 > > Skipped: 19 > > Timeout: 0 > > I'll try switching the Cirrus CI configuration to macOS 12 again, but > I'm afraid it's still going to hit the qemuxml2argvtest issue that > doesn't show up on your machine. We'll see :) Yeah, that still fails. https://gitlab.com/abologna/libvirt/-/jobs/2843833417 This might be too much to ask but, you could possibly create a macOS VM on your machine and see whether the issue reproduces there? I'm starting to think that virtualization is somehow the issue, even though that doesn't really make any sense to me. And a fresh install would rule out that whatever local configuration changes you're made to your main OS are what's causing the test to pass rather than fail. -- Andrea Bolognani / Red Hat / Virtualization
On a Wednesday in 2022, Andrea Bolognani wrote: >We need to mock the function that probes for HVF support. > >Andrea Bolognani (3): > tests: Use domaincapsmock in qemucapabilitiestest > qemu: Make virQEMUCapsProbeHVF() non-static > tests: Mock virQEMUCapsProbeHVF() > > src/qemu/qemu_capabilities.c | 4 ++-- > src/qemu/qemu_capabilities.h | 2 ++ > tests/domaincapsmock.c | 6 ++++++ > tests/qemucapabilitiestest.c | 3 ++- > 4 files changed, 12 insertions(+), 3 deletions(-) > Reviewed-by: Ján Tomko <jtomko@redhat.com> Jano
© 2016 - 2024 Red Hat, Inc.