[libvirt-dbus] README: Fix the broken link of libvirt-dbus

Han Han posted 1 patch 1 year, 9 months ago
Failed in applying to current master (apply log)
README.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[libvirt-dbus] README: Fix the broken link of libvirt-dbus
Posted by Han Han 1 year, 9 months ago
Signed-off-by: Han Han <hhan@redhat.com>
---
 README.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/README.rst b/README.rst
index eacbbf2..ee20e85 100644
--- a/README.rst
+++ b/README.rst
@@ -13,7 +13,7 @@ API better suited for dbus-based applications.
 
 libvirt-dbus is Free Software and licenced under LGPLv2+.
 
-* https://libvirt.org/libvirt-dbus.html
+* https://libvirt.org/dbus.html
 
 The latest official releases can be found at:
 
-- 
2.37.1
Re: [libvirt-dbus] README: Fix the broken link of libvirt-dbus
Posted by Erik Skultety 1 year, 9 months ago
On Thu, Aug 04, 2022 at 11:34:16AM +0800, Han Han wrote:
> Signed-off-by: Han Han <hhan@redhat.com>
> ---
>  README.rst | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/README.rst b/README.rst
> index eacbbf2..ee20e85 100644
> --- a/README.rst
> +++ b/README.rst
> @@ -13,7 +13,7 @@ API better suited for dbus-based applications.
>  
>  libvirt-dbus is Free Software and licenced under LGPLv2+.
>  
> -* https://libvirt.org/libvirt-dbus.html
> +* https://libvirt.org/dbus.html
>  
>  The latest official releases can be found at:
>  
> -- 
> 2.37.1
> 

Ah, I forgot one important detail - by moving to the MR workflow we disabled
pushing to the protected branches (duh!), so you'll have to submit an MR
instead - while at it, you can also fix the patch submission paragraph :)

Erik
Re: [libvirt-dbus] README: Fix the broken link of libvirt-dbus
Posted by Erik Skultety 1 year, 9 months ago
On Thu, Aug 04, 2022 at 11:34:16AM +0800, Han Han wrote:
> Signed-off-by: Han Han <hhan@redhat.com>
> ---
>  README.rst | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/README.rst b/README.rst
> index eacbbf2..ee20e85 100644
> --- a/README.rst
> +++ b/README.rst
> @@ -13,7 +13,7 @@ API better suited for dbus-based applications.
>  
>  libvirt-dbus is Free Software and licenced under LGPLv2+.
>  
> -* https://libvirt.org/libvirt-dbus.html
> +* https://libvirt.org/dbus.html
>  
>  The latest official releases can be found at:
>  
> -- 
> 2.37.1
> 

Since we still tell contributors to send patches to the list, I'm going to ACK
this one and push, but we've already switched all the other libvirt-<project>
repos to MR workflow, I'm going to delete that paragraph.

Reviewed-by: Erik Skultety <eskultet@redhat.com>

Regards,
Erik
Re: [libvirt-dbus] README: Fix the broken link of libvirt-dbus
Posted by Han Han 1 year, 9 months ago
On Thu, Aug 4, 2022 at 3:35 PM Erik Skultety <eskultet@redhat.com> wrote:

> On Thu, Aug 04, 2022 at 11:34:16AM +0800, Han Han wrote:
> > Signed-off-by: Han Han <hhan@redhat.com>
> > ---
> >  README.rst | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/README.rst b/README.rst
> > index eacbbf2..ee20e85 100644
> > --- a/README.rst
> > +++ b/README.rst
> > @@ -13,7 +13,7 @@ API better suited for dbus-based applications.
> >
> >  libvirt-dbus is Free Software and licenced under LGPLv2+.
> >
> > -* https://libvirt.org/libvirt-dbus.html
> > +* https://libvirt.org/dbus.html
> >
> >  The latest official releases can be found at:
> >
> > --
> > 2.37.1
> >
>
> Since we still tell contributors to send patches to the list, I'm going to
> ACK
> this one and push, but we've already switched all the other
> libvirt-<project>
> repos to MR workflow, I'm going to delete that paragraph.
>
> Thanks. Please also update the paragraph "Patches submissions" of
https://gitlab.com/libvirt/libvirt-dbus for the MR workflow.

> Reviewed-by: Erik Skultety <eskultet@redhat.com>
>
> Regards,
> Erik
>
>