From nobody Tue May 14 16:40:50 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1657876517; cv=none; d=zohomail.com; s=zohoarc; b=ZEEWrAETMcFK+WH2TTXR93gMPYvIXzqhuYuZ35LrIHzwNgqaNHeIVkgnXLCVQYwlX3cXV7SkTiBzaibwP1hHi+BcoAYaKyHMrjRDVdjvNNGY3INv0mP0+yk6nmdIGPUybggEcGGAIkNh67szvQpTlveIxXlxn2h1fXHezsVMZtU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1657876517; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=NBuK4DYcGaj/wRFQbKCNgPyit/Rq5cPAIlI5c0xLrg8=; b=IgnbgVmJkN2Fi8MRdR1DjRtqTvA0smxBEpoOkh7DZL5TtSR33tRMlvG8j+2ePUWpVHAjwaVxDklVcSuTK51s7RIMl6AjLlnn+8IhDHnX5UDyoTyV6nt6VtbzndqPsolYZefobHUNK290i5EgKTGTwQlJCko9JU2yfgSJsNyeM44= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.zohomail.com with SMTPS id 1657876517681386.5077854277738; Fri, 15 Jul 2022 02:15:17 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-397-r8I9JNusMJqcAnvzww58CA-1; Fri, 15 Jul 2022 05:15:11 -0400 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 80ABF3C0D86C; Fri, 15 Jul 2022 09:15:08 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id E7F9B40315D; Fri, 15 Jul 2022 09:15:07 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id BA430194706D; Fri, 15 Jul 2022 09:15:02 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 0DFEE1947041 for ; Fri, 15 Jul 2022 09:15:02 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id DE427112131B; Fri, 15 Jul 2022 09:15:01 +0000 (UTC) Received: from eperezma.remote.csb (unknown [10.39.192.117]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3BBD81121315; Fri, 15 Jul 2022 09:15:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1657876516; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=NBuK4DYcGaj/wRFQbKCNgPyit/Rq5cPAIlI5c0xLrg8=; b=hDxH3fDuL5SavjnwcSggDmEFlyPD0DycUEhgpcFBRsCqzM038cx0jp9f+RYPNYeOOuuZ6J nmhwwWaaqYgOMlmx2d/TiHX8/zGfkMTwFqz/fRznm4KrTmBl0ccLRPIcgrA1cLysKa8HnK ++VOpAX3fy8IQfMKcAo3t3fho8n67vU= X-MC-Unique: r8I9JNusMJqcAnvzww58CA-1 X-Original-To: libvir-list@listman.corp.redhat.com From: =?UTF-8?q?Eugenio=20P=C3=A9rez?= To: libvir-list@redhat.com Subject: [libvirt PATCH] qemu_migration: Delete vDPA check Date: Fri, 15 Jul 2022 11:14:58 +0200 Message-Id: <20220715091458.2620872-1-eperezma@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Laurent Vivier , Jason Wang , Jiri Denemark , Jaroslav Suchanek Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 2.85 on 10.11.54.10 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1657876518238100001 Currently, the migration code denies migration as long as the VM has a vhost-vDPA device. While it's true that vhost-vDPA devices cannot be migrated at the moment, t= here are plans to be able to migrate them soon. Libvirt must treat it equal to vhost-kernel devices: Not all of them can be migrated (the ones that do not expose the feature VHOST_F_LOG_ALL cannot be migrated). So checks like this one should work for all vhost devices equally. A more accurate solution is to ask qemu if it has an active migration blocker at that moment. Hoever, that require synchronization to avoid qemu to add one between the query and the actual migration command. Signed-off-by: Eugenio P=C3=A9rez --- src/qemu/qemu_migration.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c index 9c3fd41761..4ddf027c83 100644 --- a/src/qemu/qemu_migration.c +++ b/src/qemu/qemu_migration.c @@ -1546,12 +1546,6 @@ qemuMigrationSrcIsAllowed(virQEMUDriver *driver, virDomainNetDef *net =3D vm->def->nets[i]; qemuSlirp *slirp; =20 - if (net->type =3D=3D VIR_DOMAIN_NET_TYPE_VDPA) { - virReportError(VIR_ERR_OPERATION_INVALID, "%s", - _("vDPA devices cannot be migrated")); - return false; - } - slirp =3D QEMU_DOMAIN_NETWORK_PRIVATE(net)->slirp; =20 if (slirp && !qemuSlirpHasFeature(slirp, QEMU_SLIRP_FEATURE_MI= GRATE)) { --=20 2.31.1