From nobody Thu May 16 02:13:11 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=none dis=none) header.from=fujitsu.com Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.zohomail.com with SMTPS id 1656388432037415.73902017969203; Mon, 27 Jun 2022 20:53:52 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-122-r7__XcWIMu-oYDDNtiM8bw-1; Mon, 27 Jun 2022 23:53:45 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id F1B94101A586; Tue, 28 Jun 2022 03:53:43 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5FE2E18EAC; Tue, 28 Jun 2022 03:53:42 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 0D0FA194704D; Tue, 28 Jun 2022 03:53:42 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 8BC7F19466DF for ; Tue, 28 Jun 2022 03:53:41 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 64924815B; Tue, 28 Jun 2022 03:53:41 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast04.extmail.prod.ext.rdu2.redhat.com [10.11.55.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5FFF318EAA for ; Tue, 28 Jun 2022 03:53:41 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 44C84101A588 for ; Tue, 28 Jun 2022 03:53:41 +0000 (UTC) Received: from heian.cn.fujitsu.com (mail.cn.fujitsu.com [183.91.158.132]) by relay.mimecast.com with ESMTP id us-mta-619-s7YWBKnvNqWCA7Mn5yPwiw-1; Mon, 27 Jun 2022 23:53:37 -0400 Received: from unknown (HELO cn.fujitsu.com) ([10.167.33.5]) by heian.cn.fujitsu.com with ESMTP; 28 Jun 2022 11:53:31 +0800 Received: from G08CNEXMBPEKD04.g08.fujitsu.local (unknown [10.167.33.201]) by cn.fujitsu.com (Postfix) with ESMTP id DBB354D1718F; Tue, 28 Jun 2022 11:53:27 +0800 (CST) Received: from G08CNEXCHPEKD07.g08.fujitsu.local (10.167.33.80) by G08CNEXMBPEKD04.g08.fujitsu.local (10.167.33.201) with Microsoft SMTP Server (TLS) id 15.0.1497.23; Tue, 28 Jun 2022 11:53:28 +0800 Received: from SuperLiu.g08.fujitsu.local (10.167.226.82) by G08CNEXCHPEKD07.g08.fujitsu.local (10.167.33.209) with Microsoft SMTP Server id 15.0.1497.23 via Frontend Transport; Tue, 28 Jun 2022 11:53:28 +0800 X-MC-Unique: r7__XcWIMu-oYDDNtiM8bw-1 X-Original-To: libvir-list@listman.corp.redhat.com X-MC-Unique: s7YWBKnvNqWCA7Mn5yPwiw-1 IronPort-Data: =?us-ascii?q?A9a23=3A+abxhqmh08go/imwc4X0S+Po5gyoJERdPkR7XQ2?= =?us-ascii?q?eYbTBsI5bpzUOz2NKDDvUM/qCM2PxKot1aorip0MA6pbRyYM3QVFk+CA2RRqmi?= =?us-ascii?q?+KfW43BcR2Y0wB+jyH7ZBs+qZ1YM7EsFehsJpPnjkrrYuiJQUVUj/nSHOKmULe?= =?us-ascii?q?cY0ideCc/IMsfoUM68wIGqt4w6TSJK1vlVeLa+6UzCnf8s9JHGj58B5a4lf9al?= =?us-ascii?q?K+aVAX0EbAJTasjUFf2zxH5BX+ETE27ByOQroJ8RoZWSwtfpYxV8F81/z91Yj+?= =?us-ascii?q?kur39NEMXQL/OJhXIgX1TM0SgqkEa4HVsjeBgb7xBAatUo2zhc9RZzNRQpJD2R?= =?us-ascii?q?wEyIoXCheYcTwJFVSp5OMWq/Zeeeybg7ZXJkxOun3zEhq8G4FsNFYkZ8Ph2GyR?= =?us-ascii?q?K9OcEACoAYhCKm6S9x7fTYux0nMU9K9vtFJkStnFp0XfSCvNOfHxpa80m/vcBh?= =?us-ascii?q?HFp2J8IRq2YOqIkhfNUREyoS3Vy1p0/UfrSRNuVu0Q=3D?= IronPort-HdrOrdr: =?us-ascii?q?A9a23=3Avdzdyq26OIG9uz18WZqlmgqjBFgkLtp133Aq?= =?us-ascii?q?2lEZdPUzSL36qynOppQmPHrP4wr5N0tQ++xoVJPtfZq/z+8Q3WBhB9aftWDd0Q?= =?us-ascii?q?OVxepZg7cKrQeOJ8SHzJ866U4aSdkaNPTASWBDyebcxyWCV/YMqePrzImYwd/n?= =?us-ascii?q?i1NMaS0CUdAG0y5JTj6iVml/RAxLHvMCZeOhz/sCnwLlQ0kmS+jTPAh8Y8Hz4+?= =?us-ascii?q?Xy0KPDST4iJzkJzmC15w+A2frDK1yd3hp2aUI1/Ysf?= X-IronPort-AV: E=Sophos;i="5.88,333,1635177600"; d="scan'208";a="126741246" From: Liu Yiding To: Subject: [PATCH v2] conf: virDomainMemoryDefValidate: Improve error message Date: Tue, 28 Jun 2022 11:53:35 +0800 Message-ID: <20220628035335.238442-1-liuyd.fnst@fujitsu.com> MIME-Version: 1.0 X-yoursite-MailScanner-ID: DBB354D1718F.A08E8 X-yoursite-MailScanner: Found to be clean X-yoursite-MailScanner-From: liuyd.fnst@fujitsu.com X-Spam-Status: No X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mprivozn@redhat.com, Liu Yiding Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZM-MESSAGEID: 1656388433643100001 Content-Type: text/plain; charset="utf-8" An explicit limit would be more user friendly. Add the limit to error messa= ge. Before this commit: ``` error: requested size must be smaller than or equal to @size ``` Now: ``` error: requested size must be smaller than or equal to @size (8388608KiB) ``` Signed-off-by: Liu Yiding Reviewed-by: Michal Privoznik --- src/conf/domain_validate.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/conf/domain_validate.c b/src/conf/domain_validate.c index 33b6f47159..28b0481d4e 100644 --- a/src/conf/domain_validate.c +++ b/src/conf/domain_validate.c @@ -2194,8 +2194,9 @@ virDomainMemoryDefValidate(const virDomainMemoryDef *= mem, =20 case VIR_DOMAIN_MEMORY_MODEL_VIRTIO_MEM: if (mem->requestedsize > mem->size) { - virReportError(VIR_ERR_XML_DETAIL, "%s", - _("requested size must be smaller than or equal= to @size")); + virReportError(VIR_ERR_XML_DETAIL, + _("requested size must be smaller than or equal= to @size (%lluKiB)"), + mem->size); return -1; } =20 --=20 2.34.1