[v1] ci: Drop Fedora 34, add Fedora 36

[libvirt PATCH 0/4] ci: Drop Fedora 34, add Fedora 36

Posted by Andrea Bolognani 1 year, 11 months ago

Test pipeline:

  https://gitlab.com/abologna/libvirt/-/pipelines/548549670

Matching libvirt-perl MR, needed because the integration tests
download artifacts from there:

  https://gitlab.com/libvirt/libvirt-perl/-/merge_requests/63

Andrea Bolognani (4):
  ci: Drop Fedora 34
  ci: Refresh generated files
  ci: Add Fedora 36
  ci: Move nonstandard jobs from Fedora 35 to Fedora 36

 ...ile => fedora-36-cross-mingw32.Dockerfile} |   2 +-
 ...ile => fedora-36-cross-mingw64.Dockerfile} |   2 +-
 ...ora-34.Dockerfile => fedora-36.Dockerfile} |   3 +-
 ci/gitlab.yml                                 | 767 +-----------------
 ci/gitlab/build-templates.yml                 |  45 +
 ci/gitlab/builds.yml                          | 402 +++++++++
 ci/gitlab/container-templates.yml             |  52 ++
 ci/gitlab/containers.yml                      | 325 ++++++++
 ci/gitlab/sanity-checks.yml                   |  18 +
 ci/integration.yml                            |  22 +-
 ci/manifest.yml                               |  10 +-
 11 files changed, 864 insertions(+), 784 deletions(-)
 rename ci/containers/{fedora-35-cross-mingw32.Dockerfile => fedora-36-cross-mingw32.Dockerfile} (98%)
 rename ci/containers/{fedora-35-cross-mingw64.Dockerfile => fedora-36-cross-mingw64.Dockerfile} (98%)
 rename ci/containers/{fedora-34.Dockerfile => fedora-36.Dockerfile} (97%)
 create mode 100644 ci/gitlab/build-templates.yml
 create mode 100644 ci/gitlab/builds.yml
 create mode 100644 ci/gitlab/container-templates.yml
 create mode 100644 ci/gitlab/containers.yml
 create mode 100644 ci/gitlab/sanity-checks.yml

-- 
2.35.3

Re: [libvirt PATCH 0/4] ci: Drop Fedora 34, add Fedora 36

Posted by Erik Skultety 1 year, 11 months ago

On Thu, May 26, 2022 at 11:05:30AM +0200, Andrea Bolognani wrote:
> Test pipeline:
> 
>   https://gitlab.com/abologna/libvirt/-/pipelines/548549670
> 
> Matching libvirt-perl MR, needed because the integration tests
> download artifacts from there:
> 
>   https://gitlab.com/libvirt/libvirt-perl/-/merge_requests/63

Reviewed-by: Erik Skultety <eskultet@redhat.com>

Please don't push this yet, because the integration tests would fail (as you
didn't didn't run them in your pipeline) - I need to create a template
image for fedora-36 first on the baremetal host. I'll ping you when it's done.

Erik

Re: [libvirt PATCH 0/4] ci: Drop Fedora 34, add Fedora 36

Posted by Andrea Bolognani 1 year, 11 months ago

On Thu, May 26, 2022 at 12:05:23PM +0200, Erik Skultety wrote:
> On Thu, May 26, 2022 at 11:05:30AM +0200, Andrea Bolognani wrote:
> > Test pipeline:
> >
> >   https://gitlab.com/abologna/libvirt/-/pipelines/548549670
> >
> > Matching libvirt-perl MR, needed because the integration tests
> > download artifacts from there:
> >
> >   https://gitlab.com/libvirt/libvirt-perl/-/merge_requests/63
>
> Reviewed-by: Erik Skultety <eskultet@redhat.com>
>
> Please don't push this yet, because the integration tests would fail (as you
> didn't didn't run them in your pipeline)

I didn't think I would be able to. Can anyone trigger a run of the
integration tests? Can group members?

> I need to create a template
> image for fedora-36 first on the baremetal host. I'll ping you when it's done.

I think we will start seeing failures in the Fedora 34 integration
jobs now that the libvirt-perl MR has been accepted and thus the
corresponding job is gone. Or is GitLab CI smart enough to go and
pick the artifacts from the last existing occurrence of the job?

I can split things so that Fedora 34 is dropped and Fedora 36 is only
added to the non-integration part of the pipeline at first, and then
the integration job is added in a separate commit. The bulk could be
pushed right away, with the last bit waiting for you to prepare the
VM template.

Or is that a quick enough job that it doesn't matter in practice and
I'm massively overthinking this? O:-)

-- 
Andrea Bolognani / Red Hat / Virtualization

Re: [libvirt PATCH 0/4] ci: Drop Fedora 34, add Fedora 36

Posted by Erik Skultety 1 year, 11 months ago

On Thu, May 26, 2022 at 05:15:28AM -0700, Andrea Bolognani wrote:
> On Thu, May 26, 2022 at 12:05:23PM +0200, Erik Skultety wrote:
> > On Thu, May 26, 2022 at 11:05:30AM +0200, Andrea Bolognani wrote:
> > > Test pipeline:
> > >
> > >   https://gitlab.com/abologna/libvirt/-/pipelines/548549670
> > >
> > > Matching libvirt-perl MR, needed because the integration tests
> > > download artifacts from there:
> > >
> > >   https://gitlab.com/libvirt/libvirt-perl/-/merge_requests/63
> >
> > Reviewed-by: Erik Skultety <eskultet@redhat.com>
> >
> > Please don't push this yet, because the integration tests would fail (as you
> > didn't didn't run them in your pipeline)
> 
> I didn't think I would be able to. Can anyone trigger a run of the
> integration tests? Can group members?

Any member can trigger the scheduled pipeline in the main repo, but you'd have
to set up your own runner for your fork to do it.

> 
> > I need to create a template
> > image for fedora-36 first on the baremetal host. I'll ping you when it's done.
> 
> I think we will start seeing failures in the Fedora 34 integration
> jobs now that the libvirt-perl MR has been accepted and thus the
> corresponding job is gone. Or is GitLab CI smart enough to go and
> pick the artifacts from the last existing occurrence of the job?
> 
> I can split things so that Fedora 34 is dropped and Fedora 36 is only
> added to the non-integration part of the pipeline at first, and then
> the integration job is added in a separate commit. The bulk could be
> pushed right away, with the last bit waiting for you to prepare the
> VM template.
> 
> Or is that a quick enough job that it doesn't matter in practice and
> I'm massively overthinking this? O:-)

Yeah, usually I can do it within minutes, but the pipeline failed [1]. I think
in the case of F35 there may be one more problem with your patches and for F36,
sigh, the failure relates to a recent CVE fix in git [2] which e.g. the Avocado
project already had to deal with.
So I agree, please strip the fedora 36 changes to the integration stage and you
can push the rest while I figure out how to deal with the failures.

[1] https://gitlab.com/eskultety/libvirt/-/pipelines/548707692
[2] https://github.blog/2022-04-12-git-security-vulnerability-announced/

Andrea, I take it you'll repost your series without the F36 integration changes
so that I can ACK separately, right?

Erik

Re: [libvirt PATCH 0/4] ci: Drop Fedora 34, add Fedora 36

Posted by Andrea Bolognani 1 year, 11 months ago

On Thu, May 26, 2022 at 03:07:52PM +0200, Erik Skultety wrote:
> On Thu, May 26, 2022 at 05:15:28AM -0700, Andrea Bolognani wrote:
> > On Thu, May 26, 2022 at 12:05:23PM +0200, Erik Skultety wrote:
> > > Please don't push this yet, because the integration tests would fail (as you
> > > didn't didn't run them in your pipeline)
> >
> > I didn't think I would be able to. Can anyone trigger a run of the
> > integration tests? Can group members?
>
> Any member can trigger the scheduled pipeline in the main repo, but you'd have
> to set up your own runner for your fork to do it.

So Technically™ I could run it, but in practice I couldn't :)

> Yeah, usually I can do it within minutes, but the pipeline failed [1]. I think
> in the case of F35 there may be one more problem with your patches

Yup, I changed the Fedora 35 build job so that it would no longer
publish RPMs as artifacts, and that obviously broke the integration
job.

> Andrea, I take it you'll repost your series without the F36 integration changes
> so that I can ACK separately, right?

  https://listman.redhat.com/archives/libvir-list/2022-May/231856.html

:)

-- 
Andrea Bolognani / Red Hat / Virtualization

Re: [libvirt PATCH 0/4] ci: Drop Fedora 34, add Fedora 36

Posted by Daniel P. Berrangé 1 year, 11 months ago

On Thu, May 26, 2022 at 05:15:28AM -0700, Andrea Bolognani wrote:
> On Thu, May 26, 2022 at 12:05:23PM +0200, Erik Skultety wrote:
> > On Thu, May 26, 2022 at 11:05:30AM +0200, Andrea Bolognani wrote:
> > > Test pipeline:
> > >
> > >   https://gitlab.com/abologna/libvirt/-/pipelines/548549670
> > >
> > > Matching libvirt-perl MR, needed because the integration tests
> > > download artifacts from there:
> > >
> > >   https://gitlab.com/libvirt/libvirt-perl/-/merge_requests/63
> >
> > Reviewed-by: Erik Skultety <eskultet@redhat.com>
> >
> > Please don't push this yet, because the integration tests would fail (as you
> > didn't didn't run them in your pipeline)
> 
> I didn't think I would be able to. Can anyone trigger a run of the
> integration tests? Can group members?
> 
> > I need to create a template
> > image for fedora-36 first on the baremetal host. I'll ping you when it's done.
> 
> I think we will start seeing failures in the Fedora 34 integration
> jobs now that the libvirt-perl MR has been accepted and thus the
> corresponding job is gone. Or is GitLab CI smart enough to go and
> pick the artifacts from the last existing occurrence of the job?
> 
> I can split things so that Fedora 34 is dropped and Fedora 36 is only
> added to the non-integration part of the pipeline at first, and then
> the integration job is added in a separate commit. The bulk could be
> pushed right away, with the last bit waiting for you to prepare the
> VM template.
> 
> Or is that a quick enough job that it doesn't matter in practice and
> I'm massively overthinking this? O:-)

The integration jobs are only set to run once a day.


With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|