[v3] Introduce network backed NVRAM

[PATCH v3 0/5] Introduce network backed NVRAM

Posted by Rohit Kumar 1 year, 12 months ago

Libvirt domain XML currently allows only local filepaths 
that can be used to specify a NVRAM disk. It should be
possible to support NVRAM disks on network storage as 
it would give flexibility to start the VM on any host 
without having to worry about where to get the latest 
nvram image.

This series extends the NVRAM element to support hosting over
network-backed disks.
It achieves this by embedding virStorageSource pointer for
nvram into _virDomainLoaderDef.

It introduces a 'type' attribute for NVRAM element to
specify 'file' vs 'network' backed NVRAM.

XML with new annotation:

<nvram type='network'>
  <source protocol='iscsi' name='iqn.2013-07.com.example:iscsi-nopool/0'>
    <host name='example.com' port='6000'/>
      <auth username='myname'>
        <secret type='iscsi' usage='mycluster_myname'/>
      </auth>
    </host>
  </source>
</nvram>

or

<nvram type='network'>
  <source protocol='nbd' name='bar'>
    <host name='example.org' port='6000'/>
  </source>
</nvram>

or

<nvram type='file'>
  <source file='/var/lib/libvirt/nvram/guest_VARS.fd'/>
</nvram>

Changes v1->v2:
 - Split the patch into smaller patches
 - Added unit test
 - Updated the doc
 - Addressed Peter's comment on v1 (https://listman.redhat.com/archives/libvir-list/2022-March/229684.html)

Changes v2->v3:
 - Added authentication with 'iscsi' protocol unit test      
 - Updated the validation logic 
 - Addressed Peter's other comments on v2 patch(https://listman.redhat.com/archives/libvir-list/2022-April/229971.html)
 

Rohit Kumar (5):
  Make NVRAM a virStorageSource type.
  Add support to parse/format/validate virStorageSource type NVRAM
  Update schema, docs, and validation logic to support network backed
    NVRAM
  Add unit tests for network backed NVRAM
  Add unit test to support new 'file' type NVRAM

 NEWS.rst                                      |   5 +
 docs/formatdomain.rst                         |  34 +++++-
 src/conf/domain_conf.c                        | 115 +++++++++++++++---
 src/conf/domain_conf.h                        |   3 +-
 src/conf/schemas/domaincommon.rng             |  21 +++-
 src/qemu/qemu_cgroup.c                        |   3 +-
 src/qemu/qemu_command.c                       |   2 +-
 src/qemu/qemu_domain.c                        |  23 +++-
 src/qemu/qemu_driver.c                        |   5 +-
 src/qemu/qemu_firmware.c                      |  23 +++-
 src/qemu/qemu_namespace.c                     |   5 +-
 src/qemu/qemu_process.c                       |   5 +-
 src/qemu/qemu_validate.c                      |  71 +++++++++++
 src/security/security_dac.c                   |   6 +-
 src/security/security_selinux.c               |   6 +-
 src/security/virt-aa-helper.c                 |   5 +-
 src/vbox/vbox_common.c                        |   3 +-
 .../bios-nvram-file.x86_64-latest.args        |  37 ++++++
 tests/qemuxml2argvdata/bios-nvram-file.xml    |  23 ++++
 .../bios-nvram-network-iscsi.x86_64-4.1.0.err |   1 +
 ...ios-nvram-network-iscsi.x86_64-latest.args |  38 ++++++
 .../bios-nvram-network-iscsi.xml              |  31 +++++
 .../bios-nvram-network-nbd.x86_64-latest.args |  37 ++++++
 .../bios-nvram-network-nbd.xml                |  28 +++++
 tests/qemuxml2argvtest.c                      |   4 +
 .../bios-nvram-file.x86_64-latest.xml         |  39 ++++++
 ...bios-nvram-network-iscsi.x86_64-latest.xml |  44 +++++++
 .../bios-nvram-network-nbd.x86_64-latest.xml  |  41 +++++++
 tests/qemuxml2xmltest.c                       |   3 +
 29 files changed, 618 insertions(+), 43 deletions(-)
 create mode 100644 tests/qemuxml2argvdata/bios-nvram-file.x86_64-latest.args
 create mode 100644 tests/qemuxml2argvdata/bios-nvram-file.xml
 create mode 100644 tests/qemuxml2argvdata/bios-nvram-network-iscsi.x86_64-4.1.0.err
 create mode 100644 tests/qemuxml2argvdata/bios-nvram-network-iscsi.x86_64-latest.args
 create mode 100644 tests/qemuxml2argvdata/bios-nvram-network-iscsi.xml
 create mode 100644 tests/qemuxml2argvdata/bios-nvram-network-nbd.x86_64-latest.args
 create mode 100644 tests/qemuxml2argvdata/bios-nvram-network-nbd.xml
 create mode 100644 tests/qemuxml2xmloutdata/bios-nvram-file.x86_64-latest.xml
 create mode 100644 tests/qemuxml2xmloutdata/bios-nvram-network-iscsi.x86_64-latest.xml
 create mode 100644 tests/qemuxml2xmloutdata/bios-nvram-network-nbd.x86_64-latest.xml

-- 
2.25.1

Re: [PATCH v3 0/5] Introduce network backed NVRAM

Posted by Rohit Kumar 1 year, 11 months ago

Ping.
Hi, requesting review on this patchset.
Thanks!

On 04/05/22 10:21 pm, Rohit Kumar wrote:
> Libvirt domain XML currently allows only local filepaths
> that can be used to specify a NVRAM disk. It should be
> possible to support NVRAM disks on network storage as
> it would give flexibility to start the VM on any host
> without having to worry about where to get the latest
> nvram image.
>
> This series extends the NVRAM element to support hosting over
> network-backed disks.
> It achieves this by embedding virStorageSource pointer for
> nvram into _virDomainLoaderDef.
>
> It introduces a 'type' attribute for NVRAM element to
> specify 'file' vs 'network' backed NVRAM.
>
> XML with new annotation:
>
> <nvram type='network'>
>    <source protocol='iscsi' name='iqn.2013-07.com.example:iscsi-nopool/0'>
>      <host name='example.com' port='6000'/>
>        <auth username='myname'>
>          <secret type='iscsi' usage='mycluster_myname'/>
>        </auth>
>      </host>
>    </source>
> </nvram>
>
> or
>
> <nvram type='network'>
>    <source protocol='nbd' name='bar'>
>      <host name='example.org' port='6000'/>
>    </source>
> </nvram>
>
> or
>
> <nvram type='file'>
>    <source file='/var/lib/libvirt/nvram/guest_VARS.fd'/>
> </nvram>
>
> Changes v1->v2:
>   - Split the patch into smaller patches
>   - Added unit test
>   - Updated the doc
>   - Addressed Peter's comment on v1 (https://listman.redhat.com/archives/libvir-list/2022-March/229684.html)
>
> Changes v2->v3:
>   - Added authentication with 'iscsi' protocol unit test
>   - Updated the validation logic
>   - Addressed Peter's other comments on v2 patch(https://listman.redhat.com/archives/libvir-list/2022-April/229971.html)
>   
>
> Rohit Kumar (5):
>    Make NVRAM a virStorageSource type.
>    Add support to parse/format/validate virStorageSource type NVRAM
>    Update schema, docs, and validation logic to support network backed
>      NVRAM
>    Add unit tests for network backed NVRAM
>    Add unit test to support new 'file' type NVRAM
>
>   NEWS.rst                                      |   5 +
>   docs/formatdomain.rst                         |  34 +++++-
>   src/conf/domain_conf.c                        | 115 +++++++++++++++---
>   src/conf/domain_conf.h                        |   3 +-
>   src/conf/schemas/domaincommon.rng             |  21 +++-
>   src/qemu/qemu_cgroup.c                        |   3 +-
>   src/qemu/qemu_command.c                       |   2 +-
>   src/qemu/qemu_domain.c                        |  23 +++-
>   src/qemu/qemu_driver.c                        |   5 +-
>   src/qemu/qemu_firmware.c                      |  23 +++-
>   src/qemu/qemu_namespace.c                     |   5 +-
>   src/qemu/qemu_process.c                       |   5 +-
>   src/qemu/qemu_validate.c                      |  71 +++++++++++
>   src/security/security_dac.c                   |   6 +-
>   src/security/security_selinux.c               |   6 +-
>   src/security/virt-aa-helper.c                 |   5 +-
>   src/vbox/vbox_common.c                        |   3 +-
>   .../bios-nvram-file.x86_64-latest.args        |  37 ++++++
>   tests/qemuxml2argvdata/bios-nvram-file.xml    |  23 ++++
>   .../bios-nvram-network-iscsi.x86_64-4.1.0.err |   1 +
>   ...ios-nvram-network-iscsi.x86_64-latest.args |  38 ++++++
>   .../bios-nvram-network-iscsi.xml              |  31 +++++
>   .../bios-nvram-network-nbd.x86_64-latest.args |  37 ++++++
>   .../bios-nvram-network-nbd.xml                |  28 +++++
>   tests/qemuxml2argvtest.c                      |   4 +
>   .../bios-nvram-file.x86_64-latest.xml         |  39 ++++++
>   ...bios-nvram-network-iscsi.x86_64-latest.xml |  44 +++++++
>   .../bios-nvram-network-nbd.x86_64-latest.xml  |  41 +++++++
>   tests/qemuxml2xmltest.c                       |   3 +
>   29 files changed, 618 insertions(+), 43 deletions(-)
>   create mode 100644 tests/qemuxml2argvdata/bios-nvram-file.x86_64-latest.args
>   create mode 100644 tests/qemuxml2argvdata/bios-nvram-file.xml
>   create mode 100644 tests/qemuxml2argvdata/bios-nvram-network-iscsi.x86_64-4.1.0.err
>   create mode 100644 tests/qemuxml2argvdata/bios-nvram-network-iscsi.x86_64-latest.args
>   create mode 100644 tests/qemuxml2argvdata/bios-nvram-network-iscsi.xml
>   create mode 100644 tests/qemuxml2argvdata/bios-nvram-network-nbd.x86_64-latest.args
>   create mode 100644 tests/qemuxml2argvdata/bios-nvram-network-nbd.xml
>   create mode 100644 tests/qemuxml2xmloutdata/bios-nvram-file.x86_64-latest.xml
>   create mode 100644 tests/qemuxml2xmloutdata/bios-nvram-network-iscsi.x86_64-latest.xml
>   create mode 100644 tests/qemuxml2xmloutdata/bios-nvram-network-nbd.x86_64-latest.xml
>

Re: [PATCH v3 0/5] Introduce network backed NVRAM

Posted by Rohit Kumar 1 year, 11 months ago

Ping.

Hi Peter,
can you please take a look on this v3 patchset ?

Thanks,
Rohit

On 09/05/22 12:38 pm, Rohit Kumar wrote:
> Ping.
> Hi, requesting review on this patchset.
> Thanks!
>
> On 04/05/22 10:21 pm, Rohit Kumar wrote:
>> Libvirt domain XML currently allows only local filepaths
>> that can be used to specify a NVRAM disk. It should be
>> possible to support NVRAM disks on network storage as
>> it would give flexibility to start the VM on any host
>> without having to worry about where to get the latest
>> nvram image.
>>
>> This series extends the NVRAM element to support hosting over
>> network-backed disks.
>> It achieves this by embedding virStorageSource pointer for
>> nvram into _virDomainLoaderDef.
>>
>> It introduces a 'type' attribute for NVRAM element to
>> specify 'file' vs 'network' backed NVRAM.
>>
>> XML with new annotation:
>>
>> <nvram type='network'>
>>    <source protocol='iscsi' 
>> name='iqn.2013-07.com.example:iscsi-nopool/0'>
>>      <host name='example.com' port='6000'/>
>>        <auth username='myname'>
>>          <secret type='iscsi' usage='mycluster_myname'/>
>>        </auth>
>>      </host>
>>    </source>
>> </nvram>
>>
>> or
>>
>> <nvram type='network'>
>>    <source protocol='nbd' name='bar'>
>>      <host name='example.org' port='6000'/>
>>    </source>
>> </nvram>
>>
>> or
>>
>> <nvram type='file'>
>>    <source file='/var/lib/libvirt/nvram/guest_VARS.fd'/>
>> </nvram>
>>
>> Changes v1->v2:
>>   - Split the patch into smaller patches
>>   - Added unit test
>>   - Updated the doc
>>   - Addressed Peter's comment on v1 
>> (https://listman.redhat.com/archives/libvir-list/2022-March/229684.html)
>>
>> Changes v2->v3:
>>   - Added authentication with 'iscsi' protocol unit test
>>   - Updated the validation logic
>>   - Addressed Peter's other comments on v2 
>> patch(https://listman.redhat.com/archives/libvir-list/2022-April/229971.html)
>>
>> Rohit Kumar (5):
>>    Make NVRAM a virStorageSource type.
>>    Add support to parse/format/validate virStorageSource type NVRAM
>>    Update schema, docs, and validation logic to support network backed
>>      NVRAM
>>    Add unit tests for network backed NVRAM
>>    Add unit test to support new 'file' type NVRAM
>>
>>   NEWS.rst                                      |   5 +
>>   docs/formatdomain.rst                         |  34 +++++-
>>   src/conf/domain_conf.c                        | 115 +++++++++++++++---
>>   src/conf/domain_conf.h                        |   3 +-
>>   src/conf/schemas/domaincommon.rng             |  21 +++-
>>   src/qemu/qemu_cgroup.c                        |   3 +-
>>   src/qemu/qemu_command.c                       |   2 +-
>>   src/qemu/qemu_domain.c                        |  23 +++-
>>   src/qemu/qemu_driver.c                        |   5 +-
>>   src/qemu/qemu_firmware.c                      |  23 +++-
>>   src/qemu/qemu_namespace.c                     |   5 +-
>>   src/qemu/qemu_process.c                       |   5 +-
>>   src/qemu/qemu_validate.c                      |  71 +++++++++++
>>   src/security/security_dac.c                   |   6 +-
>>   src/security/security_selinux.c               |   6 +-
>>   src/security/virt-aa-helper.c                 |   5 +-
>>   src/vbox/vbox_common.c                        |   3 +-
>>   .../bios-nvram-file.x86_64-latest.args        |  37 ++++++
>>   tests/qemuxml2argvdata/bios-nvram-file.xml    |  23 ++++
>>   .../bios-nvram-network-iscsi.x86_64-4.1.0.err |   1 +
>>   ...ios-nvram-network-iscsi.x86_64-latest.args |  38 ++++++
>>   .../bios-nvram-network-iscsi.xml              |  31 +++++
>>   .../bios-nvram-network-nbd.x86_64-latest.args |  37 ++++++
>>   .../bios-nvram-network-nbd.xml                |  28 +++++
>>   tests/qemuxml2argvtest.c                      |   4 +
>>   .../bios-nvram-file.x86_64-latest.xml         |  39 ++++++
>>   ...bios-nvram-network-iscsi.x86_64-latest.xml |  44 +++++++
>>   .../bios-nvram-network-nbd.x86_64-latest.xml  |  41 +++++++
>>   tests/qemuxml2xmltest.c                       |   3 +
>>   29 files changed, 618 insertions(+), 43 deletions(-)
>>   create mode 100644 
>> tests/qemuxml2argvdata/bios-nvram-file.x86_64-latest.args
>>   create mode 100644 tests/qemuxml2argvdata/bios-nvram-file.xml
>>   create mode 100644 
>> tests/qemuxml2argvdata/bios-nvram-network-iscsi.x86_64-4.1.0.err
>>   create mode 100644 
>> tests/qemuxml2argvdata/bios-nvram-network-iscsi.x86_64-latest.args
>>   create mode 100644 tests/qemuxml2argvdata/bios-nvram-network-iscsi.xml
>>   create mode 100644 
>> tests/qemuxml2argvdata/bios-nvram-network-nbd.x86_64-latest.args
>>   create mode 100644 tests/qemuxml2argvdata/bios-nvram-network-nbd.xml
>>   create mode 100644 
>> tests/qemuxml2xmloutdata/bios-nvram-file.x86_64-latest.xml
>>   create mode 100644 
>> tests/qemuxml2xmloutdata/bios-nvram-network-iscsi.x86_64-latest.xml
>>   create mode 100644 
>> tests/qemuxml2xmloutdata/bios-nvram-network-nbd.x86_64-latest.xml
>>

Re: [PATCH v3 0/5] Introduce network backed NVRAM

Posted by Peter Krempa 1 year, 11 months ago

On Mon, May 16, 2022 at 16:03:21 +0530, Rohit Kumar wrote:
> Ping.
> 
> Hi Peter,
> can you please take a look on this v3 patchset ?

Yes, don't worry and please be patient. There are some intricacies that
are not properly handled by your series and rather than me using you as
a email operated remote editor I'll have a proper look and fix certain
aspects.

Re: [PATCH v3 0/5] Introduce network backed NVRAM

Posted by Rohit Kumar 1 year, 11 months ago

On 17/05/22 8:55 pm, Peter Krempa wrote:
> On Mon, May 16, 2022 at 16:03:21 +0530, Rohit Kumar wrote:
>> Ping.
>>
>> Hi Peter,
>> can you please take a look on this v3 patchset ?
> Yes, don't worry and please be patient. There are some intricacies that
> are not properly handled by your series and rather than me using you as
> a email operated remote editor I'll have a proper look and fix certain
> aspects.

Peter,
Thanks a lot for taking the time to look at patches and volunteering to
fix the bits that are not handled properly in this patch. Do let me know
if there is anything I can assist you with, I would be happy to be a part
on this.

Thanks,
Rohit.

PS: please ignore the previous reply to this thread. I sent it with 
wrong formatting.

>

Re: [PATCH v3 0/5] Introduce network backed NVRAM

Posted by Peter Krempa 1 year, 11 months ago

On Thu, Jun 02, 2022 at 16:50:42 +0530, Rohit Kumar wrote:
> 
> On 17/05/22 8:55 pm, Peter Krempa wrote:
> > On Mon, May 16, 2022 at 16:03:21 +0530, Rohit Kumar wrote:
> > > Ping.
> > > 
> > > Hi Peter,
> > > can you please take a look on this v3 patchset ?
> > Yes, don't worry and please be patient. There are some intricacies that
> > are not properly handled by your series and rather than me using you as
> > a email operated remote editor I'll have a proper look and fix certain
> > aspects.
> 
> 
> Peter,
> Thanks a lot for taking the time to look at patches and volunteering to
> fix the bits that are not handled properly in this patch. Do let me know
> if there is anything I can assist you with, I would be happy to be a part
> on this.

Hi Rohit,

I've finally managed to make all adjustments I'd be proposing. I've
posted the series:

 https://listman.redhat.com/archives/libvir-list/2022-June/232167.html

alternatively you can fetch it at:

 git fetch https://gitlab.com/pipo.sk/libvirt.git network-nvram2

Please give it a try and test all your cases. I've ran out of time to
give it testing this week. Ideally also test the old cases.

You can now also provide a 'NEWS.rst'  entry I've stripped out of the
original series as we require that changes to 'NEWS.rst' are done
separately from anything else.

Re: [PATCH v3 0/5] Introduce network backed NVRAM

Posted by Rohit Kumar 1 year, 10 months ago

On 03/06/22 5:21 pm, Peter Krempa wrote:
> On Thu, Jun 02, 2022 at 16:50:42 +0530, Rohit Kumar wrote:
>> On 17/05/22 8:55 pm, Peter Krempa wrote:
>>> On Mon, May 16, 2022 at 16:03:21 +0530, Rohit Kumar wrote:
>>>> Ping.
>>>>
>>>> Hi Peter,
>>>> can you please take a look on this v3 patchset ?
>>> Yes, don't worry and please be patient. There are some intricacies that
>>> are not properly handled by your series and rather than me using you as
>>> a email operated remote editor I'll have a proper look and fix certain
>>> aspects.
>>
>> Peter,
>> Thanks a lot for taking the time to look at patches and volunteering to
>> fix the bits that are not handled properly in this patch. Do let me know
>> if there is anything I can assist you with, I would be happy to be a part
>> on this.
> Hi Rohit,
>
> I've finally managed to make all adjustments I'd be proposing. I've
> posted the series:
>
>   https://urldefense.proofpoint.com/v2/url?u=https-3A__listman.redhat.com_archives_libvir-2Dlist_2022-2DJune_232167.html&d=DwIBAg&c=s883GpUCOChKOHiocYtGcg&r=ABSkr7gy7ZTfApFfI-Xxt1gZNtsDDiXoXOXc0OrkyFs&m=yp7ODgTWyCPv4vE2exi6noSZ2iNzPUlNTiNvSh5A4l9SQR1Av9Z_g-GX2oAQM89T&s=kKHpBT0wOfZSxDEjkUfvIo6xT7S1-GPz0KJGNmzkk0o&e=
>
> alternatively you can fetch it at:
>
>   git fetch https://urldefense.proofpoint.com/v2/url?u=https-3A__gitlab.com_pipo.sk_libvirt.git&d=DwIBAg&c=s883GpUCOChKOHiocYtGcg&r=ABSkr7gy7ZTfApFfI-Xxt1gZNtsDDiXoXOXc0OrkyFs&m=yp7ODgTWyCPv4vE2exi6noSZ2iNzPUlNTiNvSh5A4l9SQR1Av9Z_g-GX2oAQM89T&s=hA8g0qVcO6Et2emoksZNeXyQf_p5k9ik72d4bnOPWyw&e=  network-nvram2
>
> Please give it a try and test all your cases. I've ran out of time to
> give it testing this week. Ideally also test the old cases.


Hi Peter,

Thanks for the working on this.

I have tested the v4 patchset with tests related to UEFI and secureboot.
All tests are passing.

>
> You can now also provide a 'NEWS.rst'  entry I've stripped out of the
> original series as we require that changes to 'NEWS.rst' are done
> separately from anything else.

Sure. I will send a patch soon to update 'NEWS.rst'.

Thanks,
Rohit.

>

Re: [PATCH v3 0/5] Introduce network backed NVRAM

Posted by Ani Sinha 1 year, 10 months ago

On Mon, Jun 13, 2022 at 10:15 AM Rohit Kumar <rohit.kumar3@nutanix.com> wrote:
>
>
> On 03/06/22 5:21 pm, Peter Krempa wrote:
> > On Thu, Jun 02, 2022 at 16:50:42 +0530, Rohit Kumar wrote:
> >> On 17/05/22 8:55 pm, Peter Krempa wrote:
> >>> On Mon, May 16, 2022 at 16:03:21 +0530, Rohit Kumar wrote:
> >>>> Ping.
> >>>>
> >>>> Hi Peter,
> >>>> can you please take a look on this v3 patchset ?
> >>> Yes, don't worry and please be patient. There are some intricacies that
> >>> are not properly handled by your series and rather than me using you as
> >>> a email operated remote editor I'll have a proper look and fix certain
> >>> aspects.
> >>
> >> Peter,
> >> Thanks a lot for taking the time to look at patches and volunteering to
> >> fix the bits that are not handled properly in this patch. Do let me know
> >> if there is anything I can assist you with, I would be happy to be a part
> >> on this.
> > Hi Rohit,
> >
> > I've finally managed to make all adjustments I'd be proposing. I've
> > posted the series:
> >
> >   https://urldefense.proofpoint.com/v2/url?u=https-3A__listman.redhat.com_archives_libvir-2Dlist_2022-2DJune_232167.html&d=DwIBAg&c=s883GpUCOChKOHiocYtGcg&r=ABSkr7gy7ZTfApFfI-Xxt1gZNtsDDiXoXOXc0OrkyFs&m=yp7ODgTWyCPv4vE2exi6noSZ2iNzPUlNTiNvSh5A4l9SQR1Av9Z_g-GX2oAQM89T&s=kKHpBT0wOfZSxDEjkUfvIo6xT7S1-GPz0KJGNmzkk0o&e=
> >
> > alternatively you can fetch it at:
> >
> >   git fetch https://urldefense.proofpoint.com/v2/url?u=https-3A__gitlab.com_pipo.sk_libvirt.git&d=DwIBAg&c=s883GpUCOChKOHiocYtGcg&r=ABSkr7gy7ZTfApFfI-Xxt1gZNtsDDiXoXOXc0OrkyFs&m=yp7ODgTWyCPv4vE2exi6noSZ2iNzPUlNTiNvSh5A4l9SQR1Av9Z_g-GX2oAQM89T&s=hA8g0qVcO6Et2emoksZNeXyQf_p5k9ik72d4bnOPWyw&e=  network-nvram2
> >
> > Please give it a try and test all your cases. I've ran out of time to
> > give it testing this week. Ideally also test the old cases.
>
>
> Hi Peter,
>
> Thanks for the working on this.
>
> I have tested the v4 patchset with tests related to UEFI and secureboot.
> All tests are passing.
>
> >
> > You can now also provide a 'NEWS.rst'  entry I've stripped out of the
> > original series as we require that changes to 'NEWS.rst' are done
> > separately from anything else.
>
> Sure. I will send a patch soon to update 'NEWS.rst'.

When you send updated patchset with NEWS.rst, please add

Tested-by: Rohit Kumar <rohit.kumar3@nutanix.com>

tag to the patches.

Re: [PATCH v3 0/5] Introduce network backed NVRAM

Posted by Peter Krempa 1 year, 10 months ago

On Tue, Jun 14, 2022 at 12:18:34 +0530, Ani Sinha wrote:
> On Mon, Jun 13, 2022 at 10:15 AM Rohit Kumar <rohit.kumar3@nutanix.com> wrote:
> >
> >
> > On 03/06/22 5:21 pm, Peter Krempa wrote:
> > > On Thu, Jun 02, 2022 at 16:50:42 +0530, Rohit Kumar wrote:
> > >> On 17/05/22 8:55 pm, Peter Krempa wrote:
> > >>> On Mon, May 16, 2022 at 16:03:21 +0530, Rohit Kumar wrote:

[...]

> > > You can now also provide a 'NEWS.rst'  entry I've stripped out of the
> > > original series as we require that changes to 'NEWS.rst' are done
> > > separately from anything else.
> >
> > Sure. I will send a patch soon to update 'NEWS.rst'.
> 
> When you send updated patchset with NEWS.rst, please add

I'm hadnlding the patches adding the code and they don't need to be
re-posted any more. Rohit is only supposed to send the patch adding the
NEWS entry as that is in a separate patch anyways.

> Tested-by: Rohit Kumar <rohit.kumar3@nutanix.com>

I can add this tag to the patches but only if Rohit agrees (ideally by
responding to my posting of the series, to track it properly). I can't
add patches on behalf of others.

Re: [PATCH v3 0/5] Introduce network backed NVRAM

Posted by Rohit Kumar 1 year, 10 months ago

On 14/06/22 3:51 pm, Peter Krempa wrote:
> On Tue, Jun 14, 2022 at 12:18:34 +0530, Ani Sinha wrote:
>> On Mon, Jun 13, 2022 at 10:15 AM Rohit Kumar <rohit.kumar3@nutanix.com> wrote:
>>>
>>> On 03/06/22 5:21 pm, Peter Krempa wrote:
>>>> On Thu, Jun 02, 2022 at 16:50:42 +0530, Rohit Kumar wrote:
>>>>> On 17/05/22 8:55 pm, Peter Krempa wrote:
>>>>>> On Mon, May 16, 2022 at 16:03:21 +0530, Rohit Kumar wrote:
> [...]
>
>>>> You can now also provide a 'NEWS.rst'  entry I've stripped out of the
>>>> original series as we require that changes to 'NEWS.rst' are done
>>>> separately from anything else.
>>> Sure. I will send a patch soon to update 'NEWS.rst'.
>> When you send updated patchset with NEWS.rst, please add
> I'm hadnlding the patches adding the code and they don't need to be
> re-posted any more. Rohit is only supposed to send the patch adding the
> NEWS entry as that is in a separate patch anyways.
>
>> Tested-by: Rohit Kumar <rohit.kumar3@nutanix.com>
> I can add this tag to the patches but only if Rohit agrees (ideally by
> responding to my posting of the series, to track it properly). I can't
> add patches on behalf of others.
Hi Peter, feel free to add "Tested-by" tag on my behalf  on v4 patches 
of the series.

Tested-by: Rohit Kumar <rohit.kumar3@nutanix.com>

I'll reply to v4 patchset as well regarding this.
>

Re: [PATCH v3 0/5] Introduce network backed NVRAM

Posted by Rohit Kumar 1 year, 11 months ago

On 17/05/22 8:55 pm, Peter Krempa wrote:
> On Mon, May 16, 2022 at 16:03:21 +0530, Rohit Kumar wrote:
>> Ping.
>>
>> Hi Peter,
>> can you please take a look on this v3 patchset ?
> Yes, don't worry and please be patient. There are some intricacies that
> are not properly handled by your series and rather than me using you as
> a email operated remote editor I'll have a proper look and fix certain
> aspects.

Peter,
Thanks a lot for taking the time to look at patches and for volunteering to
fix the bits that are not handled properly in this patch. Do let me know
if there is anything I can assist you with, I would be happy to be a part on this.

Thanks,
Rohit

>