From nobody Sat May 18 09:48:33 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) client-ip=170.10.129.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=none dis=none) header.from=gmail.com Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.zohomail.com with SMTPS id 1650505700168416.6858539881232; Wed, 20 Apr 2022 18:48:20 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-615-rmLrfIhAOC6OuseM5mOlVg-1; Wed, 20 Apr 2022 21:48:16 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 4CE91296A62F; Thu, 21 Apr 2022 01:48:14 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id AB5FD40EC01A; Thu, 21 Apr 2022 01:48:11 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 5DBA21949763; Thu, 21 Apr 2022 01:48:11 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id E8E7119451EC for ; Thu, 21 Apr 2022 01:48:09 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id B4648572337; Thu, 21 Apr 2022 01:48:09 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast05.extmail.prod.ext.rdu2.redhat.com [10.11.55.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B06C057233B for ; Thu, 21 Apr 2022 01:48:09 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 8FF968002BF for ; Thu, 21 Apr 2022 01:48:09 +0000 (UTC) Received: from mail-qt1-f170.google.com (mail-qt1-f170.google.com [209.85.160.170]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-39-4Rh1atX1NQiNq6rOb4Ys0A-1; Wed, 20 Apr 2022 21:48:07 -0400 Received: by mail-qt1-f170.google.com with SMTP id d14so2328017qtw.5 for ; Wed, 20 Apr 2022 18:48:07 -0700 (PDT) Received: from south.. ([2601:182:300:6ce:8858:59ff:fe0c:9c97]) by smtp.gmail.com with ESMTPSA id s19-20020a05622a179300b002e1ceeb21d0sm2797028qtk.97.2022.04.20.18.48.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Apr 2022 18:48:05 -0700 (PDT) X-MC-Unique: rmLrfIhAOC6OuseM5mOlVg-1 X-Original-To: libvir-list@listman.corp.redhat.com X-MC-Unique: 4Rh1atX1NQiNq6rOb4Ys0A-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=o2crrssBFLkqlfT6p+x36nSVSIebJf/gljHV/8xtZvw=; b=e6EUiGj8/5GmMPNHK70Dq9QYFgGGQeEZl8oFddaC7QIpL6VAsyktUmk3I/w1yJxa4D Q24GUWvXDU5ua3l9gX/nsd1biobd0/Dwu8exIpgxDg++K2Y+iI7A3KllrzowrKAD33uy xJfZLcDf4JfcKdRNojqznFLvVAvr6W9SkkZZnSSiR+T69dubsi6guogzEJLWDJwoFWTg 1QISdjJAybitDwEKJ6xuqHgdgofzzMcr3EFIH7vpXcyhoq+Fq5KDz+dPSiYTGLjKX541 rJoUZNuXryYnznVaIRiOp9RJXRduJWvv3d/SnBIWPZ3IhbKq6ZG6My3X4L+0a+8AsiFN ZI4w== X-Gm-Message-State: AOAM530hc5mBVl03YNcSFM6QgTVsBGcZHBvYzLQw3HT1sZhf8zjCgo9V TrE1RJhQjykV3fVzqvj5zfcMD3fVJEA= X-Google-Smtp-Source: ABdhPJzpbkyVL5hek6ZL6H18UB1jXmBtWg/xzdg4I/E9p9qhHn4IDDctuJutUbdOPJvhG8T5V/yP2Q== X-Received: by 2002:ac8:474d:0:b0:2f1:ef9c:b741 with SMTP id k13-20020ac8474d000000b002f1ef9cb741mr16063861qtp.178.1650505686505; Wed, 20 Apr 2022 18:48:06 -0700 (PDT) From: Justin Gatzen To: libvir-list@redhat.com Subject: [PATCH] qemu: Check usage count of qemu:override node Date: Wed, 20 Apr 2022 21:48:03 -0400 Message-Id: <20220421014803.77482-1-justin.gatzen@gmail.com> MIME-Version: 1.0 X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.85 on 10.11.54.10 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Justin Gatzen Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 2.84 on 10.11.54.2 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZM-MESSAGEID: 1650505700808100001 Content-Type: text/plain; charset="utf-8"; x-default="true" When is the only usage of the qemu namespace the entire section is mistakenly removed. Add check for use count. Signed-off-by: Justin Gatzen Reviewed-by: Michal Privoznik --- src/qemu/qemu_domain.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index 95134a3570..00c209313b 100644 --- a/src/qemu/qemu_domain.c +++ b/src/qemu/qemu_domain.c @@ -3514,7 +3514,8 @@ qemuDomainDefNamespaceParse(xmlXPathContextPtr ctxt, =20 if (nsdata->args || nsdata->num_env > 0 || nsdata->capsadd || nsdata->capsdel || - nsdata->deprecationBehavior) + nsdata->deprecationBehavior || + nsdata->ndeviceOverride > 0) *data =3D g_steal_pointer(&nsdata); =20 ret =3D 0; --=20 2.35.1